Re: [PATCH] staging: sm750fb: modify function name to kernel code style

Richard Akintola
2025-04-03T22:38:03Z

Hi,

Yes I did send two different patches (part of the reason I used
different subject lines),
they did similar things (change camelCase to snake_case, I wanted to
get all done in the file,
but I learnt it is best done one at a time.

So should I have it all done in the file (there are more than 2
camelCase CHECKs), or send it
one after the other? (but you could take the first).

Thanks

Richard Akintola

On Thu, Apr 3, 2025 at 3:18 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Mon, Mar 31, 2025 at 09:53:36AM +0100, Richard Akintola wrote:
> > Change camelCase function name sii164ResetChip to sii164_reset_chip
> > as reported by checkpatch.pl
> >
> > CHECK: Avoid camelCase: <sii164ResetChip>
> >
> > Signed-off-by: Richard Akintola <princerichard17a@gmail.com>
> > ---
> > drivers/staging/sm750fb/ddk750_dvi.c | 2 +-
> > drivers/staging/sm750fb/ddk750_sii164.c | 4 ++--
> > drivers/staging/sm750fb/ddk750_sii164.h | 2 +-
> > 3 files changed, 4 insertions(+), 4 deletions(-)
>
> You sent 2 different patches with different subject lines, yet they
> almost did the same thing? Which one should I take or review? Please
> send a new one, as a version 3, and properly document what changed
> between this one and the last 2 submissions.
>
> thanks,
>
> greg k-h