From: Markus Elfring <Markus.Elfring@web.de>
To: hanzhijian1991@gmail.com, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Daniel Palmer <daniel@thingy.jp>,
Michael Turquette <mturquette@baylibre.com>,
Romain Perier <romain.perier@gmail.com>,
Stephen Boyd <sboyd@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Brian Masney <bmasney@redhat.com>
Subject: Re: [PATCH] clk: mstar: msc313-mpll: fix off-by-one in clock array allocation
Date: Mon, 24 Aug 2026 13:30:34 +0200 [thread overview]
Message-ID: <67ec3261-9f3d-4dcc-b916-19dc8be56a6e@web.de> (raw)
In-Reply-To: <20260821235837.2341179-1-hanzhijian1991@gmail.com>
…
> Use NUMOUTPUTS as the element count so the allocation matches the
> number of clocks actually stored and exposed.
>
> Found by smatch:
> drivers/clk/mstar/clk-msc313-mpll.c:134 msc313_mpll_probe()
> error: buffer overflow 'mpll->clk_data->hws' 7 <= 7
How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?
See also:
* https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v7.2#n145
* https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/stable-kernel-rules.rst?h=v7.2#n34
Regards,
Markus
next prev parent reply other threads:[~2026-08-24 11:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-21 23:58 [PATCH] clk: mstar: msc313-mpll: fix off-by-one in clock array allocation hanzhijian
2026-08-24 11:30 ` Markus Elfring [this message]
2026-08-24 14:28 ` [PATCH v2] " hanzhijian
2026-08-24 16:00 ` Brian Masney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67ec3261-9f3d-4dcc-b916-19dc8be56a6e@web.de \
--to=markus.elfring@web.de \
--cc=bmasney@redhat.com \
--cc=daniel@thingy.jp \
--cc=hanzhijian1991@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=romain.perier@gmail.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox