* [PATCH] platform/x86/intel: power-domains: Fix error code in tpmi_init()
@ 2025-06-06 9:04 Dan Carpenter
2025-06-06 14:28 ` srinivas pandruvada
2025-06-09 7:52 ` Ilpo Järvinen
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2025-06-06 9:04 UTC (permalink / raw)
To: Srinivas Pandruvada
Cc: Hans de Goede, Ilpo Järvinen, Peter Zijlstra, Greg KH,
Ingo Molnar, platform-driver-x86, linux-kernel, kernel-janitors
Return -ENOMEM instead of success if kcalloc() fails.
Fixes: e37be5d85c60 ("platform/x86/intel: power-domains: Add interface to get Linux die ID")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/platform/x86/intel/tpmi_power_domains.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86/intel/tpmi_power_domains.c b/drivers/platform/x86/intel/tpmi_power_domains.c
index 0c5c88eb7baf..9d8247bb9cfa 100644
--- a/drivers/platform/x86/intel/tpmi_power_domains.c
+++ b/drivers/platform/x86/intel/tpmi_power_domains.c
@@ -228,8 +228,10 @@ static int __init tpmi_init(void)
domain_die_map = kcalloc(size_mul(topology_max_packages(), MAX_POWER_DOMAINS),
sizeof(*domain_die_map), GFP_KERNEL);
- if (!domain_die_map)
+ if (!domain_die_map) {
+ ret = -ENOMEM;
goto free_domain_mask;
+ }
ret = cpuhp_setup_state(CPUHP_AP_ONLINE_DYN,
"platform/x86/tpmi_power_domains:online",
--
2.47.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] platform/x86/intel: power-domains: Fix error code in tpmi_init()
2025-06-06 9:04 [PATCH] platform/x86/intel: power-domains: Fix error code in tpmi_init() Dan Carpenter
@ 2025-06-06 14:28 ` srinivas pandruvada
2025-06-09 7:52 ` Ilpo Järvinen
1 sibling, 0 replies; 3+ messages in thread
From: srinivas pandruvada @ 2025-06-06 14:28 UTC (permalink / raw)
To: Dan Carpenter
Cc: Hans de Goede, Ilpo Järvinen, Peter Zijlstra, Greg KH,
Ingo Molnar, platform-driver-x86, linux-kernel, kernel-janitors
On Fri, 2025-06-06 at 12:04 +0300, Dan Carpenter wrote:
> Return -ENOMEM instead of success if kcalloc() fails.
>
> Fixes: e37be5d85c60 ("platform/x86/intel: power-domains: Add
> interface to get Linux die ID")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Acked-by:Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
> drivers/platform/x86/intel/tpmi_power_domains.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel/tpmi_power_domains.c
> b/drivers/platform/x86/intel/tpmi_power_domains.c
> index 0c5c88eb7baf..9d8247bb9cfa 100644
> --- a/drivers/platform/x86/intel/tpmi_power_domains.c
> +++ b/drivers/platform/x86/intel/tpmi_power_domains.c
> @@ -228,8 +228,10 @@ static int __init tpmi_init(void)
>
> domain_die_map = kcalloc(size_mul(topology_max_packages(),
> MAX_POWER_DOMAINS),
> sizeof(*domain_die_map),
> GFP_KERNEL);
> - if (!domain_die_map)
> + if (!domain_die_map) {
> + ret = -ENOMEM;
> goto free_domain_mask;
> + }
>
> ret = cpuhp_setup_state(CPUHP_AP_ONLINE_DYN,
> "platform/x86/tpmi_power_domains:onl
> ine",
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] platform/x86/intel: power-domains: Fix error code in tpmi_init()
2025-06-06 9:04 [PATCH] platform/x86/intel: power-domains: Fix error code in tpmi_init() Dan Carpenter
2025-06-06 14:28 ` srinivas pandruvada
@ 2025-06-09 7:52 ` Ilpo Järvinen
1 sibling, 0 replies; 3+ messages in thread
From: Ilpo Järvinen @ 2025-06-09 7:52 UTC (permalink / raw)
To: Srinivas Pandruvada, Dan Carpenter
Cc: Hans de Goede, Peter Zijlstra, Greg KH, Ingo Molnar,
platform-driver-x86, linux-kernel, kernel-janitors
On Fri, 06 Jun 2025 12:04:32 +0300, Dan Carpenter wrote:
> Return -ENOMEM instead of success if kcalloc() fails.
>
>
Thank you for your contribution, it has been applied to my local
review-ilpo-fixes branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
local branch there, which might take a while.
The list of commits applied:
[1/1] platform/x86/intel: power-domains: Fix error code in tpmi_init()
commit: 1d0a61940e22e165e6acc4a9c6fb26edbe69112e
--
i.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-06-09 7:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-06 9:04 [PATCH] platform/x86/intel: power-domains: Fix error code in tpmi_init() Dan Carpenter
2025-06-06 14:28 ` srinivas pandruvada
2025-06-09 7:52 ` Ilpo Järvinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).