From: Jens Axboe <axboe@kernel.dk>
To: John Garry <john.garry@huawei.com>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
ming.lei@redhat.com, kashyap.desai@broadcom.com, hare@suse.de
Subject: Re: [PATCH v2 0/3] blk-mq: Optimise blk_mq_queue_tag_busy_iter() for shared tags
Date: Mon, 6 Dec 2021 12:07:00 -0700 [thread overview]
Message-ID: <67feacc8-3da7-90de-cc0c-f8b529f84297@kernel.dk> (raw)
In-Reply-To: <1638794990-137490-1-git-send-email-john.garry@huawei.com>
On 12/6/21 5:49 AM, John Garry wrote:
> In [0] Kashyap reports high CPU usage for blk_mq_queue_tag_busy_iter()
> and callees for shared tags.
>
> Indeed blk_mq_queue_tag_busy_iter() would be less optimum for moving to
> shared tags, but it was not optimum previously.
>
> This series optimises by having only a single iter (per regular and resv
> tags) for the shared tags, instead of an iter per HW queue.
>
> [0] https://lore.kernel.org/linux-block/e4e92abbe9d52bcba6b8cc6c91c442cc@mail.gmail.com/
The patch(es) are missing Fixes tags.
--
Jens Axboe
next prev parent reply other threads:[~2021-12-06 19:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-06 12:49 [PATCH v2 0/3] blk-mq: Optimise blk_mq_queue_tag_busy_iter() for shared tags John Garry
2021-12-06 12:49 ` [PATCH v2 1/3] blk-mq: Drop busy_iter_fn blk_mq_hw_ctx argument John Garry
2021-12-06 12:49 ` [PATCH v2 2/3] blk-mq: Delete busy_iter_fn John Garry
2021-12-06 12:49 ` [PATCH v2 3/3] blk-mq: Optimise blk_mq_queue_tag_busy_iter() for shared tags John Garry
2021-12-06 20:10 ` John Garry
2021-12-06 19:07 ` Jens Axboe [this message]
2021-12-06 19:34 ` [PATCH v2 0/3] " John Garry
2021-12-06 19:48 ` Jens Axboe
2021-12-06 19:59 ` John Garry
2021-12-07 16:18 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67feacc8-3da7-90de-cc0c-f8b529f84297@kernel.dk \
--to=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=john.garry@huawei.com \
--cc=kashyap.desai@broadcom.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox