From: "Karoly Pados" <pados@pados.hu>
To: "Johan Hovold" <johan@kernel.org>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
"Loic Poulain" <loic.poulain@linaro.org>,
andy.shevchenko@gmail.com, ajaykuee@gmail.com,
daniel.thompson@linaro.org
Subject: Re: [PATCH] USB: serial: ftdi_sio: implement GPIO support for FT230X
Date: Tue, 04 Sep 2018 18:07:49 +0000 [thread overview]
Message-ID: <680c039b5fb2beafa48ea12e492341db@pados.hu> (raw)
In-Reply-To: <2d91567c930ae5770cc55f92c37a9c6d@pados.hu>
>>> + priv->gc.ngpio = 4;
>>
>> Shouldn't this be handled the other way round? IIRC there are two FTX
>> device types with four pins, and one type where only one pin is
>> accessible.
>
> There are 4 devices with 1 GPIO, 1 device with 2 GPIOs, 2 devices with 4 GPIOs,
> and 1 device with 6 GPIOs. Source: http://www.ftdichip.com/FT-X.htm (2nd table)
> Do you still want me turn this over?
>
Aaah, but those other devices are not UART bridges. I see what you mean now.
The point for me when developing th original patch
next prev parent reply other threads:[~2018-09-04 18:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-25 20:47 [PATCH] USB: serial: ftdi_sio: implement GPIO support for FT230X Karoly Pados
2018-08-28 0:44 ` kbuild test robot
2018-09-04 12:49 ` Johan Hovold
2018-09-04 17:53 ` Karoly Pados
2018-09-04 18:07 ` Karoly Pados [this message]
2018-09-05 8:21 ` Johan Hovold
2018-09-05 8:19 ` Johan Hovold
2018-09-05 10:36 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=680c039b5fb2beafa48ea12e492341db@pados.hu \
--to=pados@pados.hu \
--cc=ajaykuee@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=daniel.thompson@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=loic.poulain@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox