From: Heiko Stuebner <heiko@sntech.de>
To: Otavio Salvador <otavio@ossystems.com.br>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH] ARM: dts: rv1108-evb: enable eMMC support
Date: Tue, 16 Oct 2018 15:09:01 +0200 [thread overview]
Message-ID: <6815120.yyevdQbq0d@phil> (raw)
In-Reply-To: <20181009213656.27719-1-otavio@ossystems.com.br>
Hi Otavio,
Am Dienstag, 9. Oktober 2018, 23:36:56 CEST schrieb Otavio Salvador:
> Enable eMMC support for rv1108 evaluation board.
>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
>
> arch/arm/boot/dts/rv1108-evb.dts | 8 ++++++++
> arch/arm/boot/dts/rv1108.dtsi | 29 +++++++++++++++++++++++++++++
> 2 files changed, 37 insertions(+)
>
> diff --git a/arch/arm/boot/dts/rv1108-evb.dts b/arch/arm/boot/dts/rv1108-evb.dts
> index 70f0106d1252..f3c6f52c49e6 100644
> --- a/arch/arm/boot/dts/rv1108-evb.dts
> +++ b/arch/arm/boot/dts/rv1108-evb.dts
> @@ -226,6 +226,14 @@
> status = "okay";
> };
>
> +&emmc {
> + cap-mmc-highspeed;
> + supports-emmc;
> + non-removable;
> + num-slots = <1>;
num-slots should not be present anymore on new additions
Also missing the pinctrl settings you're defining below?
Aka pinctrl-0 = <&emmc_*>; + pinctrl-names = "default"
Heiko
> + status = "okay";
> +};
> +
> &u2phy {
> status = "okay";
>
> diff --git a/arch/arm/boot/dts/rv1108.dtsi b/arch/arm/boot/dts/rv1108.dtsi
> index 76ea24636feb..f14a733d85f6 100644
> --- a/arch/arm/boot/dts/rv1108.dtsi
> +++ b/arch/arm/boot/dts/rv1108.dtsi
> @@ -772,6 +772,35 @@
> };
> };
>
> + emmc {
> + emmc_clk: emmc-clk {
> + rockchip,pins = <2 RK_PB6 RK_FUNC_1 &pcfg_pull_none_drv_8ma>;
> + };
> +
> + emmc_cmd: emmc-cmd {
> + rockchip,pins = <2 RK_PB4 RK_FUNC_2 &pcfg_pull_up_drv_8ma>;
> + };
> +
> + emmc_pwren: emmc-pwren {
> + rockchip,pins = <2 RK_PC2 RK_FUNC_2 &pcfg_pull_none>;
> + };
> +
> + emmc_bus1: emmc-bus1 {
> + rockchip,pins = <2 RK_PA0 RK_FUNC_2 &pcfg_pull_up_drv_8ma>;
> + };
> +
> + emmc_bus8: emmc-bus8 {
> + rockchip,pins = <2 RK_PA0 RK_FUNC_2 &pcfg_pull_up_drv_8ma>,
> + <2 RK_PA1 RK_FUNC_2 &pcfg_pull_up_drv_8ma>,
> + <2 RK_PA2 RK_FUNC_2 &pcfg_pull_up_drv_8ma>,
> + <2 RK_PA3 RK_FUNC_2 &pcfg_pull_up_drv_8ma>,
> + <2 RK_PA4 RK_FUNC_2 &pcfg_pull_up_drv_8ma>,
> + <2 RK_PA5 RK_FUNC_2 &pcfg_pull_up_drv_8ma>,
> + <2 RK_PA6 RK_FUNC_2 &pcfg_pull_up_drv_8ma>,
> + <2 RK_PA7 RK_FUNC_2 &pcfg_pull_up_drv_8ma>;
> + };
> + };
> +
> sdmmc {
> sdmmc_clk: sdmmc-clk {
> rockchip,pins = <3 RK_PC4 RK_FUNC_1 &pcfg_pull_none_drv_4ma>;
>
next prev parent reply other threads:[~2018-10-16 13:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 21:36 [PATCH] ARM: dts: rv1108-evb: enable eMMC support Otavio Salvador
2018-10-16 13:09 ` Heiko Stuebner [this message]
2018-11-25 20:53 ` Otavio Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6815120.yyevdQbq0d@phil \
--to=heiko@sntech.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=otavio@ossystems.com.br \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox