From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752501AbbJMH6X (ORCPT ); Tue, 13 Oct 2015 03:58:23 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:51753 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752264AbbJMH6W (ORCPT ); Tue, 13 Oct 2015 03:58:22 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Robert Jarzmik , Daniel Mack , Eric Miao , Haojian Zhuang , linux-kernel@vger.kernel.org Subject: Re: [PATCH] pxa: remove incorrect __init annotation on pxa27x_set_pwrmode Date: Tue, 13 Oct 2015 09:57:53 +0200 Message-ID: <6820669.agSbTbzqFV@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <87fv1f6bjj.fsf@belgarion.home> References: <5287252.pkh9x0t1Y6@wuerfel> <5395757.goqVg4VzNo@wuerfel> <87fv1f6bjj.fsf@belgarion.home> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:MoHTfakT/xQTwR4lpkcESsTAm5RmJQmUq6lpOv8h4psaH+GkML1 /Nw/FBGpv99XpxZzZsIFVEsh4eucyzrvvRkP+qLd2eHbBPZ6Y/X8WIOs9/OqoJzTdjdyPjF /bnLZ1xj7k5DadsNlrpdRLW4kNIIbgAMiZ0TCyPDEcEZnol4M6h2LoknK+jE08bKLRf9WpQ dAAu+qlxPaJpV4oRkUOSg== X-UI-Out-Filterresults: notjunk:1;V01:K0:bnjaXbYDsks=:KdvH0eq2slJ6srd1avBtgW OVOrCMR13Zef1v2TmCzCys40f+LesvqoDm1eUB8lDm6U0iirXJ4RFC590yaEdDnHeLeBbVCt8 AiKqyHKxDZ519oKgs3dKEU/1kokuXdeC6T4GdemW/v7odIy4LZDmhp81MVCX8WCsEnqL5kbkW jWl4wAmrv9ZXcA7rV42IX1x8qBd/GOg0IW7lsXBjK0OuEjF8sS8lmgEvv7+vfCvw/7RVglZR6 ROkx+MdW1I35m/6+m8yuOs84CrMzxLm+dLrDXXmPZa9oAcsNSO4miJi1R4zkSC/HMDRUoMuT1 PhJNRPoOwKB9zmCLL23XkBbGJKpdwqerZDLD8tPdEQ62Umya5bvVQrXPFWIILuEwpoMPxTMc5 pawDnb506gPWthdXIhRDNfHwJTiexZMy5qll7j1V8nvyNIizolvCQItf3sSmPrHmTWlO+lXnD B66AkdaqtWRLy9Bh4V0shVpcKHxH1TMtIq9AXrm6FFwPAgX+z9Typ24sMkzisCex8VdMOQE/G L9b5/yCGEP/wI4NyqPGUaFVBYoSoJcTanfQ2gSKqulmIR1QF3wSdfIYiUDHQhT7UoRE1pthLd 4Fb1Y/CfUpqZ0nJ9fD5OFQLAEwZwSrMM6ftc0V9W9CV3U8GJm+uTdLcSqEtYSnAHPn6j7Ldrh YoB8MaOqynE4RqJBgekS8BU2PMLGBTLptLTK6hQHxq2rc/gcjmDCppMXL1XGqvUOfJbhwAh7t nzslpsoboVrOGKXR Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 12 October 2015 23:07:28 Robert Jarzmik wrote: > Arnd Bergmann writes: > > The z2 in particular never did, except in the powerdown handler. So if it > > is unable to wake up reliably from DEEPSLEEP, that may be a reason to use > > that flag only in the poweroff function but not during normal operation. > My first thought was : > This flag's only use is for Suspend to RAM. There might be special > wirings where the voltage to the RAM is provided out of SYS_EN pin > control, and therefore PWRMODE_DEEPSLEEP is possible. But the most > common pattern would be a PMIC, providing voltage to the DRAM through > Vcc_Mem. > > But having a closer look, you're right, I have misunderstood the way z2 poweroff > was designed. The setting of poweroff to PWRMODE_DEEPSLEEP + > pxa27x_cpu_pm_enter() is a whole, it is the closest to a platform halt where no > external chip handles the poweroff phase, and memory is shutdown in deep sleep. > > Therefore I'll drop Thierry's patch (which would actually break suspend to RAM I > think) and take yours. Ok, sounds good. thanks! Arnd