From: Chengming Zhou <chengming.zhou@linux.dev>
To: Christoph Hellwig <hch@lst.de>
Cc: axboe@kernel.dk, ming.lei@redhat.com,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
zhouchengming@bytedance.com
Subject: Re: [PATCH 1/2] blk-flush: fix rq->flush.seq for post-flush requests
Date: Tue, 11 Jul 2023 19:52:11 +0800 [thread overview]
Message-ID: <6825f687-9573-51eb-bb89-17eadb60f71b@linux.dev> (raw)
In-Reply-To: <20230711113126.GA26978@lst.de>
On 2023/7/11 19:31, Christoph Hellwig wrote:
> On Tue, Jul 11, 2023 at 07:06:20PM +0800, Chengming Zhou wrote:
>> Ok, will add a Fixes tag and send it as a separate patch since it's a bug fix.
>
> Btw, it's probably not worth resending patch 2 until we've figured out
> and dealt with the SATA flush regression that Chuck reported.
Ok, I will not resend patch 2. As for the patch 1, should I resend it as a separate patch
or just put it in that series [1] before other flush optimizations ?
I search on the block mail list, find the issue [2] you mentioned, will look into it too.
[1] https://lore.kernel.org/lkml/20230707093722.1338589-1-chengming.zhou@linux.dev/
[2] https://lore.kernel.org/linux-block/7A57C7AE-A51A-4254-888B-FE15CA21F9E9@oracle.com/
next prev parent reply other threads:[~2023-07-11 11:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 6:47 [PATCH 1/2] blk-flush: fix rq->flush.seq for post-flush requests chengming.zhou
2023-07-10 6:47 ` [PATCH 2/2] blk-flush: don't need to end rq twice for non " chengming.zhou
2023-07-10 13:33 ` Christoph Hellwig
2023-07-25 13:15 ` Chengming Zhou
2023-07-10 13:30 ` [PATCH 1/2] blk-flush: fix rq->flush.seq for " Christoph Hellwig
2023-07-11 11:06 ` Chengming Zhou
2023-07-11 11:15 ` [External] " Chengming Zhou
2023-07-11 11:31 ` Christoph Hellwig
2023-07-11 11:52 ` Chengming Zhou [this message]
2023-07-11 12:09 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6825f687-9573-51eb-bb89-17eadb60f71b@linux.dev \
--to=chengming.zhou@linux.dev \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=zhouchengming@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox