From: Pkshih <pkshih@realtek.com>
To: Yang Li <yang.lee@linux.alibaba.com>,
"davem@davemloft.net" <davem@davemloft.net>
Cc: "kuba@kernel.org" <kuba@kernel.org>,
"kvalo@codeaurora.org" <kvalo@codeaurora.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH -next] rtw89: remove unneeded semicolon
Date: Tue, 19 Oct 2021 09:13:52 +0000 [thread overview]
Message-ID: <68265a886f8f4ce1a4e9b64b4d80b5a8@realtek.com> (raw)
In-Reply-To: <1634630094-1156-1-git-send-email-yang.lee@linux.alibaba.com>
> -----Original Message-----
> From: Yang Li <yang.lee@linux.alibaba.com>
> Sent: Tuesday, October 19, 2021 3:55 PM
> To: davem@davemloft.net
> Cc: kuba@kernel.org; Pkshih <pkshih@realtek.com>; kvalo@codeaurora.org; linux-wireless@vger.kernel.org;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Yang Li <yang.lee@linux.alibaba.com>
> Subject: [PATCH -next] rtw89: remove unneeded semicolon
>
> Eliminate the following coccicheck warning:
> ./drivers/net/wireless/realtek/rtw89/pci.c:1348:2-3: Unneeded semicolon
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Fixes: e3ec7017f6a2 ("rtw89: add Realtek 802.11ax driver")
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
> ---
> drivers/net/wireless/realtek/rtw89/pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtw89/pci.c b/drivers/net/wireless/realtek/rtw89/pci.c
> index e973101..2c94762 100644
> --- a/drivers/net/wireless/realtek/rtw89/pci.c
> +++ b/drivers/net/wireless/realtek/rtw89/pci.c
> @@ -1345,7 +1345,7 @@ static int rtw89_pci_check_mdio(struct rtw89_dev *rtwdev, u8 addr, u8 speed, u16
> default:
> rtw89_err(rtwdev, "[ERR]Error Speed %d!\n", speed);
> return -EINVAL;
> - };
> + }
> rtw89_write16(rtwdev, R_AX_MDIO_CFG, val);
> rtw89_write16_set(rtwdev, R_AX_MDIO_CFG, rw_bit);
>
> --
> 1.8.3.1
next prev parent reply other threads:[~2021-10-19 9:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 7:54 [PATCH -next] rtw89: remove unneeded semicolon Yang Li
2021-10-19 9:13 ` Pkshih [this message]
2021-10-20 8:51 ` Kalle Valo
-- strict thread matches above, loose matches on Subject: below --
2022-04-27 0:31 Yang Li
2022-04-27 1:29 ` Pkshih
2022-04-29 5:56 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68265a886f8f4ce1a4e9b64b4d80b5a8@realtek.com \
--to=pkshih@realtek.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox