From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1422946AbcBQMzt (ORCPT <rfc822;w@1wt.eu>);
	Wed, 17 Feb 2016 07:55:49 -0500
Received: from mout.kundenserver.de ([212.227.126.135]:63659 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1422680AbcBQMzs (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 17 Feb 2016 07:55:48 -0500
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Julia Lawall <julia.lawall@lip6.fr>,
        Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>,
        Scott Branden <scott.branden@broadcom.com>,
        Jon Mason <jonmason@broadcom.com>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        linux-kernel@vger.kernel.org,
        Jonathan Richardson <jonathar@broadcom.com>,
        Ray Jui <ray.jui@broadcom.com>, kbuild-all@01.org,
        linux-input@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH] input: fix odd_ptr_err.cocci warnings
Date: Wed, 17 Feb 2016 13:55:11 +0100
Message-ID: <6833564.Kp6CL1O0GI@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <alpine.DEB.2.10.1602170724320.2685@hadrien>
References: <alpine.DEB.2.10.1602170724320.2685@hadrien>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:kmWZb+OYy3o/P9aIRbbibO8JZNFq6lMoP305T+9Qkd3ApwGDp1O
 awgmxNNTHzMuUVpuyoIC3g3rn0ObP/AqCJx0HKAvz4xKVmWaCaIN4yGSA80ceTZyoVpNd6g
 i5k/1jc8/moNAzZCAk2F94MFr/4IYov9xOfy27cZr4nS8uPK0VnBlnepMKD0fpcPokMsgCJ
 bzg1vXter/17Vlpy+0Uhw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:94JCPLA85CM=:Y7G2D+wOodxc5Xa/eDCOoK
 rDpu1oIO4YVyntXSGkjs88gBT5CPQd2tB7s9puQ9WE8I1FslFp7gLiFRdlyfWJdyQ7+xGMvit
 Ji5p/aQ1xvifHX0Rf8hHm30cum4e9qRAgridWFD4AyUerSmZl4mJqy4TZM5+2edhWATaxNzqm
 Zt6c3OeZG7JlpHfK0krgXJaoCdfp+MX4BzOzcS0Rff+LmBwia0hbBC3NUuLRlPEKygm6EX0/R
 VSPUO/LVGnwVEiH56vOGx+AOJZrvGPFTdR31NNsAmv7I+RiTJrB2jxALmfIe/CdObMhLxq9k7
 sOgPJfJz8fKBDM5xd90YWQFcYHM/btZ/2KAkTGG0MHudAxfldKsANq304tZMbqeOfVtjI549Y
 t+WYKBEUHt65p4Bnslp+BGxQ/j/z/crFQ33cDlusBJohLWPQb3VPi7O1Gvldq3lEkEsOyMKPE
 cQZ42DxU+/9tUnpye4MLO5MKF2yiifqFULWQkPltM1wJUgMD7bzHtA5VYtI746ctGV6Ry+pjv
 KUKu1aNi70piieyW8QUgZAGeVNWJJy9u88DxkAL0avMZjjsUzpExbYJPe21+pXPUxdON+3Pqa
 3lxvewfgh7ojv7hCCHyrhdtaAnd+4YAckW+Mt7CS+JZUMLn/GDQy2svcY7gaOagYoPCloboWq
 vXCHtqUYYgHX/Gir4YpWtXbiDr1+VYGBoSa/vT628KfvzjFszjwOJtJvXLHPTPGgKylReappv
 QG4MO640SDfy1tqS
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wednesday 17 February 2016 07:29:05 Julia Lawall wrote:
> PTR_ERR should access the value just tested by IS_ERR
> 
> Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
> 
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
> 
> I haven't checked the context in detail. There can be false positives,
> when it is the call to IS_ERR that is wrong.
> 
> tree:   https://github.com/Broadcom/arm64-linux iproc-tsc-v2
> head:   ef32cf1baeb934bfcdf7c9eb8ad345aae266cde5
> commit: c3afc7a1c330ce452c52e2183a23b2ab9f70bd4a [2/3] input: syscon
> support in bcm_iproc_tsc driver
> 
> Please take the patch only if it's a positive warning. Thanks!
> 
> 

Looks correct to me

Reviewed-by: Arnd Bergmann <arnd@arndb.de>

>                 if (IS_ERR(priv->regmap)) {
> -                       error = PTR_ERR(priv->regs);
> +                       error = PTR_ERR(priv->regmap);

I think this could have been avoided using

		error = PTR_ERR_OR_ZERO(priv->regmap);
		if (error) {
			...

	Arnd