From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f70.google.com (mail-io1-f70.google.com [209.85.166.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67FB11CD2C for ; Wed, 28 May 2025 19:03:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.70 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748459008; cv=none; b=VshSzxKAjgh5Y/TiaXiAwWF2ZONdZ4Nphun45Oq/Hph4It+jAX44kRL80bmEl26lcGAB3c88SQnGm1M5/21RuF33xydchnT9jseZaLxSGlXUso1qa/ih7lwFREc9ilkkqSE7b/xVwEglpwmFLD+/bsP7NGlGbHqPqBWPl7RyCvA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748459008; c=relaxed/simple; bh=AR+K9UqMQRuFknqWRmpZq9fuV4o+r3pePP7+CiCdYuI=; h=MIME-Version:Date:In-Reply-To:Message-ID:Subject:From:To: Content-Type; b=BHmUQcmFw/1IjYcSDtkXneJxd4/AtaJd8Z5K5mwee2RkvEXEVem+n7R8mn9c2LiW5RBkArLN7ZADT3W+4DEzGmxe+qQ1dnra4NgBVaMUD7PPWi0A4V3LWbRf714umKmS7Wpb/78klQn3uy3xSoHJlFvMAMdm3dRjMc0QPXqx/Ms= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com; arc=none smtp.client-ip=209.85.166.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com Received: by mail-io1-f70.google.com with SMTP id ca18e2360f4ac-861d6e340e2so6357739f.2 for ; Wed, 28 May 2025 12:03:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748459005; x=1749063805; h=content-transfer-encoding:to:from:subject:message-id:in-reply-to :date:mime-version:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jY658xY7l15LXDKyjtYIUqu7SwqT1Ks7Ggx7kE8GHA0=; b=U00SrD0ehs7QZuMfpS+dr9NiJqljS66tX1joDNlKfoHerl7N9Sr9S8YHx2r3gD9gu5 xOUxvemZawJC7ycamhIU6DInd13A/difg+rAhbNdmvfjGZDfQVK1Am0MVC3Vm+bobFHB kOqdKM6qdHvKZKjex324+6IWANwMUigiUK0ly7jA+YdT6MjW+CGBxeB91SeJuRP6gF33 IukWoo9/Af4BYx9OgZ89Z4VB5Ac5tfj+p1G6xl5DS6xohaDMORgiWGZur/S+NMFofxT+ 3hy6gUM7hZqta9ON1RxPNQ+ZMgi7oI6VYmp+ZMIGFzuyNld7t8vGVmkuJ6GPvwx34DTj 3JHQ== X-Gm-Message-State: AOJu0Yw2NUU1cngHmIlcZefJdoldYLiEFyEpSnAixQ6H+T7JXVwKR5om tlVd8OPsjQVRADCkJjZmHHq/iEs/4UtT05WOmqCFsnue9HD6FTFRNwILQKNrJLze41R9FMJ2+sX iqZd02sBRiFrv61DOFwCrPxDSQv0qK51SGBtXo9OSL6pg/9ycdMVbCV/JmYo= X-Google-Smtp-Source: AGHT+IF2Schz5sKJ3lZmAPUwAMGTXA7Qd4QBDwIRPSsg4NJEvN8IXIKr5GC2XWM3NtrJIoNjCZkQqd/TcEyQJO4wjrNFdOSdj4Id Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Received: by 2002:a05:6602:371a:b0:864:a1fe:1e41 with SMTP id ca18e2360f4ac-86cbb8bb1a2mr1837851339f.13.1748459005478; Wed, 28 May 2025 12:03:25 -0700 (PDT) Date: Wed, 28 May 2025 12:03:25 -0700 In-Reply-To: <68241bb2.a70a0220.3e9d8.0005.GAE@google.com> X-Google-Appengine-App-Id: s~syzkaller X-Google-Appengine-App-Id-Alias: syzkaller Message-ID: <68375dfd.a70a0220.1765ec.0172.GAE@google.com> Subject: Re: [syzbot] Re: [PATCH v1] Bluetooth: MGMT: Use RCU-protected in mgmt_pending list From: syzbot To: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable For archival purposes, forwarding an incoming command email to linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com. *** Subject: Re: [PATCH v1] Bluetooth: MGMT: Use RCU-protected in mgmt_pending = list Author: luiz.dentz@gmail.com #syz test On Wed, May 28, 2025 at 2:44=E2=80=AFPM Luiz Augusto von Dentz wrote: > > From: Luiz Augusto von Dentz > > This uses RCU procedures to protect from concurrent access of > mgmt_pending list which can cause crashes like: > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > BUG: KASAN: slab-use-after-free in mgmt_remove_adv_monitor_complete+0xe5/= 0x540 net/bluetooth/mgmt.c:5405 > Read of size 8 at addr ffff888048891a18 by task kworker/u5:8/5333 > > CPU: 0 UID: 0 PID: 5333 Comm: kworker/u5:8 Not tainted 6.15.0-rc5-syzkall= er-00197-gea34704d6ad7 #0 PREEMPT(full) > Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.= 16.3-2~bpo12+1 04/01/2014 > Workqueue: hci0 hci_cmd_sync_work > Call Trace: > > dump_stack_lvl+0x189/0x250 lib/dump_stack.c:120 > print_address_description mm/kasan/report.c:408 [inline] > print_report+0xb4/0x290 mm/kasan/report.c:521 > kasan_report+0x118/0x150 mm/kasan/report.c:634 > mgmt_remove_adv_monitor_complete+0xe5/0x540 net/bluetooth/mgmt.c:5405 > hci_cmd_sync_work+0x25e/0x3a0 net/bluetooth/hci_sync.c:334 > process_one_work kernel/workqueue.c:3238 [inline] > process_scheduled_works+0xadb/0x17a0 kernel/workqueue.c:3319 > worker_thread+0x8a0/0xda0 kernel/workqueue.c:3400 > kthread+0x70e/0x8a0 kernel/kthread.c:464 > ret_from_fork+0x4b/0x80 arch/x86/kernel/process.c:153 > ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:245 > > > Allocated by task 5702: > kasan_save_stack mm/kasan/common.c:47 [inline] > kasan_save_track+0x3e/0x80 mm/kasan/common.c:68 > poison_kmalloc_redzone mm/kasan/common.c:377 [inline] > __kasan_kmalloc+0x93/0xb0 mm/kasan/common.c:394 > kasan_kmalloc include/linux/kasan.h:260 [inline] > __kmalloc_cache_noprof+0x230/0x3d0 mm/slub.c:4358 > kmalloc_noprof include/linux/slab.h:905 [inline] > kzalloc_noprof include/linux/slab.h:1039 [inline] > mgmt_pending_new+0x65/0x240 net/bluetooth/mgmt_util.c:252 > mgmt_pending_add+0x34/0x120 net/bluetooth/mgmt_util.c:279 > remove_adv_monitor+0x103/0x1b0 net/bluetooth/mgmt.c:5453 > hci_mgmt_cmd+0x9c6/0xef0 net/bluetooth/hci_sock.c:1712 > hci_sock_sendmsg+0x6ca/0xee0 net/bluetooth/hci_sock.c:1832 > sock_sendmsg_nosec net/socket.c:712 [inline] > __sock_sendmsg+0x219/0x270 net/socket.c:727 > sock_write_iter+0x258/0x330 net/socket.c:1131 > new_sync_write fs/read_write.c:591 [inline] > vfs_write+0x548/0xa90 fs/read_write.c:684 > ksys_write+0x145/0x250 fs/read_write.c:736 > do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] > do_syscall_64+0xf6/0x210 arch/x86/entry/syscall_64.c:94 > entry_SYSCALL_64_after_hwframe+0x77/0x7f > > Freed by task 5700: > kasan_save_stack mm/kasan/common.c:47 [inline] > kasan_save_track+0x3e/0x80 mm/kasan/common.c:68 > kasan_save_free_info+0x46/0x50 mm/kasan/generic.c:576 > poison_slab_object mm/kasan/common.c:247 [inline] > __kasan_slab_free+0x62/0x70 mm/kasan/common.c:264 > kasan_slab_free include/linux/kasan.h:233 [inline] > slab_free_hook mm/slub.c:2380 [inline] > slab_free mm/slub.c:4642 [inline] > kfree+0x193/0x440 mm/slub.c:4841 > mgmt_pending_foreach+0xc9/0x120 net/bluetooth/mgmt_util.c:242 > mgmt_index_removed+0x10d/0x2f0 net/bluetooth/mgmt.c:9362 > hci_sock_bind+0xbe9/0x1000 net/bluetooth/hci_sock.c:1307 > __sys_bind_socket net/socket.c:1810 [inline] > __sys_bind+0x2c3/0x3e0 net/socket.c:1841 > __do_sys_bind net/socket.c:1846 [inline] > __se_sys_bind net/socket.c:1844 [inline] > __x64_sys_bind+0x7a/0x90 net/socket.c:1844 > do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] > do_syscall_64+0xf6/0x210 arch/x86/entry/syscall_64.c:94 > entry_SYSCALL_64_after_hwframe+0x77/0x7f > > Fixes: a380b6cff1a2 ("Bluetooth: Add generic mgmt helper API") > Closes: https://syzkaller.appspot.com/bug?extid=3Dfeb0dc579bbe30a13190 > Signed-off-by: Dmitry Antipov > Signed-off-by: Luiz Augusto von Dentz > --- > net/bluetooth/mgmt_util.c | 25 +++++++++++++++---------- > 1 file changed, 15 insertions(+), 10 deletions(-) > > diff --git a/net/bluetooth/mgmt_util.c b/net/bluetooth/mgmt_util.c > index 3713ff490c65..c2dc8ddf5f78 100644 > --- a/net/bluetooth/mgmt_util.c > +++ b/net/bluetooth/mgmt_util.c > @@ -219,13 +219,20 @@ struct mgmt_pending_cmd *mgmt_pending_find(unsigned= short channel, u16 opcode, > { > struct mgmt_pending_cmd *cmd; > > - list_for_each_entry(cmd, &hdev->mgmt_pending, list) { > + rcu_read_lock(); > + > + list_for_each_entry_rcu(cmd, &hdev->mgmt_pending, list) { > if (hci_sock_get_channel(cmd->sk) !=3D channel) > continue; > - if (cmd->opcode =3D=3D opcode) > + > + if (cmd->opcode =3D=3D opcode) { > + rcu_read_unlock(); > return cmd; > + } > } > > + rcu_read_unlock(); > + > return NULL; > } > > @@ -233,14 +240,11 @@ void mgmt_pending_foreach(u16 opcode, struct hci_de= v *hdev, > void (*cb)(struct mgmt_pending_cmd *cmd, void *= data), > void *data) > { > - struct mgmt_pending_cmd *cmd, *tmp; > - > - list_for_each_entry_safe(cmd, tmp, &hdev->mgmt_pending, list) { > - if (opcode > 0 && cmd->opcode !=3D opcode) > - continue; > + struct mgmt_pending_cmd *cmd; > > + cmd =3D mgmt_pending_find(HCI_CHANNEL_CONTROL, opcode, hdev); > + if (cmd) > cb(cmd, data); > - } > } > > struct mgmt_pending_cmd *mgmt_pending_new(struct sock *sk, u16 opcode, > @@ -280,7 +284,7 @@ struct mgmt_pending_cmd *mgmt_pending_add(struct sock= *sk, u16 opcode, > if (!cmd) > return NULL; > > - list_add_tail(&cmd->list, &hdev->mgmt_pending); > + list_add_tail_rcu(&cmd->list, &hdev->mgmt_pending); > > return cmd; > } > @@ -294,7 +298,8 @@ void mgmt_pending_free(struct mgmt_pending_cmd *cmd) > > void mgmt_pending_remove(struct mgmt_pending_cmd *cmd) > { > - list_del(&cmd->list); > + list_del_rcu(&cmd->list); > + synchronize_rcu(); > mgmt_pending_free(cmd); > } > > -- > 2.49.0 > -- Luiz Augusto von Dentz