From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91004770E2; Thu, 5 Jun 2025 02:04:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=198.175.65.15 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749089089; cv=fail; b=A8nmL0tjJI2JKcPCaMnxg/rsL4AJD7A7yD7fNAzlhHfeXzrpSqS3tybehUVqFLsrkFwXyhN+z+WYhth4PCTdpfa41ytrYz/ofwCVdjxY/XiGnEbsWWcgXgyMhuFsE052jNttuC/CmJ31jdhoura/OcLdpSFobC1Mgab65f5FaE0= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749089089; c=relaxed/simple; bh=7y3dxA8J3xesYiYhw//lZdAvyFAU/muCn8/qB8yzXpA=; h=Date:From:To:CC:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=Iu2YLPFZc7HA+eWKzQsAdTez5KPfj9zfCdo701Udu5eHaYoXN1C/tPWuja97XWVnnXvF08PNfggK4VJUd9sYV7UNtltqVsPtYuXUqitWT2zpPJe0kVYkGPtQwNncFNPiulNB3O+URNTDAyQ/oQ/FZJTacdKWOPKW0IswPKN/kJE= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Y0ieT3vv; arc=fail smtp.client-ip=198.175.65.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Y0ieT3vv" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1749089088; x=1780625088; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=7y3dxA8J3xesYiYhw//lZdAvyFAU/muCn8/qB8yzXpA=; b=Y0ieT3vvYSmLrYLskPp7k0XCY7fiOmXiwRvjQyL4XraZCPECJ6zl7hcz IHZ+Smm9QAxxQ1AA+CPuE1qzWt/cf0TTxUnEXCtHcXls9D3iEwThGQtL6 dSy+d1WvpBQQ4KawOiLUVav8cfUMDCmAjghCAiym5vtiK3BUF/hzQ6niU vqbaoBMPhqoh5nVSEIMwac7Dby5KzQb2vZdvv0g4UbREThf1sNImN9tbx ctx/3JGSc3F0fxI71zMEOmR4DRAaxlJiUrHiUaNxNFqtlitCb/qJIiTSx he3KFi3fMXQiD+grGfXUQIBMLdguklDwRMjoNCwZJZc6dUEEM7XljhryJ w==; X-CSE-ConnectionGUID: tpHpV9mXRbqMLlRa/rTySA== X-CSE-MsgGUID: xGtLwgwHSP2WNv38B7KwOA== X-IronPort-AV: E=McAfee;i="6800,10657,11454"; a="54852707" X-IronPort-AV: E=Sophos;i="6.16,210,1744095600"; d="scan'208";a="54852707" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jun 2025 19:04:40 -0700 X-CSE-ConnectionGUID: cqgM76XcTR+siKFdBxDcaA== X-CSE-MsgGUID: 118nHMKfT8yD5kWsHhLIOg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,210,1744095600"; d="scan'208";a="146298980" Received: from orsmsx902.amr.corp.intel.com ([10.22.229.24]) by fmviesa009.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jun 2025 19:02:30 -0700 Received: from ORSMSX902.amr.corp.intel.com (10.22.229.24) by ORSMSX902.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.25; Wed, 4 Jun 2025 19:02:29 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by ORSMSX902.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.25 via Frontend Transport; Wed, 4 Jun 2025 19:02:29 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (40.107.94.70) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.55; Wed, 4 Jun 2025 19:02:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xBoRBazUpotngTB2DswS561QonY+Y/ZzoXTWaSwRMju3lj9itEyUQFGs3idwYfgENJ45sgYIjqB3TN0mssAGOwZi0tNP3NWQw0HoHsipLFMkRkCE7HP4v0DLUV+xmwledZzHhc3awfp1XqvpWRHu2xat2dRxSlKocWddXAzckyuBsQ2Bz+i79w+7G+WECwlmy183Y9HgU9A1bhtvWeCKQLz3gL218qLVMTCBGbfN+20Z7JbTQf2ARET02uKcDeQnmW7Ao6aFHJ3+X5pDC2qJleV+Jih/D0IZDN2iZG2RN0BJG3dYBeuKTzoioJU5c4pPV1AMiGMWEQSyL3yY1ww7/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YVIsnd8y9mTEQzykMTYlKep/DTad4B7wKRqRECe6s/A=; b=uDVLDI0eph82QVjhpsGhKZRcTMgtd5NehnybOETG5lzkO8JF1zxJYl6NIa9PBCPPl1UbR3zVmYpHTJqPnqItF/OxQ4X0z6GBuqVfp05tFkYd6weIp0eIf8JpmDF9iVfU3RfFvdTEEVPxWlcbQeuSGoWVcFivBfD6fzpXTH9AVy7Y4nh4sx+bVtiHrrB7JC89PD3YRXmFXJWWyzMc9iWQf0L64SbD7bJHLgPkfy7Kx/lnjxXYqzqmLJW9CUbBVIUgPBd7LjyZhwnYLCWVOx5FONjTIbBol5UAj9CqE5QKWQRvyyejlKjswSWbpI8iMNyB9ko/9VqbvIq8lzo5yBgAxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH8PR11MB8107.namprd11.prod.outlook.com (2603:10b6:510:256::6) by MW3PR11MB4604.namprd11.prod.outlook.com (2603:10b6:303:2f::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8813.21; Thu, 5 Jun 2025 02:02:27 +0000 Received: from PH8PR11MB8107.namprd11.prod.outlook.com ([fe80::6b05:74cf:a304:ecd8]) by PH8PR11MB8107.namprd11.prod.outlook.com ([fe80::6b05:74cf:a304:ecd8%5]) with mapi id 15.20.8769.031; Thu, 5 Jun 2025 02:02:27 +0000 Date: Wed, 4 Jun 2025 19:02:24 -0700 From: Dan Williams To: Alistair Popple , CC: Alistair Popple , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH 04/12] mm: Convert vmf_insert_mixed() from using pte_devmap to pte_special Message-ID: <6840faaff197a_24911007d@dwillia2-xfh.jf.intel.com.notmuch> References: <171c8ae407198160c434797a96fe56d837cdc1cd.1748500293.git-series.apopple@nvidia.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <171c8ae407198160c434797a96fe56d837cdc1cd.1748500293.git-series.apopple@nvidia.com> X-ClientProxiedBy: SJ0PR13CA0105.namprd13.prod.outlook.com (2603:10b6:a03:2c5::20) To PH8PR11MB8107.namprd11.prod.outlook.com (2603:10b6:510:256::6) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH8PR11MB8107:EE_|MW3PR11MB4604:EE_ X-MS-Office365-Filtering-Correlation-Id: b587d396-9805-4370-50c7-08dda3d50538 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|7416014|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?sFEza5/+kxd1MXVAvAspWt7+XTp4+brAKFLZjNsCkFuK5npSif9r9Pnenkr9?= =?us-ascii?Q?XJ9l7f8QN3ZeHwfdCGgPN+93CDDsySY8faQwM2Oil15YlFtRR7yujbrplLCV?= =?us-ascii?Q?jmzvZ5q2fo74DW/t/1fpyjSxYbJEJ3tp/s6b12Kv2zOm/994Pay5NfBcY6YH?= =?us-ascii?Q?LkOm/3cxWGuAQlhzvqEUjmVAItkuk2aiiSWG+pVTgJdBvunY9Lp47idoLRRA?= =?us-ascii?Q?RH5TTvSk+F0vSEXcQBB7cZgHJWhE+LTkzRvBJ10x+tTssEr3doZ6K6O298ws?= =?us-ascii?Q?vI9BuRdedyfuTtJ1aL5Jfrr5ROKoP5fXRDfkkk/VvIb0eSvl1y3wFwRZpeum?= =?us-ascii?Q?vtuYbL5kyWCJb04iA8wb6M78QVS2sbQCofzR4ClFoMscVvavzFdol77zVVAc?= =?us-ascii?Q?ZcVS4EmLcCWFnyc5LqSF5Bbvl7cgRbLAPodIAS8SYY00CX1A1OiEHOeOwmYf?= =?us-ascii?Q?04whc5WEmNRTMpPKj6oFLgQIJvCUJGjxHf0zwOf3ba5E3jchAzKaGlPvZ0aV?= =?us-ascii?Q?bwLa4CthRY2jY5lhn+r9Rn2Zl28m5a9bDhXd0aSzvy9gd6oG/f0vM7tcYOaf?= =?us-ascii?Q?nvs7nSMjqH+m+jUDstGKMy2LbTI7r/kp0/a54qRPHkJABaQpayoVvYvarBxi?= =?us-ascii?Q?XzTir3Jk5J0ZLoHrzID8M2AxEw3bsj4cIoI18u0vmxr2Y90e5kUSnWdJtA3y?= =?us-ascii?Q?kQO4mKmrtwBtHtfB/IsbXQc6x8ZOANmNAtTCThi87lJ6xe74vVJzHJ1RzY7H?= =?us-ascii?Q?+MJHFES03HsOvmjvcy8rILEGHyNvD3R9yhaAf75sxDYbgYCxhRqSYOFfBbco?= =?us-ascii?Q?eqH9tdth/0EtiGv6yG+1SBazKeQ7MjSwfhJj6VUTNloFnGkV77rYDXWqceKk?= =?us-ascii?Q?JSHGK//W0YWEJms3imKyiXChkMUyUvGHG1l2a+ioFZXGdm/kbwClcMQ/yKCY?= =?us-ascii?Q?5QQv5VyIHhvrZ2ebwYUwK0X2Ee3WAPQcDH8Pcbn0FfNU9O91D94gK9/N8+C3?= =?us-ascii?Q?p9NB0fsIgqn7v2PNqz4Qs8mofXJ7bf+/tHuyB+KOTUX3lU+qH1m/u87q/RYl?= =?us-ascii?Q?jy1cvyUj8xJSembxXx+rtuBftYpjbyvyhCy94pTBo237ov2EPJnSFUtsaXgU?= =?us-ascii?Q?Us1OzMuoC5P9g/wcns2q7+pMEwXJfN9sNDQV8oAKAkt3JGL5VPEYrDlKJgRS?= =?us-ascii?Q?O0WeqTDJBdZQP/sVJLAxq9cVrH0vUgnt9jtPFH28BaGqCp7vyEoUEEP1LhL7?= =?us-ascii?Q?ZL6/KImXP+Amjz8oDZvgHL9n64sCFGxNAsVrTP7v+K4Pb0u8aYE/3wheR/8K?= =?us-ascii?Q?LGdd7bF/eI0Nglmy0cQ+rjOb3wUU5fZEvFGY+FP9qjln997SvILcPsdqQEGx?= =?us-ascii?Q?FWQ3mmf1ACF3dV6iw7OV1kf3Mcs4uY6hUFxZugbghZxmOip09zOnLOEjCiJM?= =?us-ascii?Q?GCSxjsg/CXQ=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH8PR11MB8107.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(7416014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fEKK2h45XYObxBcT4vooGVeXjA01uYGS4DviP04N3sbB+2evApabG2Fasd48?= =?us-ascii?Q?IDc7jeUzOWl0+waLtcu6YMUcrHYhInL/k95Yb6e/agQ2kbZe9Kr2YTQ3OvJ6?= =?us-ascii?Q?OFSOi5spKGEm354Mih8o/eO00GYuBZQ+SzuhSGEPD0lt2KobKSH/iuAEpdB4?= =?us-ascii?Q?2xPhduhVYTy8wbTYtE1fmMUjskLiwK4VteDOfjR6ePBb7RzK/tBTyW5E+p14?= =?us-ascii?Q?15hFg/BPHza2GiHBuhEgXLMTwvatw4GU93rrrFVKHhAlx99606DCGgtMJeF8?= =?us-ascii?Q?zteXiKX1SMivoMRbloO/aCXzgeIuFoKITR9kmgYxZwk19hsGhPhIiYKbqGY+?= =?us-ascii?Q?ubHeIEwXza7PWnpJhycWMECSI7veFMu9dDPbPnrup2kIsIGFFDcFF2sSwP7c?= =?us-ascii?Q?8C9VbDkIO6hGrwH8TVcUFSQmmkoEL9d8QzbsGNCoce6WGqInexKq8qJpXD2P?= =?us-ascii?Q?DzA3LFU82tHrGaRS9TtSXmyMp/YQ/bvZxvMXORlV1dv9wmMLUQZCMDW/P2DN?= =?us-ascii?Q?ZgN2mz0AlN9zgpEcanRurEaydWvvPZnv0H+0CeDj08ZpHJuyAq3gQTVJfhx8?= =?us-ascii?Q?g6to2dNm4l33WW02w1eota3aEoveJKRHNGm4f4VP6IxyHpOv3t7T/jroZWWb?= =?us-ascii?Q?JBnIlzVDt3b1u7DcxByA1CzgdBaS6zRdZ9kqeWGqZJRW5zNdYxA1PsowKbAe?= =?us-ascii?Q?SoYL9TsA0pBHU4VvUU9sFaszaUJMMHKQbbr3RVaPb/I9NZNc2W5HUe4IuRMz?= =?us-ascii?Q?Dj+h+4QHPG/KMHsgl1cVEalIweDjFRhiBD5gN6FoEDB82clc7akItPKHLXIS?= =?us-ascii?Q?aMejloRRWGFR4kbR/CjpHBIW5d+eMtAeaopVBXpGuAeHBwrHK0Qw0AbiV+16?= =?us-ascii?Q?9mcjhWQHA7DlO+aHFhQOEVV5vJl6k1JFYFyx1+oKcWTBUlwF9BnR7esYvLJz?= =?us-ascii?Q?SXXkNFBXIvcWL2P1FAoxF2hcPuzcXMeZnakThAEuS3ehNTN4K+nRVUld/XrN?= =?us-ascii?Q?7wr73DtUVkW9PxaWxykFYD3rZyC2Tfqbub9IRSq26dIfenA3s0wipNaR6UwD?= =?us-ascii?Q?Xi7a/lSi/PjA56hKcXUWPZS4U8qNx46krnWqGcU8e86K8FAlQL8N8SuNkFyc?= =?us-ascii?Q?qc/nudN2c9ShqaaM0ZS+rNI1hcjg07tE0kWAnCy0cHRHLlmN/+Log3k4PD4U?= =?us-ascii?Q?nAe6fvWQwApyTLDL3caAS1la9qKWwuNFeXju6eFzVJPuUL2sQ9eqj+pOPm2P?= =?us-ascii?Q?D1xQIuvfjr5Ntob3ObNguBtREn2EKoK/9eBF9OC951FuZtehQZOM0ttsNgpU?= =?us-ascii?Q?l49j2IiRQP3ZKghp7AFWpdygFn+JGh7ZUpA4s+UtrXchbkPjQgvd5kFK+wtT?= =?us-ascii?Q?pBj2tVJrwDX/B2EBrU3PlHiie7seeCmuHrhpcM8HCbpezTThA79Pp3KQZwec?= =?us-ascii?Q?KQEe6Vl5XtoKyW45esS9MnLlg45eHnHrKkwQUxLFYnApnWVqjdOPVc1bzDgt?= =?us-ascii?Q?VyvMAeTyu7X7v2T17sWVmKuMKtBPoIye7nJ913sSdVAUfeVCsz/FX8lfWtIz?= =?us-ascii?Q?R/0T40Vcy+TIznRpe+CfpOcaBKkWSiuB+Pmxmf2NkflYj3BOC6p3t7t8LFva?= =?us-ascii?Q?Rw=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: b587d396-9805-4370-50c7-08dda3d50538 X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2025 02:02:26.9341 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eEqwRu1gHkZgYqLlhhcNaDumsojCbtGS0veyG/qTZxy/UN0QQyRcQV/u2axeNyBcuxfj9kgPHuzgTokXyh0orad2gHrgXl+Kccs/29cQ7KA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4604 X-OriginatorOrg: intel.com Alistair Popple wrote: > DAX no longer requires device PTEs as it always has a ZONE_DEVICE page > associated with the PTE that can be reference counted normally. Other users > of pte_devmap are drivers that set PFN_DEV when calling vmf_insert_mixed() > which ensures vm_normal_page() returns NULL for these entries. > > There is no reason to distinguish these pte_devmap users so in order to > free up a PTE bit use pte_special instead for entries created with > vmf_insert_mixed(). This will ensure vm_normal_page() will continue to > return NULL for these pages. > > Architectures that don't support pte_special also don't support pte_devmap > so those will continue to rely on pfn_valid() to determine if the page can > be mapped. Looks good, Reviewed-by: Dan Williams