From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 308D43B5825 for ; Fri, 17 Apr 2026 10:37:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776422226; cv=none; b=nvVaGmZdhGrKT3WdIQvwBPPR5OgAFoPj4g4/mNtSEI70idrKPdmSwcszPirSQLe8j3VpOrtXm90ML1kkkeBebXj2jhjsl19Db9RK2CKXTv5v8eqBJ61eUv9/dsyFFCwkDWdx6IHG+ecU+B2bSMgCXSxxKD/mO8YxQPLXDvQdE2M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776422226; c=relaxed/simple; bh=MfLCrftTkRiHF1WkV8QPjh+C8/Zqj/z+uyT5VJqEhu8=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=iNSCW8p8vTp8gPkMFx0FUfVq1x2Skln61kmtRT2BscANk1lM1CsGZY3O1n2GX4fgM+XAJ5svjfp9AvSHzCvblRGa4Yp27GiVls8aNR6ZbQ4dP8pXYrco1Rp+YrkrynWQI88S8lHBvh4lOmZOawsPtzJ29v6ht5n8TcVtyvb017k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=QvAKv7a7; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=chKErwtA; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="QvAKv7a7"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="chKErwtA" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63H8nrln3100240 for ; Fri, 17 Apr 2026 10:37:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= qi2dAks95bANiDqtVitR6nG9NYJ56qmT+COQZFKso8M=; b=QvAKv7a79toT5ynE TWhwzXKw6d2nB4urhxJ3ztbrGiJzJZLaSm6i2Snw30k0eHI4dpXuEUPdo1h+/l38 RFbcJhyArd9Ed4Tb76mQTz7DAr0fp5k0POSrkI1eawj98O0cGsULbaDZRx1Ebtq0 ImEH7naUGF/Ul0nPm3CtkQPWCu9mdNFM5/D3swyHDt+K3yANhrCkXzledpFFsiH/ w0KLTBKW01X78ptzEjsb/NgkMG+WuynxgxRjbR4wjviiT2+mxv5IzEqNcUpK29yn yp1ibZ9lN1serNZts9pDJZ/EkLQITTb8xYBE40xWC+lVQbh1LRez69T/s0xiCC2L VEnSFQ== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dkhpu0ed7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 17 Apr 2026 10:37:04 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-50b4ca7e7c2so9999811cf.3 for ; Fri, 17 Apr 2026 03:37:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776422223; x=1777027023; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=qi2dAks95bANiDqtVitR6nG9NYJ56qmT+COQZFKso8M=; b=chKErwtAsnNdgmGzsks7z8dy2pbCRgzSCL9YBWLf/l7ChHmlizL5yW5Xjpj8aYNf/o /vs0i54kCsp6V2b2i0DTUUMnPs+93FQWUmtTcRzaczcmJ7Br5Ttb55jOSa1iAMkupElg QodlZN+tZp6aR0wvVBbRlQAH7yA9Ny4/5Dyypn3Ihn6GBPwflIy90SPCSqhaFD4X8GNg 7LO+dLorBeMTg3JXMSr2jtOG7QmUQwcT7N6WwGU15X/C/JtDaS3jgLRrkgRb3zCZ8cWb dcTzxSYWoTsSCIfb3s7qET8fPWwuUUYZ4ZcQwu5VEFGmpvlNbNqED7JmIDZhFHstMkXd BL9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776422223; x=1777027023; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qi2dAks95bANiDqtVitR6nG9NYJ56qmT+COQZFKso8M=; b=J7NkIJacp1V/J+gA7NeYqfqK4DbKsIQd93UWGnjFdErBRz4FTjW+5HfPtvqf4XOkk+ aHko+WcPvq9ToP/PcUzLWYSEv21NSDZ5OmjapqUDI9N0K1JCOKRZ4WhQWzbv7uUx8g42 CpdcUZtV+Vc7eMoatsP27LoFM4tJ3VhLOu1XpTBU9f4aiT2Uph2ClyP3TjB+ejzJZk3P d2BL52BVYupwS6MicGifyafJtcS3SN7Q7hDcWuSdsIdYyAxXlMGrXILgts/JUJwZhiTA 7WM3KlZXYgZqq0v7UNS1lLQdNJAajqXskn+Q9MA2mxH4m+MgPKusb8Uw1uiiscophluH q/0w== X-Forwarded-Encrypted: i=1; AFNElJ9ysPu82B4co8Ab0HtFuIYROXcxDQW52QldTcUMGLblH+y7YNzcbdHp48MIZ8Zd+3KRCd26OZSUedpDwfw=@vger.kernel.org X-Gm-Message-State: AOJu0Yy+3xvTCS6xXn2nONQhCzBs7hmJGUmoZ712uPhBRzhooVHsHJPo 79ynLTKblZzjajORQz2GdReyP7OMMX6eg4spNyZ4HY0NoIszRGZ0o/y8qtqVBauzwKDncreyg3X X61D1PdqjiBBnZKNBLeHne+cE1E1ucOA2lNeHlcDXUHOkSew/UCYhi28uSwE9iRK3C9Y/2WooRi 4= X-Gm-Gg: AeBDietUjZV2BjuYZVQCx/AGS8RvNoJ16DrNNPVUS1vwzjAcKgWuVx+IgGnJ0vUOr+O nn3+RTqi6qR8hABLKVn9aUl5/ojO5gwcY000p2Habaakgry8VRMVMsmrqpktZxGLTBII5MVtZxC StWqzr4pTlyIh/htOLFc0dLaFGxxhVGcIimaLt2K7DEg3Tw+wm/2OwvUJpC2JuiVBP31qtHCc0J mL3sHGnaJ0lXu0qPEzbD+MFDALBKoBS/ZVlDte7TzD+jUU0UidUUqbPyaqdqZqjbYPUyMTP6sPz uO6mP+v8wjgtq63FyGeowTVI6RdW91unuKTwG5sMtENoDIzNbxa8Tw+wJtSe9P++smwpr57liVg PSUtEG7DBXfKSaPVn9lyFspTiuxXQVUZSA631NPn9q5cXlE4Y/+tvnCxISb6sf2syPiDdt2nvHY 7PKcn3+PsLqrnzrkWc5s8HYoGXRpsjtiIcejzxz1UeiAO5HPganKvgFiWNYq/RFiYIaK5VnSpfe RWFDXY8jHSHtNEnZGuc/PbEMjw= X-Received: by 2002:a05:622a:1650:b0:50b:86f5:8fbc with SMTP id d75a77b69052e-50e36efaeb4mr28189031cf.51.1776422223338; Fri, 17 Apr 2026 03:37:03 -0700 (PDT) X-Received: by 2002:a05:622a:1650:b0:50b:86f5:8fbc with SMTP id d75a77b69052e-50e36efaeb4mr28188681cf.51.1776422222986; Fri, 17 Apr 2026 03:37:02 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ba451be2c9bsm42130566b.23.2026.04.17.03.37.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Apr 2026 03:37:02 -0700 (PDT) Message-ID: <684435ca-dc58-4b46-ac25-467dcf12d976@oss.qualcomm.com> Date: Fri, 17 Apr 2026 12:37:01 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Hans de Goede Subject: Re: [PATCH 1/2] media: ipu-bridge: Add DMI information of Lenovo X9 to the image upside-down list To: Kate Hsuan , Mauro Carvalho Chehab , Hans Verkuil , Sakari Ailus , Serin Yeh Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260417083214.222189-1-hpa@redhat.com> <20260417083214.222189-2-hpa@redhat.com> Content-Language: en-US, nl In-Reply-To: <20260417083214.222189-2-hpa@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=Kd7idwYD c=1 sm=1 tr=0 ts=69e20d50 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=20KFwNOVAAAA:8 a=Aiq9Hgk9keMhYKovH3wA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-GUID: E-NjbVl7QqXLqnRQkBhudNiqyhbDWXDV X-Proofpoint-ORIG-GUID: E-NjbVl7QqXLqnRQkBhudNiqyhbDWXDV X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDE3MDEwNiBTYWx0ZWRfX2DTegQggK5S6 VS8jUQHmJISYN9Mzuk9OVWiJVyY1o6d77ZC4JBP0Kb+N+R1xZW5fMiR59XyHqkWS3vM1MFW2/m+ tYfceIKCYdXj6aFWeXZD7QJScXI3jZ4Nwv0hauPPOPULoqdbe2b9BCvV8Z5MsHloo919bA+qPDF T9VvZQwFLJTv2mH1MVcANuyRwbbOO6o/WDhltZJlDPDrZo7gs3XJ8EEQqenmGvWuopTibH/30Em 3YToNp+gFxJxqpo72nIBYGg12tup8WXwMZXtafhgJQZ6Lh0FIouuOn0rq9hvRqL7YWlVDjr3MoV BRtPwN/HLBifM+9aQkM7LM5M1z3f3bwGT6RITfhv3XstJzNRrkzbM3EZUJGKKDJzpwhGJlOHxm+ tD/rRITptDPSBNlaen3fQI8SCcHuEJGWlx3jMmtibsJvFSMQUWDBZ1GrwPjBQISPIqrrARODbN7 dkv6FCaMaYTH2VcEcIQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-16_04,2026-04-16_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 spamscore=0 phishscore=0 suspectscore=0 malwarescore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604170106 Hi Kate, On 17-Apr-26 10:32, Kate Hsuan wrote: > The Lenovo X9 has an upside-down-mounted Sony IMX471 sensor so the image > was displayed upside-down. Add the DMI information of Lenovo X9 to > resolve the issue. > > Signed-off-by: Kate Hsuan > --- > drivers/media/pci/intel/ipu-bridge.c | 32 ++++++++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > > diff --git a/drivers/media/pci/intel/ipu-bridge.c b/drivers/media/pci/intel/ipu-bridge.c > index 32cc95a766b7..7b5b0dfc0190 100644 > --- a/drivers/media/pci/intel/ipu-bridge.c > +++ b/drivers/media/pci/intel/ipu-bridge.c > @@ -118,6 +118,38 @@ static const struct dmi_system_id upside_down_sensor_dmi_ids[] = { > }, > .driver_data = "OVTI02C1", > }, > + { > + /* Lenovo X9-14 */ > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > + DMI_MATCH(DMI_BOARD_NAME, "21QA"), > + }, > + .driver_data = "SONY471A", > + }, > + { > + /* Lenovo X9-14 */ > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > + DMI_MATCH(DMI_BOARD_NAME, "21QB"), > + }, > + .driver_data = "SONY471A", > + }, Can you try to instead match on the DMI_PRODUCT_VERSION ? that should contain "X9-14" or something like that, allowing you to use 1 entry instead of 2 . > + { > + /* Lenovo X9-15 */ > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > + DMI_MATCH(DMI_BOARD_NAME, "21Q6"), > + }, > + .driver_data = "SONY471A", > + }, > + { > + /* Lenovo X9-15 */ > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > + DMI_MATCH(DMI_BOARD_NAME, "21Q7"), > + }, > + .driver_data = "SONY471A", > + }, Same here. > {} /* Terminating entry */ > }; > Regards, Hams