* [PATCH v1] spmi: Set fwnode for spmi devices
@ 2024-11-15 23:05 Saravana Kannan
2024-11-28 4:23 ` Saravana Kannan
2024-12-03 21:57 ` Stephen Boyd
0 siblings, 2 replies; 5+ messages in thread
From: Saravana Kannan @ 2024-11-15 23:05 UTC (permalink / raw)
To: Stephen Boyd; +Cc: Saravana Kannan, kernel-team, linux-kernel
This allows fw_devlink to do proper dependency tracking for SPMI
devices. So, better deferred probe handling, async probing, async
suspend/resume, etc.
Signed-off-by: Saravana Kannan <saravanak@google.com>
---
drivers/spmi/spmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spmi/spmi.c b/drivers/spmi/spmi.c
index fb0101da1485..3cf8d9bd4566 100644
--- a/drivers/spmi/spmi.c
+++ b/drivers/spmi/spmi.c
@@ -517,7 +517,7 @@ static void of_spmi_register_devices(struct spmi_controller *ctrl)
if (!sdev)
continue;
- sdev->dev.of_node = node;
+ device_set_node(&sdev->dev, of_fwnode_handle(node));
sdev->usid = (u8)reg[0];
err = spmi_device_add(sdev);
--
2.47.0.338.g60cca15819-goog
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v1] spmi: Set fwnode for spmi devices
2024-11-15 23:05 [PATCH v1] spmi: Set fwnode for spmi devices Saravana Kannan
@ 2024-11-28 4:23 ` Saravana Kannan
2024-12-02 23:27 ` Stephen Boyd
2024-12-03 21:57 ` Stephen Boyd
1 sibling, 1 reply; 5+ messages in thread
From: Saravana Kannan @ 2024-11-28 4:23 UTC (permalink / raw)
To: Stephen Boyd; +Cc: kernel-team, linux-kernel
On Fri, Nov 15, 2024 at 3:05 PM Saravana Kannan <saravanak@google.com> wrote:
>
> This allows fw_devlink to do proper dependency tracking for SPMI
> devices. So, better deferred probe handling, async probing, async
> suspend/resume, etc.
>
> Signed-off-by: Saravana Kannan <saravanak@google.com>
Stephen,
Gentle nudge. Plan to take this in for 6.13?
-Saravana
> ---
> drivers/spmi/spmi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spmi/spmi.c b/drivers/spmi/spmi.c
> index fb0101da1485..3cf8d9bd4566 100644
> --- a/drivers/spmi/spmi.c
> +++ b/drivers/spmi/spmi.c
> @@ -517,7 +517,7 @@ static void of_spmi_register_devices(struct spmi_controller *ctrl)
> if (!sdev)
> continue;
>
> - sdev->dev.of_node = node;
> + device_set_node(&sdev->dev, of_fwnode_handle(node));
> sdev->usid = (u8)reg[0];
>
> err = spmi_device_add(sdev);
> --
> 2.47.0.338.g60cca15819-goog
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] spmi: Set fwnode for spmi devices
2024-11-28 4:23 ` Saravana Kannan
@ 2024-12-02 23:27 ` Stephen Boyd
2024-12-02 23:29 ` Saravana Kannan
0 siblings, 1 reply; 5+ messages in thread
From: Stephen Boyd @ 2024-12-02 23:27 UTC (permalink / raw)
To: Saravana Kannan; +Cc: kernel-team, linux-kernel
Quoting Saravana Kannan (2024-11-27 20:23:01)
> On Fri, Nov 15, 2024 at 3:05 PM Saravana Kannan <saravanak@google.com> wrote:
> >
> > This allows fw_devlink to do proper dependency tracking for SPMI
> > devices. So, better deferred probe handling, async probing, async
> > suspend/resume, etc.
> >
> > Signed-off-by: Saravana Kannan <saravanak@google.com>
>
> Stephen,
>
> Gentle nudge. Plan to take this in for 6.13?
>
It doesn't look like a fix and it was sent too late for 6.13 so I was
going to send it over for the next cycle.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] spmi: Set fwnode for spmi devices
2024-12-02 23:27 ` Stephen Boyd
@ 2024-12-02 23:29 ` Saravana Kannan
0 siblings, 0 replies; 5+ messages in thread
From: Saravana Kannan @ 2024-12-02 23:29 UTC (permalink / raw)
To: Stephen Boyd; +Cc: kernel-team, linux-kernel
On Mon, Dec 2, 2024 at 3:27 PM Stephen Boyd <sboyd@kernel.org> wrote:
>
> Quoting Saravana Kannan (2024-11-27 20:23:01)
> > On Fri, Nov 15, 2024 at 3:05 PM Saravana Kannan <saravanak@google.com> wrote:
> > >
> > > This allows fw_devlink to do proper dependency tracking for SPMI
> > > devices. So, better deferred probe handling, async probing, async
> > > suspend/resume, etc.
> > >
> > > Signed-off-by: Saravana Kannan <saravanak@google.com>
> >
> > Stephen,
> >
> > Gentle nudge. Plan to take this in for 6.13?
> >
>
> It doesn't look like a fix and it was sent too late for 6.13 so I was
> going to send it over for the next cycle.
Sounds good. Can you let me know once you pick it up in one of your
git branches?
Thanks,
Saravana
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] spmi: Set fwnode for spmi devices
2024-11-15 23:05 [PATCH v1] spmi: Set fwnode for spmi devices Saravana Kannan
2024-11-28 4:23 ` Saravana Kannan
@ 2024-12-03 21:57 ` Stephen Boyd
1 sibling, 0 replies; 5+ messages in thread
From: Stephen Boyd @ 2024-12-03 21:57 UTC (permalink / raw)
To: Saravana Kannan; +Cc: Saravana Kannan, kernel-team, linux-kernel
Quoting Saravana Kannan (2024-11-15 15:05:07)
> This allows fw_devlink to do proper dependency tracking for SPMI
> devices. So, better deferred probe handling, async probing, async
> suspend/resume, etc.
>
> Signed-off-by: Saravana Kannan <saravanak@google.com>
> ---
Applied to spmi-next
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-12-03 21:57 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-15 23:05 [PATCH v1] spmi: Set fwnode for spmi devices Saravana Kannan
2024-11-28 4:23 ` Saravana Kannan
2024-12-02 23:27 ` Stephen Boyd
2024-12-02 23:29 ` Saravana Kannan
2024-12-03 21:57 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox