[PATCH] MAINTAINERS: add missing mm_slot.h file THP section

[PATCH] MAINTAINERS: add missing mm_slot.h file THP section

[Lorenzo Stoakes]

This seems to be the most appropriate place for this file.

Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 837bc5cd6166..3f83fb317f51 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -15966,6 +15966,7 @@ F:	include/linux/khugepaged.h
 F:	include/trace/events/huge_memory.h
 F:	mm/huge_memory.c
 F:	mm/khugepaged.c
+F:	mm/mm_slot.h
 F:	tools/testing/selftests/mm/khugepaged.c
 F:	tools/testing/selftests/mm/split_huge_page_test.c
 F:	tools/testing/selftests/mm/transhuge-stress.c
-- 
2.50.1

Re: [PATCH] MAINTAINERS: add missing mm_slot.h file THP section

[Zi Yan]

On 22 Jul 2025, at 13:19, Lorenzo Stoakes wrote:

> This seems to be the most appropriate place for this file.
>
> Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 837bc5cd6166..3f83fb317f51 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -15966,6 +15966,7 @@ F:	include/linux/khugepaged.h
>  F:	include/trace/events/huge_memory.h
>  F:	mm/huge_memory.c
>  F:	mm/khugepaged.c
> +F:	mm/mm_slot.h
>  F:	tools/testing/selftests/mm/khugepaged.c
>  F:	tools/testing/selftests/mm/split_huge_page_test.c
>  F:	tools/testing/selftests/mm/transhuge-stress.c
> -- 
> 2.50.1

Acked-by: Zi Yan <ziy@nvidia.com>

Best Regards,
Yan, Zi

Re: [PATCH] MAINTAINERS: add missing mm_slot.h file THP section

[Nico Pache]

On Tue, Jul 22, 2025 at 11:19 AM Lorenzo Stoakes
<lorenzo.stoakes@oracle.com> wrote:
>
> This seems to be the most appropriate place for this file.
>
> Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 837bc5cd6166..3f83fb317f51 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -15966,6 +15966,7 @@ F:      include/linux/khugepaged.h
>  F:     include/trace/events/huge_memory.h
>  F:     mm/huge_memory.c
>  F:     mm/khugepaged.c
> +F:     mm/mm_slot.h
>  F:     tools/testing/selftests/mm/khugepaged.c
>  F:     tools/testing/selftests/mm/split_huge_page_test.c
>  F:     tools/testing/selftests/mm/transhuge-stress.c
> --
> 2.50.1
It might also be worth adding it to the KSM section since both of them
utilize it.

Acked-by: Nico Pache <npache@redhat.com>
>

Re: [PATCH] MAINTAINERS: add missing mm_slot.h file THP section

[David Hildenbrand]

On 22.07.25 19:43, Nico Pache wrote:
> On Tue, Jul 22, 2025 at 11:19 AM Lorenzo Stoakes
> <lorenzo.stoakes@oracle.com> wrote:
>>
>> This seems to be the most appropriate place for this file.
>>
>> Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
>> ---
>>   MAINTAINERS | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 837bc5cd6166..3f83fb317f51 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -15966,6 +15966,7 @@ F:      include/linux/khugepaged.h
>>   F:     include/trace/events/huge_memory.h
>>   F:     mm/huge_memory.c
>>   F:     mm/khugepaged.c
>> +F:     mm/mm_slot.h
>>   F:     tools/testing/selftests/mm/khugepaged.c
>>   F:     tools/testing/selftests/mm/split_huge_page_test.c
>>   F:     tools/testing/selftests/mm/transhuge-stress.c
>> --
>> 2.50.1
> It might also be worth adding it to the KSM section since both of them
> utilize it.

Yes, good point

Acked-by: David Hildenbrand <david@redhat.com>

-- 
Cheers,

David / dhildenb

Re: [PATCH] MAINTAINERS: add missing mm_slot.h file THP section

[Qi Zheng]

On 7/23/25 1:43 AM, Nico Pache wrote:
> On Tue, Jul 22, 2025 at 11:19 AM Lorenzo Stoakes
> <lorenzo.stoakes@oracle.com> wrote:
>>
>> This seems to be the most appropriate place for this file.
>>
>> Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
>> ---
>>   MAINTAINERS | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 837bc5cd6166..3f83fb317f51 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -15966,6 +15966,7 @@ F:      include/linux/khugepaged.h
>>   F:     include/trace/events/huge_memory.h
>>   F:     mm/huge_memory.c
>>   F:     mm/khugepaged.c
>> +F:     mm/mm_slot.h
>>   F:     tools/testing/selftests/mm/khugepaged.c
>>   F:     tools/testing/selftests/mm/split_huge_page_test.c
>>   F:     tools/testing/selftests/mm/transhuge-stress.c
>> --
>> 2.50.1
> It might also be worth adding it to the KSM section since both of them
> utilize it.
> 

Agree, mm_slot is originally a common part extracted from THP and KSM,
and it is hoped that it can be reused by other modules in the future.

Acked-by: Qi Zheng <zhengqi.arch@bytedance.com>

Thanks.

> 

Re: [PATCH] MAINTAINERS: add missing mm_slot.h file THP section

[Lorenzo Stoakes]

On Tue, Jul 22, 2025 at 11:43:04AM -0600, Nico Pache wrote:
> On Tue, Jul 22, 2025 at 11:19 AM Lorenzo Stoakes
> <lorenzo.stoakes@oracle.com> wrote:
> >
> > This seems to be the most appropriate place for this file.
> >
> > Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> > ---
> >  MAINTAINERS | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 837bc5cd6166..3f83fb317f51 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -15966,6 +15966,7 @@ F:      include/linux/khugepaged.h
> >  F:     include/trace/events/huge_memory.h
> >  F:     mm/huge_memory.c
> >  F:     mm/khugepaged.c
> > +F:     mm/mm_slot.h
> >  F:     tools/testing/selftests/mm/khugepaged.c
> >  F:     tools/testing/selftests/mm/split_huge_page_test.c
> >  F:     tools/testing/selftests/mm/transhuge-stress.c
> > --
> > 2.50.1
> It might also be worth adding it to the KSM section since both of them
> utilize it.

Good idea, will send a fix-patch to do so!

>
> Acked-by: Nico Pache <npache@redhat.com>

Thanks!

Re: [PATCH] MAINTAINERS: add missing mm_slot.h file THP section

[Lorenzo Stoakes]

Hi Andrew,

This file also contains shared logic with KSM, so we ought to put the file
in the KSM section also. I include a fix-patch to do this.

Thanks, Lorenzo

----8<----
From 5ce64eec3514cc7e30afcd9529f73486008f6770 Mon Sep 17 00:00:00 2001
From: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Date: Wed, 23 Jul 2025 05:50:08 +0100
Subject: [PATCH] MAINTAINERS: also add mm_slot.h to KSM section

The mm_slot implementation is in fact common between THP and KSM so ought
to be included in both sections.

Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 3f83fb317f51..a77c6677bdbd 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -15821,6 +15821,7 @@ F:	Documentation/mm/ksm.rst
 F:	include/linux/ksm.h
 F:	include/trace/events/ksm.h
 F:	mm/ksm.c
+F:	mm/mm_slot.h

 MEMORY MANAGEMENT - MEMORY POLICY AND MIGRATION
 M:	Andrew Morton <akpm@linux-foundation.org>
--
2.50.1

Re: [PATCH] MAINTAINERS: add missing mm_slot.h file THP section

[Dev Jain]

On 22/07/25 10:49 pm, Lorenzo Stoakes wrote:
> This seems to be the most appropriate place for this file.
>
> Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> ---
>   

Acked-by: Dev Jain <dev.jain@arm.com>