From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932384AbbJPNgx (ORCPT ); Fri, 16 Oct 2015 09:36:53 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:64495 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932122AbbJPNgs (ORCPT ); Fri, 16 Oct 2015 09:36:48 -0400 From: Arnd Bergmann To: John Garry Cc: James.Bottomley@hansenpartnership.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linuxarm@huawei.com, zhangfei.gao@linaro.org, linux-scsi@vger.kernel.org, xuwei5@hisilicon.com, john.garry2@mail.dcu.ie, hare@suse.de Subject: Re: [PATCH 13/25] scsi: hisi_sas: add path from phyup irq to SAS framework Date: Fri, 16 Oct 2015 15:36:38 +0200 Message-ID: <6858991.h0xpYFqkjM@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <5620FBD3.2020902@huawei.com> References: <1444663237-238302-1-git-send-email-john.garry@huawei.com> <3757591.KXgD8p0a1E@wuerfel> <5620FBD3.2020902@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:8IqbHzWXCe5E5NiM4woWIVaxcguUqQVbP19t2/UVgDYP4qO5YJ9 B5g9fFKM0+qEsYIrx/rcpr81AzJ9YN34G7FMLdO475e/b8lwRjAeP77paB4W1QENBTMpTV3 GM9iMrQPfmf4iLbTL/l6hdSxbrT08eUqZa6qDBjhhmQNBAO9A2tqDFJZz5O343pex79Lnec 03GyBy4YTqTv9Qw+xpjuA== X-UI-Out-Filterresults: notjunk:1;V01:K0:KuxDHDBFnj8=:hwSaU1UUE+QZonH+RBwnok l6oUunllpty7NFb+En6Zhow+ytLf2f6W1F3ClSVetqhz9MOg+cmqVop8nrt9gmTQmW2kqPVFO 6Ow1bgqHwv4X+HKw3BQ1XtxJjQhCYgRRULKMv6Ry18HQVIFMrH61231IFqtuoj6Z002gPKL7C p5QNjOgGZPdlWtCfWyJCY3dvCAEN38auQMNkobvGqeT36GpU2r1gEyanjJcoiO/TkVGUYe6Hk PUEnLbPdLfIePBZvLiwzVvc94sg2Kntoo5Wckju3StYt1B+Uo81QLJHgwXVJ1tbqCEj7GysGx FjERKTCQPG5lbxawA06yuGJWLVYwHksjOSzXSKjrYnK5Cd/apWeS/jsRTXCE05uHSw0cvd1qY 7eJ+X6S3lxIE+n0cNVHdT95pc+RoeISS0sCwbRlofi/KpIM8fSiupVp8e1kIr1hDphVUaC/pg YEIjO9neB3MR62Tzv/s4LrB2z2nNu4bLgrtgsfjTK+NLgVEJdNPagHO9pQzuAI5qaNWSG0GAB UBFilHdI00FMmtRN8YMVxVyYUz4H5R1ESwU0NwahiMqPuaIsMlS1eNQhD/ELRcS7MYiV8Y9nJ 2s7rZQvwkQ/Y5yjpRt5M6fsHNezfrokJvNHNeMitmRAzJEy4qR8HCAJfywmRYpJh+f0yaispO Xf3ir+x6zLdd7lLMNn7zoMXUA8ntmcqf43Vfx2ZSy7CR8NIkNqcNyU2KrInH2jJ0vZxNc7XiB Q53QiQ/kC7/EtMhv Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 16 October 2015 14:29:55 John Garry wrote: > > It could be considered. > > A potential issue I see is with hisi_sas_control_phy() for > PHY_FUNC_HARD_RESET: this allocates a hisi_sas_wq struct and processes > the reset in the queue work. When we re-enable the phy for the reset, > the phyup irq will want to use the same hisi_sas_wq struct which may be > in use. > > hisi_sas_control_phy() is added in 23/35. I'd have to review more closely, but I think that's fine, as this is how most work queues are used: you can queue the same function multiple times, and it's guaranteed to run at least once after the last queue, so if you queue it while it's already running, it will be called again, otherwise it won't. Arnd