From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A90D22C21DD; Sat, 11 Jul 2026 16:58:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783789102; cv=none; b=aZpYy6r6/uKIgnBDatsjl8Wkt8O5hzHOxrWoH1u9h9fnphoblFw3/YK2EvXV6hrmGEqNX+VXptZBvVx9Q6ond6ndafESFmzo8W3kcBVVQZ5ObY/MQD9iOSnjHw/xa+C5VCp4s7xSAdpEQBmV/+xcoVsKQQPuMHCD4PRCxq+YsXk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783789102; c=relaxed/simple; bh=M19w4Ry8fPHhwy/D225jwY/+QrbYkrRhysz9x2SVmY0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KNaZspEqIi8rUHhpfXmwXHNKFDaHSvSkjULPs3f3Js1JMD7fVPPh92hSF2ekCUoq8SLnIol6Y2V/A9ep22KyazoiP9gVesTfiJmlg8wFXsH6xxE9GZMnUYplAhVOKByMfr1H02K2BOlwbTEL90K/Nmo/1UDM1tbKUMh32kkozsQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fvCp3ikg; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fvCp3ikg" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CE0AA1F000E9; Sat, 11 Jul 2026 16:58:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783789101; bh=8LVWF0zRZFBT7ZHQPnyxfEExZ0tbS7bYRRc3O2NjxU0=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=fvCp3ikgIQBcbIo2L9bcLzPHTW/8sJz1E3vDMGgsRx+jNzNHeTMqJEHEW7L8rcgWg 89luY1JaPosu9YH3amb0LyzxNXs+iDAJXtEsHYN9wPDecqZs+OD1JLIgDOjxZUUhyM aJ6kQqB685TxLKoog7qgH7UJBQmNxnS8LIIjnjVzwN5jhCF9rAhTCrFicV51tbQFDZ Vqe9xEaauuxvRs81gOe+b3chSQ55bjts7xvYVo2m3aiqtuk+fI2qXabTJqJEfkLdfL c0L/OgRkwGYccc/Sdru+qRIOf8CitdFyLk/WXgtSCUybXlMavNnEFuW6eW6bvX0tyc Mj35FsW9JtbIQ== Message-ID: <68630192-970b-4b1c-9dc5-d4145d3eb15f@kernel.org> Date: Sat, 11 Jul 2026 18:58:13 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] dt-bindings: net: microchip,lan78xx: convert to DT schema To: Mikhail Lukianchikov , Rengarajan.S@microchip.com Cc: andrew+netdev@lunn.ch, conor+dt@kernel.org, davem@davemloft.net, devicetree@vger.kernel.org, edumazet@google.com, krzk+dt@kernel.org, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, pabeni@redhat.com, robh@kernel.org References: <20260711105537.11065-2-avermoal@gmail.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGPBBMBCgA5AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJp2mE8AAoJEBuTQ307QWKbeaIP /ihHTkTW4KsN/DQ945JJbyu5tI0J80Wue7QyyLPglyKfhgb5cLLNPpOC8cCIJsc7+W3i2P38 s2c1cOH6CYGE7E9ur3Vfme8NW2S2I/Z8VC7bZnzyS23wT17LrsdS/qCpx4o8U+pt/xdXDKph EGRYrIEmMpUWvyYzyYKGIe25FtaayIIKpq8eZYyFcp2f/sG5IkOW5uZzHPMPdcm87jU7fyuQ rAU2vx9r+ulUfQ/q9Z2roC/ode3l7t2pN7BCBCsUDp6JCrUyZrtT1e7EbA0ZRP3aOBNk2P2E DQOgJGjGdO5Yx2Y9LFtltu6JbsBJHi1syGRX3AtQYOMc4Y1WGoeZJmMlvKj2ZqqXNkcWi2DS IQEWB0uW6CqFsBBIMGDa+6OzdaVO/uAVXWDWml02Men3CILdI1MbVjoh8ECqYUY7OQ+JJvNN vnliuq5WM3Ghd3jg/LZZrxXjdIginRHFQCjIJYLKpLZWm1/iDFedcfzqRNYmTtqscdCNHW41 oT3Z7BmO9xwdjuwBS6nmS6JJwkbf5Ot2QR4pB/DRU7ZwjT1qHe+9r9gF32wXVQatHNGK/VVu sfwOnkdxCWkp/qb2gdQRmZh+SedStWshigH6sNfuHBloF/q+hjMRc8b2m326OZdrbSHwY1Sz vti8Hn7n8NjdHO9LKB7BIdjkA9DA5WsqOuVCzsFNBFVDXDQBEADNkrQYSREUL4D3Gws46JEo Z9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLueMNsWLJBv BaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6eiOMheesVS 5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wAGldWsRxb f3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA6z6lBZn0 WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9YegxWKvX XHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt91pFzBSO IpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gUBLHFTg2h YnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/JoFzZ4B0 p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu4vXVFBYI GmpyNPYzRm0QPwARAQABwsF2BBgBCgAgAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmna YUkACgkQG5NDfTtBYptX+BAApg32CkxwNucNEi8WfWA8oKkW0y8YDuY6ORMo9FWNGiT/OTy0 vyJrLocrpn86zwfjVp+eCrssPYh8eqJfnWqmYv6ACQtHPYzPZQ3mSo8H97Z01oUxITzCxpXm ZkLgPIqtDPcC2E3dPM/fVxcyowM8XsaMA9wcsaUYrta8toOq2b9tKcjleKMfMrm0gQ9u7wUc QbLkwj6TCLOwucb07GXzLTNF9PZmaDUpKAZjMjmrW+le+SFvQbhamx0rxLWPR0NWntXpbCn+ +ACch03p/JyTBVktxFsFyCt7pTPE1kEaeuXBTe/a2D9iQvRxRW19LvuO2e59/u1wYUiH/orz wbIC2S4dBsPAPihL3ztOU1yE86GPyQtSE0kU+/7snnLt4QGi6PChf3t5gnNjAzjUUovO8rgI c+5yN5heq5loYHgK6OQ9OlHzsPHO9e9MOQcKlFycs1pyijFGzDwdNUm/SchK8iWT2QApTx4A K9bCVaboTA2T77QYkRcRJYSsO1alGX0ome/hMLD1daXlkrNUp1HWa3K4iytLRXjCSIorWiGs n+q3krnpXu3TFkA8qtOFZMdnIiFuiq1yLT8hptsV5xh1TA2nsVvSYiaCr3q4s4BKjS/KrLDb qoxzw8ISjdUp4pA85vb6YLCmb39NgidD+7PmAr65lBNveIFynTgsja1rRQ4= In-Reply-To: <20260711105537.11065-2-avermoal@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/07/2026 12:55, Mikhail Lukianchikov wrote: > The conversion adds proper validation for the 'microchip,led-modes' > property inside the MDIO node. It was in the old binding, so I don't understand this part. You list here changes done to the binding during conversion. I see no change, so what does this refer to? > > Signed-off-by: Mikhail Lukianchikov > --- > Changes in v3: > - Added $ref to ethernet-phy.yaml for PHY node to use standard PHY properties. > - Dropped redundant PHY description and manual 'reg' property definition. > - Dropped root node and fake compatibles in the example. > > Link to v2: https://lore.kernel.org/netdev/20260709181724.24682-2-avermoal@gmail.com > > .../bindings/net/microchip,lan7800.yaml | 96 +++++++++++++++++++ > .../bindings/net/microchip,lan78xx.txt | 53 ---------- > MAINTAINERS | 3 +- > 3 files changed, 97 insertions(+), 55 deletions(-) > create mode 100644 Documentation/devicetree/bindings/net/microchip,lan7800.yaml > delete mode 100644 Documentation/devicetree/bindings/net/microchip,lan78xx.txt > > diff --git a/Documentation/devicetree/bindings/net/microchip,lan7800.yaml b/Documentation/devicetree/bindings/net/microchip,lan7800.yaml > new file mode 100644 > index 000000000000..730999d11e8a > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/microchip,lan7800.yaml > @@ -0,0 +1,96 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/microchip,lan7800.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Microchip LAN7800/LAN7801/LAN7850 Gigabit Ethernet controller > + > +maintainers: > + - Rengarajan Sundararajan > + > +description: > + The LAN7800/LAN7801/LAN7850 devices are usually configured by > + programming their OTP or with an external EEPROM, but some > + platforms (e.g. Raspberry Pi 3 B+) have neither. The Device Tree > + properties, if present, override the OTP and EEPROM. > + > +allOf: > + - $ref: /schemas/usb/usb-device.yaml# > + - $ref: /schemas/net/ethernet-controller.yaml# > + > +properties: > + compatible: > + enum: > + - usb424,7800 > + - usb424,7801 > + - usb424,7850 > + > + reg: > + maxItems: 1 > + description: USB port number > + > + local-mac-address: > + $ref: /schemas/types.yaml#/definitions/uint8-array > + minItems: 6 > + maxItems: 6 > + description: > + MAC address to use if not stored in OTP or EEPROM. If present, > + overrides OTP/EEPROM. Drop local-mac-address, already coming from network-class schema. > + > + mdio: > + $ref: /schemas/net/mdio.yaml# > + unevaluatedProperties: false ... > diff --git a/MAINTAINERS b/MAINTAINERS > index f37a81950e25..157a677a284f 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -27928,10 +27928,9 @@ F: drivers/usb/isp1760/* > USB LAN78XX ETHERNET DRIVER > M: Thangaraj Samynathan > M: Rengarajan Sundararajan > -M: UNGLinuxDriver@microchip.com I don't understand this change. No one requested this. Not explained in commit msg at all. > L: netdev@vger.kernel.org > S: Maintained > -F: Documentation/devicetree/bindings/net/microchip,lan78xx.txt > +F: Documentation/devicetree/bindings/net/microchip,lan7800.yaml > F: drivers/net/usb/lan78xx.* > F: include/dt-bindings/net/microchip-lan78xx.h > Best regards, Krzysztof