From: Jens Axboe <axboe@kernel.dk>
To: Julia Lawall <julia.lawall@inria.fr>,
Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: Denis Efremov <efremov@linux.com>, kbuild-all@lists.01.org
Subject: Re: [PATCH] coccinelle: api: fix kobj_to_dev.cocci warnings
Date: Thu, 27 Aug 2020 16:24:26 -0600 [thread overview]
Message-ID: <68701ff1-bff5-c3f9-a970-fb7670ac112e@kernel.dk> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2008272211260.2482@hadrien>
On 8/27/20 2:13 PM, Julia Lawall wrote:
> Use kobj_to_dev() instead of container_of()
>
> Generated by: scripts/coccinelle/api/kobj_to_dev.cocci
Seem to see more of these, these days. I don't really like them, why not
just use container_of? The private bla_to_foo() helpers should go away,
they are actively hurting readability of the code imho.
--
Jens Axboe
next prev parent reply other threads:[~2020-08-27 22:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 20:13 [PATCH] coccinelle: api: fix kobj_to_dev.cocci warnings Julia Lawall
2020-08-27 22:24 ` Jens Axboe [this message]
[not found] <13cd8bf4-06f9-04d7-e923-c397c506e8cc@web.de>
2020-08-27 20:05 ` Julia Lawall
[not found] <CGME20200826205412eucas1p16c748e9d73f4cd924aae1d6386ab450c@eucas1p1.samsung.com>
2020-08-26 20:54 ` Julia Lawall
2020-09-08 11:37 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68701ff1-bff5-c3f9-a970-fb7670ac112e@kernel.dk \
--to=axboe@kernel.dk \
--cc=efremov@linux.com \
--cc=hch@lst.de \
--cc=julia.lawall@inria.fr \
--cc=kbuild-all@lists.01.org \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox