public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Evgeny Novikov <novikov@ispras.ru>
To: Jean Delvare <jdelvare@suse.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
	linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
	ldv-project-org <ldv-project@linuxtesting.org>
Subject: hwmon: (xgene) missing iounmap() and memunmap()
Date: Fri, 17 Jul 2020 17:50:44 +0300	[thread overview]
Message-ID: <687151594996519@mail.yandex.ru> (raw)

xgene_hwmon_probe() invokes ioremap() and memremap() under
certain assumptions, but the driver does not invoke iounmap() and
memunmap() either on probe error handling paths or in
xgene_hwmon_remove().

I assume a patch would be non-trivial while I have not a capability
to test it well.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Evgeny Novikov <novikov@ispras.ru>

                 reply	other threads:[~2020-07-17 14:56 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=687151594996519@mail.yandex.ru \
    --to=novikov@ispras.ru \
    --cc=jdelvare@suse.com \
    --cc=ldv-project@linuxtesting.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox