Re: [PATCH][STABLE] audit: correct AUDIT_GET_FEATURE return message type

[Paul Moore <paul@paul-moore.com>]

On Wednesday, October 29, 2014 09:35:06 AM Richard Guy Briggs wrote:
> When an AUDIT_GET_FEATURE message is sent from userspace to the kernel, it
> should reply with a message tagged as an AUDIT_GET_FEATURE type with a
> struct audit_feature.  The current reply is a message tagged as an
> AUDIT_GET type with a struct audit_feature.
> 
> This appears to have been a cut-and-paste-eo in commit b0fed40.
> 
> Reported-by: Steve Grubb <sgrubb@redhat.com>
> Cc: stable@vger.kernel.org # v3.13-rc1
> Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
> ---
>  kernel/audit.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Acked-by: Paul Moore <paul@paul-moore.com>

> diff --git a/kernel/audit.c b/kernel/audit.c
> index d20f00f..3a80abb 100644
> --- a/kernel/audit.c
> +++ b/kernel/audit.c
> @@ -724,7 +724,7 @@ static int audit_get_feature(struct sk_buff *skb)
> 
>  	seq = nlmsg_hdr(skb)->nlmsg_seq;
> 
> -	audit_send_reply(skb, seq, AUDIT_GET, 0, 0, &af, sizeof(af));
> +	audit_send_reply(skb, seq, AUDIT_GET_FEATURE, 0, 0, &af, sizeof(af));
> 
>  	return 0;
>  }

-- 
paul moore
www.paul-moore.com