Re: [PATCH v3] genirq: Fix parameter type in declaration and definition

Thomas Gleixner
2025-03-13T11:31:49Z

On Thu, Mar 13 2025 at 16:18, ye xingchen wrote:

$Subject: ... Fix ...

There is nothing to fix here. It's correct code.

> This patch aligns the parameter name in the definition with the

See other reply.

> --- a/kernel/irq/manage.c
> +++ b/kernel/irq/manage.c
> @@ -2860,7 +2860,7 @@ EXPORT_SYMBOL_GPL(irq_get_irqchip_state);
> * interrupt controller has per-cpu registers.
> */
> int irq_set_irqchip_state(unsigned int irq, enum irqchip_irq_state which,
> - bool val)
> + bool state)

Now the kernel doc of that function is inconsistent.

You are not making anything more consistent, you are actively making it
worse. Please stop sending half thought out patches every half an hour.

Thanks,

tglx