From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Tree Davies <tdavies@darkphysics.net>,
gregkh@linuxfoundation.org, anjan@momi.ca
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] Staging: rtl8192e: Rename variable bHwError
Date: Fri, 30 Aug 2024 21:11:55 +0200 [thread overview]
Message-ID: <6885753f-d663-4e00-9007-60f8d659804f@gmail.com> (raw)
In-Reply-To: <20240830020508.532945-3-tdavies@darkphysics.net>
On 8/30/24 04:05, Tree Davies wrote:
> Rename variable bHwError to hw_error
> to fix checkpatch warning Avoid CamelCase.
>
> Signed-off-by: Tree Davies <tdavies@darkphysics.net>
> ---
> drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 8 ++++----
> drivers/staging/rtl8192e/rtllib.h | 2 +-
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> index 519cad9e1106..15fda2d87da9 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> @@ -1506,7 +1506,7 @@ static void _rtl92e_translate_rx_signal_stats(struct net_device *dev,
> (fc & IEEE80211_FCTL_TODS) ? hdr->addr1 :
> (fc & IEEE80211_FCTL_FROMDS) ? hdr->addr2 :
> hdr->addr3) &&
> - (!pstats->bHwError) && (!pstats->bCRC) && (!pstats->bICV));
> + (!pstats->hw_error) && (!pstats->bCRC) && (!pstats->bICV));
> bpacket_toself = bpacket_match_bssid && /* check this */
> ether_addr_equal(praddr, priv->rtllib->dev->dev_addr);
> if (ieee80211_is_beacon(hdr->frame_control))
> @@ -1630,13 +1630,13 @@ bool rtl92e_get_rx_stats(struct net_device *dev, struct rtllib_rx_stats *stats,
>
> stats->bICV = pdesc->ICV;
> stats->bCRC = pdesc->CRC32;
> - stats->bHwError = pdesc->CRC32 | pdesc->ICV;
> + stats->hw_error = pdesc->CRC32 | pdesc->ICV;
>
> stats->Length = pdesc->Length;
> if (stats->Length < 24)
> - stats->bHwError |= 1;
> + stats->hw_error |= 1;
>
> - if (stats->bHwError)
> + if (stats->hw_error)
> return false;
>
> stats->RxDrvInfoSize = pdesc->RxDrvInfoSize;
> diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
> index 82fef04e5784..76f53b797644 100644
> --- a/drivers/staging/rtl8192e/rtllib.h
> +++ b/drivers/staging/rtl8192e/rtllib.h
> @@ -467,7 +467,7 @@ struct rtllib_rx_stats {
> u8 SignalQuality;
> s32 RecvSignalPower;
> u8 SignalStrength;
> - u16 bHwError:1;
> + u16 hw_error:1;
> u16 bCRC:1;
> u16 bICV:1;
> u16 decrypted:1;
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
next prev parent reply other threads:[~2024-08-30 19:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-30 2:05 [PATCH 0/3] Staging: rtl8192e: Yet another variable rename and cleanup series Tree Davies
2024-08-30 2:05 ` [PATCH 1/3] Staging: rtl8192e: Rename variable pNetwork Tree Davies
2024-08-30 19:11 ` Philipp Hortmann
2024-08-30 2:05 ` [PATCH 2/3] Staging: rtl8192e: Rename variable bHwError Tree Davies
2024-08-30 19:11 ` Philipp Hortmann [this message]
2024-08-30 2:05 ` [PATCH 3/3] Staging: rtl8192e: Add spaces around operators Tree Davies
2024-08-30 19:26 ` Philipp Hortmann
2024-09-03 8:34 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6885753f-d663-4e00-9007-60f8d659804f@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=anjan@momi.ca \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=tdavies@darkphysics.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox