From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754474AbcIFCZl convert rfc822-to-8bit (ORCPT <rfc822;w@1wt.eu>);
        Mon, 5 Sep 2016 22:25:41 -0400
Received: from mx5-phx2.redhat.com ([209.132.183.37]:59210 "EHLO
        mx5-phx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752652AbcIFCZj (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 5 Sep 2016 22:25:39 -0400
Date: Mon, 5 Sep 2016 22:25:31 -0400 (EDT)
From: Jerome Glisse <jglisse@redhat.com>
To: Sven Joachim <svenjoac@gmx.de>
Cc: Christian =?utf-8?Q?K=C3=B6nig?= <christian.koenig@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        dri-devel@lists.freedesktop.org, lkml <linux-kernel@vger.kernel.org>
Message-ID: <688782233.2035106.1473128731891.JavaMail.zimbra@redhat.com>
In-Reply-To: <87a8fmq355.fsf@turtle.gmx.de>
References: <87a8fmq355.fsf@turtle.gmx.de>
Subject: Re: Hibernation broken since commit 274ad65c9d02 ("drm/radeon: hard
 reset r600 and newer GPU when hibernating.")
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8BIT
X-Originating-IP: [10.10.49.178]
X-Mailer: Zimbra 8.0.6_GA_5922 (ZimbraWebClient - FF48 (Linux)/8.0.6_GA_5922)
Thread-Topic: Hibernation broken since commit 274ad65c9d02 ("drm/radeon: hard reset r600 and newer GPU when hibernating.")
Thread-Index: V0StuKur360bH6KNhinPaXcgKhGQtw==
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Recently I got myself a new laptop with the following integrated GPU:
> 
> 00:01.0 VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI]
> Mullins [Radeon R3 Graphics] (rev 40)
> 
> I found that hibernation is broken in Linux 4.7+ (it works in Linux 4.6)
> and bisected it to commit 274ad65c9d02 ("drm/radeon: hard reset r600 and
> newer GPU when hibernating.").
> 
> This has already been reported three months ago, but for a much older
> GPU, see the thread starting at
> https://lists.freedesktop.org/archives/dri-devel/2016-June/110050.html.
> The symptoms are exactly the same as described by Boris Petkov in that
> thread: after "systemctl hibernate" the screen goes blank, but the
> machine remains powered on and needs to be power-cycled.
> 
> Any suggestions would be welcome.
> 
> Cheers,
>        Sven

I guess we can invert the logic and only do it for the GPU for which it fix
hibernation.

Cheers,
Jérôme