public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Swapnil Sapkal <Swapnil.Sapkal@amd.com>
To: Chen Yu <yu.c.chen@intel.com>, Shrikanth Hegde <sshegde@linux.ibm.com>
Cc: linux-kernel@vger.kernel.org, mingo@redhat.com,
	peterz@infradead.org, torvalds@linux-foundation.org,
	juri.lelli@redhat.com, dietmar.eggemann@arm.com,
	rostedt@goodmis.org, mgorman@suse.de, bristot@redhat.com,
	vschneid@redhat.com, vincent.guittot@linaro.org,
	gautham.shenoy@amd.com, kprateek.nayak@amd.com
Subject: Re: [RESEND][PATCH v3 1/1] sched: Report the different kinds of imbalances in /proc/schedstat
Date: Wed, 15 May 2024 10:42:17 +0530	[thread overview]
Message-ID: <688af2f2-dbff-4941-93ec-405d3431dd01@amd.com> (raw)
In-Reply-To: <ZkN/7Wo4qVRmFQBU@chenyu5-mobl2>

Hi Chenyu,

Thank you for taking look at this patch.

On 5/14/2024 8:44 PM, Chen Yu wrote:
> On 2024-05-14 at 19:53:58 +0530, Shrikanth Hegde wrote:
>>
>>
>> On 5/14/24 4:44 PM, Chen Yu wrote:
>>> On 2024-05-14 at 04:44:45 +0000, Swapnil Sapkal wrote:
>>
>> It's been increased already as part of below commit
>>
>> commit 11b0bfa5d463b17cac5bf6b94fea4921713530c3
>> Author: Ingo Molnar <mingo@kernel.org>
>> Date:   Fri Mar 8 11:58:55 2024 +0100
>>
>>      sched/debug: Increase SCHEDSTAT_VERSION to 16
>>      
>>      We changed the order of definitions within 'enum cpu_idle_type',
>>      which changed the order of [CPU_MAX_IDLE_TYPES] columns in
>>      show_schedstat().
>>
>>
> 
> I see, so it has been increased due to commit 38d707c54df4, and current patch
> is accomany with that.

Yes, this patch accompanies commit 38d707c54df4. It updates the documentation
because of change in order of [CPU_MAX_IDLE_TYPES] columns and adds the imbalance
fields which will be used by Perf schedstat tool[1].

[1] https://lore.kernel.org/all/20240508060427.417-1-ravi.bangoria@amd.com/

> 
> thanks,
> Chenyu

--
Thanks and Regards,
Swapnil


      reply	other threads:[~2024-05-15  5:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-14  4:44 [RESEND][PATCH v3 0/1] Fix lb_imbalance reporting in /proc/schedstat Swapnil Sapkal
2024-05-14  4:44 ` [RESEND][PATCH v3 1/1] sched: Report the different kinds of imbalances " Swapnil Sapkal
2024-05-14 11:14   ` Chen Yu
2024-05-14 14:23     ` Shrikanth Hegde
2024-05-14 15:14       ` Chen Yu
2024-05-15  5:12         ` Swapnil Sapkal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=688af2f2-dbff-4941-93ec-405d3431dd01@amd.com \
    --to=swapnil.sapkal@amd.com \
    --cc=bristot@redhat.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=gautham.shenoy@amd.com \
    --cc=juri.lelli@redhat.com \
    --cc=kprateek.nayak@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=sshegde@linux.ibm.com \
    --cc=torvalds@linux-foundation.org \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    --cc=yu.c.chen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox