From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Arthur Crépin Leblond" <arthur@marmottus.net>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v4 2/3] dt-bindings: net: wiznet,w5100: add link status interrupt
Date: Tue, 11 Aug 2026 15:36:43 +0200 [thread overview]
Message-ID: <688f57cd-a098-4904-b8cd-965470a89386@kernel.org> (raw)
In-Reply-To: <20260811-wiznet-link-gpio-v4-2-4d5f7da885a8@marmottus.net>
On 11/08/2026 14:34, Arthur Crépin Leblond wrote:
> Add an optional link status interrupt which can be connected to the
> LINKLED pin on the device to detect link status changes.
>
> Signed-off-by: Arthur Crépin Leblond <arthur@marmottus.net>
> ---
> Documentation/devicetree/bindings/net/wiznet,w5100.yaml | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/wiznet,w5100.yaml b/Documentation/devicetree/bindings/net/wiznet,w5100.yaml
> index 641c9ddbde9e..30f013f40a77 100644
> --- a/Documentation/devicetree/bindings/net/wiznet,w5100.yaml
> +++ b/Documentation/devicetree/bindings/net/wiznet,w5100.yaml
> @@ -24,7 +24,11 @@ properties:
> - wiznet,w5500
>
> interrupts:
> - maxItems: 1
> + maxItems: 2
This is redundant, instead you need "minItems: 1"
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-08-11 13:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-11 12:34 [PATCH net-next v4 0/3] w5100: restore GPIO-based link detection Arthur Crépin Leblond
2026-08-11 12:34 ` [PATCH net-next v4 1/3] dt-bindings: net: wiznet,w5100: convert to DT schema Arthur Crépin Leblond
2026-08-11 12:57 ` Arnd Bergmann
2026-08-11 14:14 ` Arthur Crépin Leblond
2026-08-11 14:25 ` Arnd Bergmann
2026-08-11 12:34 ` [PATCH net-next v4 2/3] dt-bindings: net: wiznet,w5100: add link status interrupt Arthur Crépin Leblond
2026-08-11 13:33 ` Rob Herring (Arm)
2026-08-11 13:36 ` Krzysztof Kozlowski [this message]
2026-08-11 14:02 ` Arthur Crépin Leblond
2026-08-11 12:34 ` [PATCH net-next v4 3/3] w5100: detect carrier state using link status bit and optional interrupt Arthur Crépin Leblond
2026-08-11 13:01 ` [PATCH net-next v4 0/3] w5100: restore GPIO-based link detection Arnd Bergmann
2026-08-11 13:37 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=688f57cd-a098-4904-b8cd-965470a89386@kernel.org \
--to=krzk@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=arnd@arndb.de \
--cc=arthur@marmottus.net \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox