From: Krzysztof Kozlowski <krzk@kernel.org>
To: Bjorn Andersson <quic_bjorande@quicinc.com>,
Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] soc: qcom: fix module autoloading
Date: Wed, 10 Apr 2024 20:28:41 +0200 [thread overview]
Message-ID: <689f6a74-185d-4f2f-8c31-e6502b7e6060@kernel.org> (raw)
In-Reply-To: <ZhbWU0lk4mNBv1OE@hu-bjorande-lv.qualcomm.com>
On 10/04/2024 20:11, Bjorn Andersson wrote:
> On Wed, Apr 10, 2024 at 07:53:32PM +0200, Konrad Dybcio wrote:
>>
>>
>> On 4/10/24 18:40, Krzysztof Kozlowski wrote:
>>> Add MODULE_DEVICE_TABLE(), so the module could be properly autoloaded
>>> based on the alias from of_device_id table.
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>>> ---
>>
>> These were omitted intentionally, as these are both debug drivers.
>>
>
> Makes sense to me, could we have a comment added that clarifies this
> intention?
>
>> Perhaps we could mkdir drivers/soc/qcom/debug to make this clearer
>>
>
> Not sure if that is necessary, and IMO it wouldn't convey that
> MODULE_DEVICE_TABLE() was omitted intentionally.
I think this deserves a comment, so no one will be doing my same again
(it's part of bigger effort).
Best regards,
Krzysztof
prev parent reply other threads:[~2024-04-10 18:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-10 16:40 [PATCH] soc: qcom: fix module autoloading Krzysztof Kozlowski
2024-04-10 17:53 ` Konrad Dybcio
2024-04-10 18:11 ` Bjorn Andersson
2024-04-10 18:28 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=689f6a74-185d-4f2f-8c31-e6502b7e6060@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_bjorande@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox