From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: LihaSika <lihasika@gmail.com>,
Linux USB <linux-usb@vger.kernel.org>,
Linux USB Storage <usb-storage@lists.one-eyed-alien.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Alan Stern <stern@rowland.harvard.edu>,
Milan Svoboda <milan.svoboda@centrum.cz>,
Matthieu Castet <castet.matthieu@free.fr>
Subject: Re: [PATCH] usb: storage: set 1.50 as the lower bcdDevice for older "Super Top" compatibility
Date: Sat, 28 Oct 2023 18:05:44 +0700 [thread overview]
Message-ID: <68ad3c1c-bc5b-4dd5-9183-202d8b04b45f@gmail.com> (raw)
In-Reply-To: <2023102848-esteemed-reptile-851f@gregkh>
On 28/10/2023 17:23, Greg Kroah-Hartman wrote:
> On Sat, Oct 28, 2023 at 02:02:37PM +0700, Bagas Sanjaya wrote:
>> On Fri, Oct 27, 2023 at 08:28:04PM +0300, LihaSika wrote:
>>> Change lower bcdDevice value for "Super Top USB 2.0 SATA BRIDGE" to match
>>> 1.50. I have such an older device with bcdDevice=1.50 and it will not work
>>> otherwise.
>>
>> What about below description?
>>
>> ```
>> Some old USB hard drives using Super Top USB 2.0 SATA bridge have lower
>> minimum bcdDevice value than currently allowed (1.60). Such devices
>> cannot be used by ums-cypress driver since their bcdDevice is out of range.
>>
>> Lower minimum bcdDevice to fix that.
>> ```
>>
>>>
>>> Cc: stable@vger.kernel.org
>>> Signed-off-by: Liha Sikanen <lihasika@gmail.com>
>>
>> Is your intended author name in your From: header or Signed-off-by: trailer?
>>
>> Also, don't forget to add Fixes: tag; that is:
>>
>> Fixes: a9c143c82608 ("usb-storage: restrict bcdDevice range for Super Top in Cypress ATACB")
>>
>> When above reviews are addressed, resend as v2. Make sure that the patch
>> subject begins with `[PATCH v2]`.
>
> There's no need, I can take this as-is, thanks.
>
OK, thanks!
--
An old man doll... just what I always wanted! - Clara
prev parent reply other threads:[~2023-10-28 11:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <ZTsR-RhhjxSpqrsz@debian.me>
[not found] ` <055de764-c422-4c22-a79b-dd4db56122ce@gmail.com>
[not found] ` <2023102704-stable-lid-c86a@gregkh>
[not found] ` <7484f7c8-a49c-4111-83f0-bb6db2906fae@gmail.com>
[not found] ` <2023102729-spent-ninja-7e39@gregkh>
[not found] ` <037e5af2-3afd-4a37-a4d7-6dc87af605c7@gmail.com>
[not found] ` <21c2b8ee-7753-413e-98f9-d1401edf5c73@gmail.com>
[not found] ` <2023102720-emotion-overlying-9bb4@gregkh>
[not found] ` <ccf7d12a-8362-4916-b3e0-f4150f54affd@gmail.com>
2023-10-28 7:02 ` [PATCH] usb: storage: set 1.50 as the lower bcdDevice for older "Super Top" compatibility Bagas Sanjaya
2023-10-28 10:23 ` Greg Kroah-Hartman
2023-10-28 11:05 ` Bagas Sanjaya [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68ad3c1c-bc5b-4dd5-9183-202d8b04b45f@gmail.com \
--to=bagasdotme@gmail.com \
--cc=castet.matthieu@free.fr \
--cc=gregkh@linuxfoundation.org \
--cc=lihasika@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=milan.svoboda@centrum.cz \
--cc=stern@rowland.harvard.edu \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox