From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D68FC45104C for ; Wed, 8 Jul 2026 12:57:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=198.175.65.17 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783515432; cv=fail; b=M3Y0EZbWgZnZVNw98K8Epp2MTF3923jleqPn9r9V9fCddD0p2VKYH6COLW4BeUdGK6oCbNU71ulSYn58VD9NzeWCQIdR33qpB+SrrTmfzsThpzT2U1TNrnLxnjY/dymvZ56J7lMEJXU+wGMDNTnp5W8Y5K1I4oCdY3C2bkdvvs0= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783515432; c=relaxed/simple; bh=SZMI0MHFqYVLRyDfXcz3DhQBkuBM9KJZnHcgKqp40JU=; h=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To: Content-Type:MIME-Version; b=TJlBYqbSG7dHlNMBTjiOhbBdNwVGsOpNRGSFtKMdc+yyM3DqoZLDmuOtdmtvQn1brIXu2cVx1OQvZ75YCi2TYPLJ3eeudad8GJOKbutyf2kTz3LFcNL96uequKOnDwP1soGT4j/mV7H+Gv9y1PpeVYBZRKCasH7Qd7DZ+hCTbu4= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Y1MH7FE4; arc=fail smtp.client-ip=198.175.65.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Y1MH7FE4" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1783515430; x=1815051430; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=SZMI0MHFqYVLRyDfXcz3DhQBkuBM9KJZnHcgKqp40JU=; b=Y1MH7FE4JHjyKjYiqsULTN+vofcOfIctBv3noNub/rDsz+k0PTRJHDQJ JUemvRim690ZzSP4uPPW0Ej6oeQe5fYVK9HDVsiXVd49s43MpbzscUeds C62SDZ8VPHlv/jcJFWqi8ci3HCFoLxBLaFVDkA/O4t2dg5xVpKjSuQyp2 UPOFsTjTo3SKeIDhae/FOw9Ug3/vsORLydAM/DBnXaPfa69ZsKLkJhZg/ Xk/nVSfTy+EEb9ZdXbJOHhjH001wdFZQv98V9fJgNnruEzhngmOk+TPw1 nz9efm8XWLXcUgIRJp/gS7WJgXSTXFGLnq3rH+xiE6JVPVwa7FshmjkdZ w==; X-CSE-ConnectionGUID: r1gXrn12TxyZY9mz3Ecwaw== X-CSE-MsgGUID: 0Tcac/GLS7yFdzpp3fCvNQ== X-IronPort-AV: E=McAfee;i="6800,10657,11840"; a="84196831" X-IronPort-AV: E=Sophos;i="6.25,153,1779174000"; d="scan'208";a="84196831" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2026 05:57:10 -0700 X-CSE-ConnectionGUID: 4Miy9m//SU2f/tEP6lCsuQ== X-CSE-MsgGUID: ZlNBRvwFT2a6Qmf+yBUcxA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,153,1779174000"; d="scan'208";a="253790831" Received: from orsmsx901.amr.corp.intel.com ([10.22.229.23]) by orviesa008.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2026 05:57:09 -0700 Received: from ORSMSX902.amr.corp.intel.com (10.22.229.24) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.43; Wed, 8 Jul 2026 05:57:08 -0700 Received: from ORSEDG902.ED.cps.intel.com (10.7.248.12) by ORSMSX902.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.43 via Frontend Transport; Wed, 8 Jul 2026 05:57:08 -0700 Received: from CO1PR03CU002.outbound.protection.outlook.com (52.101.46.48) by edgegateway.intel.com (134.134.137.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.43; Wed, 8 Jul 2026 05:57:07 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ce9KHIp5r5tb/ATBRp4yhkdNpaH1MsosXAx/Nrc3B22+2AuVPKKLfoc1jnWSeLvm4JibRETzQGOot14iTeNvreIWYvsLiYjtFyLPexKIQ01DohX2LzO3E6HfyetXjertVEbaeUvCLG2fLv3Izb5gPLwfm9Aah7hyFpeqdmj2p2brOdZZZphNrEoL/fXyoGkA1Af1EEefcb19KGx/IDTbHLMBI7NTORMbNh8v57YEXhR4txhx5yszV44w/XfaxKs0VhL2Z6M8HNzyzEvlkCFa8a9sP6LXB1/6M3k3Xf6mKYwg7VqMBxGJH2QhKSA+3HYWq88damOjaG2JNNVRew9ZcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sn9eyKLO2upHyD/M8MW50s3RZHt5d+DXewHdND2n/+o=; b=pIk4CnUGT1JwzLlJkCf0IBZ/HBNblrLrO9kp8domN1/IBOTPZJPiXfTynHVlWwE/3301iAZaJqRM/QaXvwhwIPxl9JvPImc+3291OLw0Za2guOpmNAgj9GyZQ/RndwEjNP7x+A27mHNgp4Bd1BsRkCSZ3dQsrhm04nsU1RfUIvGMAxzHKby5xeayuAdL5h29Ly5+FcubL42s5gD1QM+vthNXL6m5KPugmYDD6yLy/u2T5F0OzKosJ8cv1q8CRrerzZphRidA9coXN8zyBxpR3ZqThLgRuXgJDICPMFe6tGGcVRAMj3Q9Ew9y0Uz/Cfim6uRyupze+JEo3Tcs9LPUSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM4PR11MB6020.namprd11.prod.outlook.com (2603:10b6:8:61::19) by CY8PR11MB7847.namprd11.prod.outlook.com (2603:10b6:930:7c::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.8; Wed, 8 Jul 2026 12:57:05 +0000 Received: from DM4PR11MB6020.namprd11.prod.outlook.com ([fe80::3058:1480:e4ac:5765]) by DM4PR11MB6020.namprd11.prod.outlook.com ([fe80::3058:1480:e4ac:5765%4]) with mapi id 15.21.0181.008; Wed, 8 Jul 2026 12:57:04 +0000 Message-ID: <68b1b8db-4ffd-4e3b-a097-3bade368ab73@intel.com> Date: Wed, 8 Jul 2026 20:56:52 +0800 User-Agent: Mozilla Thunderbird Subject: Re: [RFC] mpam,x86,fs/resctrl: Generic schema description Proof of Concept To: Reinette Chatre CC: Ben Horgan , James Morse , "Dave Martin" , Babu Moger , Drew Fustini , Fenghua Yu , Borislav Petkov , Thomas Gleixner , Dave Hansen , Peter Newman , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , "Luck, Tony" , References: <9b81527e-22e9-4cad-ac32-773f5c9d81e7@intel.com> Content-Language: en-US From: "Chen, Yu C" In-Reply-To: <9b81527e-22e9-4cad-ac32-773f5c9d81e7@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SI2P153CA0004.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::23) To DM4PR11MB6020.namprd11.prod.outlook.com (2603:10b6:8:61::19) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR11MB6020:EE_|CY8PR11MB7847:EE_ X-MS-Office365-Filtering-Correlation-Id: 52bdabda-ef37-4213-2d79-08dedcf06830 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|23010399003|366016|7416014|4143699003|56012099006|11063799006|22082099003|18002099003|3023799007; X-Microsoft-Antispam-Message-Info: nrUSEpiY8NnwXbMbf8/rGzGBeriQIOem7XECLOioDZT5XhHU3nQ268d3oxZXlpjYiM9ZvFUuSYbMnYYw93iOEtD+E98H7w6n5VnTR2O5vK2un5Zy7LFw4Nkv+EsrJSGm6pJxhcqyPj9kGuyNvy+PWmv1E/i7gUAW942owd468dtQPL+VoRy+FHU4dxjQ11RJZUUI9L9x7cF2JwspS4yFe5xrRwIIagUNVzVO1cZwy4NtvULQ1vBHQqByT3T2RPC9RGaDcxy4rI+S671VSknxh2CVFyJ9wWtdAjoj4mTGhesq67nYklM1W0Q79xLkOHUXqEGg0VOIu4oADoQ39m1zwuBZRhHUOatkqc4Hax+lqZ4npnQaKguINv/FPNMiYUIGhwrERA0tp/yNaWSsZyrFltN01Dztg31F+OpehLZ5IV58GXQFekiMylMeT3bPe9ITlC8kNWCAAPt7ZzAgKSO+/rARvBNmf9fmYE1HYM7RZjVIzAEmL2+V99QJ9Qt9uEggqDKHFNWZBYKnhkUM0U2aIQyHJy5K1z27LmESsvTUDurw7sQZ7O9DBzQCb4nL5isVnsQPSJ/Lg2ozV5tsOZSQe/OVA2v6cl1urbThgRkC5pjD0PHzKtyssoPzJKTDbQBzvlD+wKSw5v1y0jqteUuKhlRo0YQ1DDot4CFcLj8aEjQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB6020.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(23010399003)(366016)(7416014)(4143699003)(56012099006)(11063799006)(22082099003)(18002099003)(3023799007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QjlGWjB6ekd1eFppQVZFVmgyWm4yckNxcXpKZ25WTFg1Vkd1cEk1Q3JkdXl5?= =?utf-8?B?MjBOU3NBK2hSQnMyZ1Ira0trTGg0ZzFKZ1RCMnRYSG5OaVNITytIa0FxQXlm?= =?utf-8?B?a3ZsVy9yTUJpa3ZzS2toSm1IVFRDTXBwRExIU2VGbFhtRkZzRE5GUzdWSTVQ?= =?utf-8?B?cWxMckt5N0lwYkVjZFJaa1FDbVNzckl2OGxFRTJZTVVicVFPUDRDY29uRjNR?= =?utf-8?B?Mm9vbXFLYlM2Ui9ZVHpBSjlVVHRWYzBkNVdYMUxTdklWaDRBcFgzSXE4a25H?= =?utf-8?B?OUxyZlZXU09ZTlErRUk1UjFoS0ZSUDRHOWhMVkg2NmFPdy83SG5uajgwdjE5?= =?utf-8?B?RysrbEZmbWpnNmRxSU90MFpESXJ4RFBQK3hHODEzdXhkcnBlNWdXQTJicjh5?= =?utf-8?B?RmdCR0N2N3l1TEtkQWJOZFU0bERmdTc3QjVVN2FPUkxUOEt0aVM3MFZCd0Vp?= =?utf-8?B?QWxWM2g1VWpLc3MyaUlxajRsQWc2d1NWMnhkc3B6T3hLMGpZM25mZGhpUE1v?= =?utf-8?B?dkVWbjlGNVV0Z1FaZm0weGZxR2VGWUFxaU51eGhBV0xYcTRKS2UyOEhBa2FK?= =?utf-8?B?RHVnejgvYXNwSlpwUFMwOGcxV3lhczk4cGpXL1ZlZXovbnk3L3p6Q3d3bkNH?= =?utf-8?B?VVBITE1lRTZZNTRaREJtdWNBamNPWUtOT1FLTzR2MnphSkh6WWNvTTZaUGIy?= =?utf-8?B?MWpxVVkvV0ovL2RtZEdjRjNseVZzNFpJaXRkWXNCc0dWaXppamlVSGJFSXdp?= =?utf-8?B?Wm1jSklHTFFweGhuamQ0TGFCUC9jWlFxQXdCeEtNTmM5VmxaSjhaZkVkZTlO?= =?utf-8?B?WHNDaDlCblZMUk40ZW1VTXpqNG5CRVZXbUN4TGtiakQ5dCtFUVdjWGhmdnR5?= =?utf-8?B?UllvQkpyWjZ2RG9XMi9WS25iOUppb0xtQmlEVSt6MW9UZWtBMm9uY1pWbFJX?= =?utf-8?B?QmdOMmVFZy9YME0veVo5SGZxS004SEtkRVo0WlRyNEhDTWI3RWZlb3ZWdFB4?= =?utf-8?B?U3dSUmxrdENnMUk0RDlwNUpBNHZTeDlTMlYrTjJqc3NxTWZtbFdOTFVPbDJL?= =?utf-8?B?bGZ4ejZCSndQZ1RsK0F6TVRvQzNQLzF1aDFjcGlpRTQ2WXFOVEs2Uy9QbGJC?= =?utf-8?B?OCtCQ2VzM2tlODI0UnVYNTVjWlU1UnB4bG5ZR25zRS9oL3BCUUpvUnVVeDEw?= =?utf-8?B?MzBkSHAzRitpaTJxSVZRVElaU1Z3ejR5S0F4UzRtc0diTzJhUlhPdFZFWFdx?= =?utf-8?B?a0tOWGNvTkp1Sm1Wb1ZxY3VqSldvUlhQVFpSenp5QkxGQWROZFpHbHFhLzFH?= =?utf-8?B?clNRZjVkbFNJeWNWREo0dFd2S2R1bzVMakpMbG9qSHcvcnZuOTJ0YnJaR2tj?= =?utf-8?B?M2dwVG03MnBJak5VRXVhK3VLQXBpdC82c2w5MC91cWJNeUN0UEZJb0RKNTVZ?= =?utf-8?B?cm1rY1hNd2JibDVjam5aOVFkSy9kNS9rMWJIZ3ZBdEdkSW9HV0hiWFg3ZVFC?= =?utf-8?B?VmQ3dS9SdW8vUWJzNUdJQmw4My9uemZYS29uOVVjZUx1S1RVTnhXa3F2Vjdr?= =?utf-8?B?a29zOTl3d2ZlRG5OcXE2amNyNVRtL2pKQnFURGJ1c0l6OHdmMlErSVJYZDJI?= =?utf-8?B?a2dxbDd1aWJjWWRMR1g5S00zU2NCVkNIQ0gyYkFZdTJNQnUwQ2hGVDc2RGVG?= =?utf-8?B?S013YkY4OC9UbGhrYTFVZ1FWTTlub3kzYzFlM0sxZms1RGFPMjZmUXFsaVZt?= =?utf-8?B?SDI5NDFSTUVTKzNvS1g3NStNUUhaQ0VrcDBJU2hTaHNtQUtkVVk1eXB4aFkx?= =?utf-8?B?bm9EUmFJM3dOS3FFcDhiblZKVzA0WTZQRmhmMlVSU1pRUlRZVE5LUS92NS9Y?= =?utf-8?B?UzN3Mk5HUDBYTnh0ZmRXcVNIZE9EdjIwZDJaWXNlQ3VMdi8vYTFkYUJ3Uy90?= =?utf-8?B?bzZBa0xVZHlPWkRyNlNRSzcyMWl0aU5IYWx3UFM3M1hGZ3NxZ2xhaUpERTJD?= =?utf-8?B?OHRHbTNoYWtvMVdLcHFWK1VMdm4vRjN0eDh6UURUV0lUZC91UWVPdnpRdE9h?= =?utf-8?B?SFZhZ2VJYk9mMlMybTl5ZFZHR1Z4b1VvMmQvUEpuNXRuNDFHVFNnOEV5aXAy?= =?utf-8?B?ZDM3SUppMVZrOXU1RHo5RDNpU2l5ZWkvMXM4eURIQmV3NkRDN24yMnNUK3E0?= =?utf-8?B?bEZCWjNBaEdkOGZ1S1lrM3hIZDZydVNHQ1JYS3VuYUZoZk5aNlZBNkRZRFdy?= =?utf-8?B?bGJFTUIwUHhEUU8xWHM4UnkxTlFwVkYxV29VaW04N3N3YVVUZTlhQ2lRdkRo?= =?utf-8?B?Z0lsNFRMS3drZVMvM1BVcU1qVzNINlZpSURkaTJYWk41eVczTHJOZz09?= X-Exchange-RoutingPolicyChecked: j5+E+JtvZJ1DHmrCDZwPXgEopkgc+KRqFAojbelLrLualj6j/BPczGxrCPYbeC5AyZSEBHX3PBvONKVYNXbVskPh2ABEsIVeA0ev3ANAranDiVWz5PVGziNj2svOZT5ePImvThsInxS0c09IPyts2UC95klSLFGSJQaXqigLoqkLGhQEnw83PCdgDungtouDMOWo/1OxzSoujzhDsN4lLEoj/VL0yOxHjBzMoOLDCVYtrNIxFW7IR4scQPd2a7K9/r0v7LdcBeHvvedgBva0Kl/b9VChaoBcaLEc27lSoOG1ornPVQYJAthQ8qlNzABGKefscHIgQffuNxsTTdCHXg== X-MS-Exchange-CrossTenant-Network-Message-Id: 52bdabda-ef37-4213-2d79-08dedcf06830 X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6020.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2026 12:57:03.9118 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PRMAiDcfy6hoeXSjVbAtv9e2ZtBNqPf5lMTkE521TU9b3MhkwigLU2COZvCdG1i4ex3pXxNJOS0Ux441SX3HZg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7847 X-OriginatorOrg: intel.com Hi Reinette, On 6/5/2026 5:42 AM, Reinette Chatre wrote: > Hi Tony, > > On 6/3/26 11:46 AM, Luck, Tony wrote: >> Reinette, >> >> Tiny bug in "mpam,x86,fs/resctrl: Transition resource control to a list" >> >>> /* >>> * Return length needed to display longest control suffix. >>> * Add 1 for the "_" character when control name exists. >>> */ >>> size_t resctrl_resource_ctrl_max_len(struct rdt_resource *r) >>> { >>> struct resctrl_ctrl *ctrl; >>> size_t total = 0; >>> size_t len; >>> >>> for_each_resource_ctrl(ctrl,r) { >>> len = strlen(resctrl_ctrl_name_str(ctrl->name)); >>> if (len) >>> total += 1 + len; >> >> Should be: >> >> total = max(total, 1 + len); > > Thank you very much. I squashed this locally. > A minor alignment schemata issue is found when testing region-aware RDT: [resctrl]# cat schemata MB:0=100 MB_REGION0_OPT:0=255 MB_REGION0_MIN:0=255 MB_REGION0_MAX:0=255 MB_REGION1_OPT:0=255 MB_REGION1_MIN:0=255 MB_REGION1_MAX:0=255 L2:0=ffff;2=ffff;4=ffff L3:0=3ff The schemata file right-justified only the resource name in a max_name_width field, then printed the control suffix afterwards without padding. Since max_name_width reserves space for name plus suffix, this left a run of spaces before every line. A small hacky fix: diff --git a/fs/resctrl/ctrlmondata.c b/fs/resctrl/ctrlmondata.c index 9b51464b66b7..7d517f3457bf 100644 --- a/fs/resctrl/ctrlmondata.c +++ b/fs/resctrl/ctrlmondata.c @@ -521,6 +521,7 @@ ssize_t rdtgroup_schemata_write(struct kernfs_open_file *of, static void show_doms(struct seq_file *s, struct rdt_resource_final *f, bool print_ctrl, int closid, struct resctrl_ctrl *ctrl) { + char name[20]; struct rdt_resource *r = f->res; struct rdt_ctrl_domain *dom; bool sep = false; @@ -529,11 +530,13 @@ static void show_doms(struct seq_file *s, struct rdt_resource_final *f, /* Walking r->domains, ensure it can't race with cpuhp */ lockdep_assert_cpus_held(); - if (print_ctrl) - seq_printf(s, "%*s%s%s:", max_name_width, f->name, - resctrl_ctrl_is_default(ctrl) ? "" : "_", - resctrl_ctrl_is_default(ctrl) ? - "" : resctrl_ctrl_name_str(ctrl->name)); + if (print_ctrl) { + snprintf(name, sizeof(name), "%s%s%s", f->name, + resctrl_ctrl_is_default(ctrl) ? "" : "_", + resctrl_ctrl_is_default(ctrl) ? + "" : resctrl_ctrl_name_str(ctrl->name)); + seq_printf(s, "%*s:", max_name_width, name); + } list_for_each_entry(dom, &ctrl->domains, hdr.list) { if (sep) seq_puts(s, ";"); diff --git a/fs/resctrl/rdtgroup.c b/fs/resctrl/rdtgroup.c index c1aac0dcd332..916bf6a8eab4 100644 --- a/fs/resctrl/rdtgroup.c +++ b/fs/resctrl/rdtgroup.c @@ -1654,6 +1654,7 @@ static int rdtgroup_size_show(struct kernfs_open_file *of, struct rdtgroup *rdtgrp; struct rdt_resource *r; unsigned int size; + char name[20]; u32 ctrl_val; int ret = 0; u32 closid; @@ -1693,11 +1694,11 @@ static int rdtgroup_size_show(struct kernfs_open_file *of, type = f->conf_type; for_each_resource_ctrl(ctrl, r) { sep = false; - seq_printf(s, "%*s", max_name_width, f->name); - if (!resctrl_ctrl_is_default(ctrl)) - seq_printf(s, "_%s:", resctrl_ctrl_name_str(ctrl->name)); - else - seq_putc(s, ':'); + snprintf(name, sizeof(name), "%s%s%s", f->name, + resctrl_ctrl_is_default(ctrl) ? "" : "_", + resctrl_ctrl_is_default(ctrl) ? + "" : resctrl_ctrl_name_str(ctrl->name)); + seq_printf(s, "%*s:", max_name_width, name); list_for_each_entry(d, &ctrl->domains, hdr.list) { if (sep) seq_putc(s, ';'); And it becomes: [ resctrl]# cat schemata MB:0=100 MB_REGION0_OPT:0=255 MB_REGION0_MIN:0=255 MB_REGION0_MAX:0=255 MB_REGION1_OPT:0=255 MB_REGION1_MIN:0=255 MB_REGION1_MAX:0=255 L2:0=ffff;2=ffff;4=ffff L3:0=3ff thanks, Chenyu