From: Perry Yuan <perry979106@gmail.com>
To: Randy Dunlap <rdunlap@infradead.org>,
Perry Yuan <Perry.Yuan@dell.com>,
oder_chiou@realtek.com, perex@perex.cz, tiwai@suse.com,
hdegoede@redhat.com, mgross@linux.intel.com
Cc: lgirdwood@gmail.com, broonie@kernel.org,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org, Mario.Limonciello@dell.com
Subject: Re: [PATCH v3 1/3] platform/x86: dell-privacy: Add support for Dell hardware privacy
Date: Sun, 14 Feb 2021 15:23:46 +0800 [thread overview]
Message-ID: <68bd09cd-2bdb-2c4e-f38d-a28a7fb0cb48@gmail.com> (raw)
In-Reply-To: <cc83351b-a19a-9a3e-d511-4553cf4d7ef0@infradead.org>
Hi Randy.
On 2021/1/13 1:39, Randy Dunlap wrote:
> On 1/12/21 9:17 AM, Perry Yuan wrote:
>> +config DELL_PRIVACY
>> + tristate "Dell Hardware Privacy Support"
>> + depends on ACPI
>> + depends on ACPI_WMI
>> + depends on INPUT
>> + depends on DELL_LAPTOP
>> + depends on LEDS_TRIGGER_AUDIO
>> + select DELL_WMI
>> + help
>> + This driver provides support for the "Dell Hardware Privacy" feature
>> + of Dell laptops.
>> + Support for a micmute and camera mute privacy will be provided as
>> + hardware button Ctrl+F4 and Ctrl+F9 hotkey
>
> End above with a period '.' please.
>
>> +
>> + To compile this driver as a module, choose M here: the module will
>> + be called dell_privacy.
>
> Please follow coding-style for Kconfig files:
>
> from Documentation/process/coding-style.rst, section 10):
>
> For all of the Kconfig* configuration files throughout the source tree,
> the indentation is somewhat different. Lines under a ``config`` definition
> are indented with one tab, while help text is indented an additional two
> spaces.
>
>
> thanks.
>
Thank you for the review.
Format checked again and will be updated in V4.
next prev parent reply other threads:[~2021-02-14 7:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 17:17 [PATCH v3 1/3] platform/x86: dell-privacy: Add support for Dell hardware privacy Perry Yuan
2021-01-12 17:39 ` Randy Dunlap
2021-01-16 15:10 ` Perry Yuan
2021-02-14 7:23 ` Perry Yuan [this message]
2021-01-12 19:00 ` Pierre-Louis Bossart
2021-02-16 6:48 ` Perry Yuan
2021-02-16 14:56 ` Pierre-Louis Bossart
2021-02-17 12:47 ` Perry Yuan
2021-02-17 14:23 ` Pierre-Louis Bossart
2021-03-05 2:56 ` Yuan, Perry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68bd09cd-2bdb-2c4e-f38d-a28a7fb0cb48@gmail.com \
--to=perry979106@gmail.com \
--cc=Mario.Limonciello@dell.com \
--cc=Perry.Yuan@dell.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=hdegoede@redhat.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgross@linux.intel.com \
--cc=oder_chiou@realtek.com \
--cc=perex@perex.cz \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox