From: Markus Elfring <Markus.Elfring@web.de>
To: "Felix Gu" <ustc.gu@gmail.com>,
linux-pci@vger.kernel.org, "Bjorn Helgaas" <bhelgaas@google.com>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Senchuan Zhang" <zhangsenchuan@eswincomputing.com>,
"Yanghui Ou" <ouyanghui@eswincomputing.com>,
"Yu Ning" <ningyu@eswincomputing.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] PCI: eswin: Fix resource leak on dw_pcie_host_init() failure
Date: Fri, 17 Apr 2026 10:02:11 +0200 [thread overview]
Message-ID: <68c9f7fe-8bbd-49fc-b9f5-407e62dbba63@web.de> (raw)
In-Reply-To: <20260416-eswin-v1-1-a4991725b5ca@gmail.com>
> When dw_pcie_host_init() fails, the code jumps to err_init which
> only calls pm_runtime_put() but skips the clean up of port resources.
Thus use an other label?
See also:
* https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v7.0#n94
* https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/stable-kernel-rules.rst?h=v7.0#n34
Regards,
Markus
next prev parent reply other threads:[~2026-04-17 8:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-16 12:30 [PATCH] PCI: eswin: Fix resource leak on dw_pcie_host_init() failure Felix Gu
2026-04-17 8:02 ` Markus Elfring [this message]
2026-04-17 8:49 ` zhangsenchuan
2026-04-17 9:34 ` Manivannan Sadhasivam
2026-04-17 10:14 ` Felix Gu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68c9f7fe-8bbd-49fc-b9f5-407e62dbba63@web.de \
--to=markus.elfring@web.de \
--cc=bhelgaas@google.com \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=ningyu@eswincomputing.com \
--cc=ouyanghui@eswincomputing.com \
--cc=robh@kernel.org \
--cc=ustc.gu@gmail.com \
--cc=zhangsenchuan@eswincomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox