From: Krzysztof Kozlowski <krzk@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Saalim Quadri <danascape@gmail.com>,
lgirdwood@gmail.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, daniel.baluta@nxp.com,
patches@opensource.cirrus.com, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: dt-bindings: wm8523: Convert to dtschema
Date: Fri, 7 Apr 2023 08:43:30 +0200 [thread overview]
Message-ID: <68d22a80-663c-104a-c51c-496fa1a29d00@kernel.org> (raw)
In-Reply-To: <2c32b1e0-20f7-4d9f-9dbc-8725562e456e@sirena.org.uk>
On 06/04/2023 22:26, Mark Brown wrote:
> On Thu, Apr 06, 2023 at 07:38:19PM +0200, Krzysztof Kozlowski wrote:
>
>> Please squash all your three WM bindings (wm8711, wm8580 and wm8523)
>> into one binding, if they are the same. Probably other WM from your
>> previous submissions as well. We really do not need binding per each of
>> this simple codecs. If they ever need to grow, then we can split them.
>
> At a minimum all of these devices should have separate regulator
> specifications should they ever grow regulator support (and ideally
> would have regulators specified in the binding from the get go).
Good point. The bindings are incomplete that's why they look so similar.
Therefore maybe we should not merge them, just like we do not add
non-trivial-devices to trivial-devices schema, just because device is
incomplete.
> There's also no reason to restrict simple CODECs to a particular
> manufacturer...
True, we could extend it to other brands.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-04-07 6:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-05 20:34 [PATCH] ASoC: dt-bindings: wm8523: Convert to dtschema Saalim Quadri
2023-04-06 17:38 ` Krzysztof Kozlowski
2023-04-06 20:26 ` Mark Brown
2023-04-06 22:11 ` Saalim Quadri
2023-04-07 6:43 ` Krzysztof Kozlowski [this message]
2023-04-06 22:10 ` Saalim Quadri
2023-04-11 17:33 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68d22a80-663c-104a-c51c-496fa1a29d00@kernel.org \
--to=krzk@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=danascape@gmail.com \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox