From: <dan.j.williams@intel.com>
To: "Koralahalli Channabasappa, Smita" <skoralah@amd.com>,
<dan.j.williams@intel.com>,
Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>,
<linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<nvdimm@lists.linux.dev>, <linux-fsdevel@vger.kernel.org>,
<linux-pm@vger.kernel.org>
Cc: Davidlohr Bueso <dave@stgolabs.net>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
Dave Jiang <dave.jiang@intel.com>,
"Alison Schofield" <alison.schofield@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
Matthew Wilcox <willy@infradead.org>, Jan Kara <jack@suse.cz>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Len Brown <len.brown@intel.com>, Pavel Machek <pavel@kernel.org>,
Li Ming <ming.li@zohomail.com>,
Jeff Johnson <jeff.johnson@oss.qualcomm.com>,
Ying Huang <huang.ying.caritas@gmail.com>,
Yao Xingtao <yaoxt.fnst@fujitsu.com>,
Peter Zijlstra <peterz@infradead.org>,
Greg KH <gregkh@linuxfoundation.org>,
Nathan Fontenot <nathan.fontenot@amd.com>,
Terry Bowman <terry.bowman@amd.com>,
"Robert Richter" <rrichter@amd.com>,
Benjamin Cheatham <benjamin.cheatham@amd.com>,
PradeepVineshReddy Kodamati <PradeepVineshReddy.Kodamati@amd.com>,
Zhijian Li <lizhijian@fujitsu.com>, <ardb@kernel.org>,
<bp@alien8.de>
Subject: Re: [PATCH 1/6] dax/hmem, e820, resource: Defer Soft Reserved registration until hmem is ready
Date: Thu, 25 Sep 2025 11:17:43 -0700 [thread overview]
Message-ID: <68d587474b76c_10520100df@dwillia2-mobl4.notmuch> (raw)
In-Reply-To: <d3e696c4-1ffa-47f0-baee-cb1bb4296332@amd.com>
Koralahalli Channabasappa, Smita wrote:
> On 9/8/2025 4:01 PM, dan.j.williams@intel.com wrote:
> > [ add Boris and Ard ]
> >
> > Ard, Boris, can you have a look at the touches to early e820/x86 init
> > (insert_resource_late()) and give an ack (or nak). The general problem
> > here is conflicts between e820 memory resources and CXL subsystem memory
> > resources.
> >
> > Smita Koralahalli wrote:
> >> Insert Soft Reserved memory into a dedicated soft_reserve_resource tree
> >> instead of the iomem_resource tree at boot.
> >>
> >> Publishing Soft Reserved ranges into iomem too early causes conflicts with
> >> CXL hotplug and region assembly failure, especially when Soft Reserved
> >> overlaps CXL regions.
> >>
> >> Re-inserting these ranges into iomem will be handled in follow-up patches,
> >> after ensuring CXL window publication ordering is stabilized and when the
> >> dax_hmem is ready to consume them.
> >>
> >> This avoids trimming or deleting resources later and provides a cleaner
> >> handoff between EFI-defined memory and CXL resource management.
> >>
> >> Signed-off-by: Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
> >
> >
> >> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> >
> > Smita, if you added changes this should have Co-developed-by. Otherwise
> > plain Signed-off-by is interpreted as only chain of custody. Any other
> > patches that you add my Signed-off-by to should also have
> > Co-developed-by or be From: me.
> >
> > Alternatively if you completely rewritel a patch with your own approach
> > then note the source (with a Link:) and leave off the original SOB.
> >
> > Lastly, in this case it looks unmodified from what I wrote? Then it
> > should be:
> >
> > From: Dan Williams <dan.j.williams@intel.com>
> >
> > Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> > Signed-off-by: Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
> >
> > ...to show the chain of custody of you forwarding a diff authored
> > completely by someone else.
>
> Thanks for clarifying, Dan. I wasn’t aware of the distinction before
> (especially to handle the chain of custody..). I will update to reflect
> that properly and will also be careful with how I handle authorship and
> sign-offs in future submissions.
Yeah, the choice to replace From: is subjective and I usually reserve
that for significant rewrites. If any of the original patch remains then
add Co-developed-by + Signed-off-by. If none of the original patch
remains I do still like to say:
"based on an original patch by ..." with a Link: to that inspiration
patch.
...and if you just forward the original, keep From: untouched and just
add your own Signed-off-by as documented in
Documentation/process/submitting-patches.rst.
next prev parent reply other threads:[~2025-09-25 18:17 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-22 3:41 [PATCH 0/6] dax/hmem, cxl: Coordinate Soft Reserved handling with CXL Smita Koralahalli
2025-08-22 3:41 ` [PATCH 1/6] dax/hmem, e820, resource: Defer Soft Reserved registration until hmem is ready Smita Koralahalli
2025-09-01 2:59 ` Zhijian Li (Fujitsu)
2025-09-30 4:01 ` Koralahalli Channabasappa, Smita
2025-09-08 23:01 ` dan.j.williams
2025-09-11 19:39 ` Koralahalli Channabasappa, Smita
2025-09-25 18:17 ` dan.j.williams [this message]
2025-09-09 16:12 ` Borislav Petkov
2025-09-30 4:56 ` Koralahalli Channabasappa, Smita
2025-12-18 17:52 ` dan.j.williams
2026-01-13 18:29 ` dan.j.williams
2025-08-22 3:41 ` [PATCH 2/6] dax/hmem: Request cxl_acpi and cxl_pci before walking Soft Reserved ranges Smita Koralahalli
2025-09-01 3:08 ` Zhijian Li (Fujitsu)
2025-09-04 17:35 ` Dave Jiang
2025-08-22 3:41 ` [PATCH 3/6] dax/hmem, cxl: Tighten dependencies on DEV_DAX_CXL and dax_hmem Smita Koralahalli
2025-09-01 3:28 ` Zhijian Li (Fujitsu)
2025-09-30 4:04 ` Koralahalli Channabasappa, Smita
2025-08-22 3:42 ` [PATCH 4/6] dax/hmem: Defer Soft Reserved overlap handling until CXL region assembly completes Smita Koralahalli
2025-09-01 4:01 ` Zhijian Li (Fujitsu)
2025-08-22 3:42 ` [PATCH 5/6] dax/hmem: Reintroduce Soft Reserved ranges back into the iomem tree Smita Koralahalli
2025-09-04 18:14 ` Dave Jiang
2025-09-10 13:41 ` Jonathan Cameron
2025-09-30 4:03 ` Koralahalli Channabasappa, Smita
2025-08-22 3:42 ` [RFC PATCH 6/6] cxl/region, dax/hmem: Guard CXL DAX region creation and tighten HMEM deps Smita Koralahalli
2025-09-01 6:21 ` Zhijian Li (Fujitsu)
2025-09-30 4:06 ` Koralahalli Channabasappa, Smita
2025-08-26 23:21 ` [PATCH 0/6] dax/hmem, cxl: Coordinate Soft Reserved handling with CXL Alison Schofield
2025-08-28 23:34 ` Koralahalli Channabasappa, Smita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68d587474b76c_10520100df@dwillia2-mobl4.notmuch \
--to=dan.j.williams@intel.com \
--cc=PradeepVineshReddy.Kodamati@amd.com \
--cc=Smita.KoralahalliChannabasappa@amd.com \
--cc=alison.schofield@intel.com \
--cc=ardb@kernel.org \
--cc=benjamin.cheatham@amd.com \
--cc=bp@alien8.de \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=gregkh@linuxfoundation.org \
--cc=huang.ying.caritas@gmail.com \
--cc=ira.weiny@intel.com \
--cc=jack@suse.cz \
--cc=jeff.johnson@oss.qualcomm.com \
--cc=jonathan.cameron@huawei.com \
--cc=len.brown@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lizhijian@fujitsu.com \
--cc=ming.li@zohomail.com \
--cc=nathan.fontenot@amd.com \
--cc=nvdimm@lists.linux.dev \
--cc=pavel@kernel.org \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=rrichter@amd.com \
--cc=skoralah@amd.com \
--cc=terry.bowman@amd.com \
--cc=vishal.l.verma@intel.com \
--cc=willy@infradead.org \
--cc=yaoxt.fnst@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox