From: Matthieu Baerts <matttbe@kernel.org>
To: Maxim Galaganov <max@internet.ru>,
Naresh Kamboju <naresh.kamboju@linaro.org>
Cc: Linux Kernel Functional Testing <lkft@linaro.org>,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Shuah Khan <shuah@kernel.org>,
Mat Martineau <martineau@kernel.org>
Subject: Re: [PATCH net] selftests: net: ip_local_port_range: define IPPROTO_MPTCP
Date: Fri, 9 Feb 2024 14:57:13 +0100 [thread overview]
Message-ID: <68d61c24-b6d3-450a-8976-e87beb9b54e3@kernel.org> (raw)
In-Reply-To: <20240209132512.254520-1-max@internet.ru>
Hi Maxim, Naresh,
On 09/02/2024 14:25, Maxim Galaganov wrote:
> Older glibc's netinet/in.h may leave IPPROTO_MPTCP undefined when
> building ip_local_port_range.c, that leads to "error: use of undeclared
> identifier 'IPPROTO_MPTCP'".
>
> Define IPPROTO_MPTCP in such cases, just like in other MPTCP selftests.
>
> Fixes: 122db5e3634b ("selftests/net: add MPTCP coverage for IP_LOCAL_PORT_RANGE")
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> Closes: https://lore.kernel.org/netdev/CA+G9fYvGO5q4o_Td_kyQgYieXWKw6ktMa-Q0sBu6S-0y3w2aEQ@mail.gmail.com/
> Signed-off-by: Maxim Galaganov <max@internet.ru>
Thank you both for the fix and the bug report!
Acked-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
next prev parent reply other threads:[~2024-02-09 13:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-09 13:25 [PATCH net] selftests: net: ip_local_port_range: define IPPROTO_MPTCP Maxim Galaganov
2024-02-09 13:57 ` Matthieu Baerts [this message]
2024-02-12 18:39 ` Naresh Kamboju
2024-02-13 1:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68d61c24-b6d3-450a-8976-e87beb9b54e3@kernel.org \
--to=matttbe@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lkft@linaro.org \
--cc=martineau@kernel.org \
--cc=max@internet.ru \
--cc=naresh.kamboju@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox