From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FC333A16BC for ; Tue, 12 May 2026 08:56:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778576191; cv=none; b=o5Pii/NSy0sXFNUGgsONHMDnl702pDEIdnjzp8yneMBeMhtS8CYj1VgpM/IATVBzyieh5xXz2XsUoab6ZX3Vl+zU6ALHNwBC00mjaT3P7xSZv9OidQrFUYA/gSOS54LJ4apJNu9P1Lh3QdoPwkjIxte7+8t6YJ4rBYIHUGjWatA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778576191; c=relaxed/simple; bh=lVMwC1V5ByzC5YxGojjAZqoYBJ1DbnrMHPhYH2hoMro=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=b+un/Vl0KVwfgtmILqGkQVZ/pUIxTI4jC+ORb2OTm9O54p3y7AR/TnC4px5xZ1k/YA7hVHMh1dXabaOCbiCACBDDDxugpKKJp222DSMfab3+HNZN3WRE239/lwhlwWDAlkNQnQM0hZ13dv6c9PVNrb+M2smnVs2y14+PVfZgDls= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Uqz2/b/k; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=oABKDu10; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Uqz2/b/k"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="oABKDu10" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778576182; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gkWWhDNAFlws8ghp7HprrN6Kh7iuwdnJHBkxYwkQhoI=; b=Uqz2/b/kaNsI/rBVWjehVWBSsPUwlXMkr02GhHc+FLVSbWJyM+EIMINJi00r2UWk7jr5ix rvfP4QTljbqaMfhLeP5Rgg1cuKz84kMbEnvOi4mQbKOiQdJJeftJeweR0ZWzi4uDyuERij L+yu0B29EKeuaNqYuzVxWkZ/NCwxNLg= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-512-yA3qralpO0auWNrj_Qrbvw-1; Tue, 12 May 2026 04:56:20 -0400 X-MC-Unique: yA3qralpO0auWNrj_Qrbvw-1 X-Mimecast-MFC-AGG-ID: yA3qralpO0auWNrj_Qrbvw_1778576180 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-48e6af7a9cdso25733385e9.3 for ; Tue, 12 May 2026 01:56:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1778576179; x=1779180979; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gkWWhDNAFlws8ghp7HprrN6Kh7iuwdnJHBkxYwkQhoI=; b=oABKDu10ErJnGkAQrUqCPq6h2GgJFHRZ76/h2KaNkhIiJAm+dA5k/MbjFpy04YZgFh SEwj7Wb0ctLVwXqu5i7Tq09uYEhlNIP2YQLfHSwoy4a+rzttwFTjU3bicLaBgPVLWU58 dUZEgYDwQBi9dt8EIBq3ft3jRj7qxqz5PggFipmG91to3pZjyUbix7HnflJPCZoj97jo 4YRoemJZVfia/VgLeNlgQX7w0r/AxqrFNROYDtNr/WpqKbJnWMGujbbQcGR40psPVfcI UuUZxEW5zAp/MSIURn3j0q2SNz86GQV/UiV5XHWGIhykY2Pg7KxwsqwVPwyRqT8/oOes f6RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778576179; x=1779180979; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gkWWhDNAFlws8ghp7HprrN6Kh7iuwdnJHBkxYwkQhoI=; b=bOAFko66T1xdvZtML4xVkH9lRoBNReLD01Ty2+9smb1Q9mf922bS4inPYulf9rx84c h8WsEGT3HV9RrhuLfuL7pB/9Tfiq3c/rTEF6SxjSo89ho/xnUBNiCtcfM+urSxBLj2JP nR5Y4ybz3qzc7bD5YT6AaaKO5UyB9qExAGCCQ+jgvHxv+f3wROQ3EYNYO5FxOP1/5M33 E9uuxaF6iiq3vhHTgDpvGtBMfV9XU6hpejZ9743bpUAaAFudhw86B85xcGBfXqizU5ji Jn1PpCBMj5bdSOAqtk/bpwKbQ8kS/48LvpLEDozkc4tMXHico6kqQwL+d79FDalZ2nr2 AWXw== X-Forwarded-Encrypted: i=1; AFNElJ8lQChNhY0zlVsfd4hAggwwtfHde3n9lYO8CTs0PVIC36HXjR05w7Ru4MEnEA3vuULT/vijAeiVXwYYqOc=@vger.kernel.org X-Gm-Message-State: AOJu0Yxn3XC0YNvdxYFitWMElgHH6fhfp4uZ/6RnuTNUkLrChFVpx0NH HAaxnDFKWTNyxAvxXYTLs4QZp386pe4VEtVZZnL1ny6Sl7ci3TOKW5gnWwKDxUuR/w/DJWQSwl6 ldoCWP6VxiBfkIX/WBKUPt3dojspWKcNIJGHYz/eHNa+eeuMz8VM3nbjJ8T/tZtv8Fg== X-Gm-Gg: Acq92OEb0tx0S3dAnVoyY7HqsSu6SlM/Wo9R6l6tvoE9pkE+f0QRPQ2TJH3LPKswbaR 92ebgZErSl07/dffe8/70yx9eUSx0n6m02MO+FHKgv4fpOLhRJuSmqlbG4UyD81EH5dsUUTucUK Ze5Ieayot1+VFQDwkLnIvq3ArT6W7p8X8DHTfuPTI/a1tbNyCSIOyGeLCEA5eAMuw9qgR0XVfMy biJs61M/2XGm2b6uVc9xf17EvfQAnEcXlaREzswMxLt2znskFBxY3KCcH1QCdgpOiVVgeIEDtN8 YgRnswSLPjwghLOGR/ea3wT3BHj4YKk7FbtHIc685MrcrcxpD+V/jwHV7AU/P935oL9gaXd8pPm eJq1Kz2gFouA6HpsWQVheH1wReey/qvUbL1HpTa3Qg5+gyTwXwbUvQDU= X-Received: by 2002:a05:600c:c058:b0:48a:599a:3716 with SMTP id 5b1f17b1804b1-48e8fe7fa6fmr21523825e9.23.1778576179601; Tue, 12 May 2026 01:56:19 -0700 (PDT) X-Received: by 2002:a05:600c:c058:b0:48a:599a:3716 with SMTP id 5b1f17b1804b1-48e8fe7fa6fmr21523595e9.23.1778576179172; Tue, 12 May 2026 01:56:19 -0700 (PDT) Received: from [192.168.88.32] ([216.128.9.106]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e90536122sm33619495e9.4.2026.05.12.01.56.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 May 2026 01:56:18 -0700 (PDT) Message-ID: <68e44a69-aeef-4681-8155-7e65e2eb5629@redhat.com> Date: Tue, 12 May 2026 10:56:17 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v3 2/2] net: dsa: yt921x: Add port TBF support To: David Yang , netdev@vger.kernel.org Cc: Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Jamal Hadi Salim , Jiri Pirko , Simon Horman , linux-kernel@vger.kernel.org References: <20260508065757.2566258-1-mmyangfl@gmail.com> <20260508065757.2566258-3-mmyangfl@gmail.com> From: Paolo Abeni Content-Language: en-US In-Reply-To: <20260508065757.2566258-3-mmyangfl@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/8/26 8:57 AM, David Yang wrote: > @@ -1378,6 +1390,70 @@ yt921x_dsa_port_policer_add(struct dsa_switch *ds, int port, > return res; > } > > +static int > +yt921x_dsa_port_setup_tc_tbf_port(struct dsa_switch *ds, int port, > + const struct tc_tbf_qopt_offload *qopt) > +{ > + struct yt921x_priv *priv = to_yt921x_priv(ds); > + struct netlink_ext_ack *extack = qopt->extack; > + u32 ctrls[2]; > + int res; > + > + if (qopt->parent != TC_H_ROOT) > + return -EOPNOTSUPP; > + > + switch (qopt->command) { > + case TC_TBF_STATS: > + return 0; The above makes the stats actually not supported; it should return -NOPNOTSUPP. /P