From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756106AbdETObY (ORCPT ); Sat, 20 May 2017 10:31:24 -0400 Received: from mout.web.de ([212.227.17.11]:58270 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755977AbdETObW (ORCPT ); Sat, 20 May 2017 10:31:22 -0400 Subject: [PATCH 1/2] vhost/scsi: Improve a size determination in four functions From: SF Markus Elfring To: kvm@vger.kernel.org, netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, Jason Wang , "Michael S. Tsirkin" Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: <68e78c4b-9b18-7607-f8c8-327fdd51f20b@users.sourceforge.net> Date: Sat, 20 May 2017 16:31:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:NFGmy1JG0x70WoaGHBVJpIqLpNatT68soXxui0ZyaQbu9AYWv94 xTXIbuAT8/Hfg32gur+sDBfLlrFEOi6wEgqUmPkEMpPzWi2D8rDG3vTTSDQ/dCp+e38Qk+R 8mUdGcz/i7uLuuRH4gWq2L1Nwhh+bsmOQLaTWwTntKnB4zoSATUEqRpU5hj4HfSQMpsHuoS 4GD85LoIYhHABj1FzFv3A== X-UI-Out-Filterresults: notjunk:1;V01:K0:meSbA6ixvfI=:bpeKScjDonsuYktmDoeadR FSY66W4tGqw/PBrRCy3+NfvN4ZGhPl2RXJyUj5z4Mmb3i9r1wQVkB6bD+QpO1Li/duv3jVqvd akH2GJOHmiUrXydiTIfNR1gkxC7n0Kb8fFcpHWSKXcqv7u4OcAQdzNyzCTqJhoTwL9u0CZ6yX BzDRcT1564SoRFS4gi0za4JfwNSEMa5CWuWmvNYhsWeHwQM73xk6P7Y4S/UVRsmhpugdlAhtH LVjGiNEwj1eigSO0jzHulUyWl7IIxSvThBRpn0mZ6iyW/WD2G3z1HiIxacmNWkXAtd2Gh7aLk zqaP+mRkAcvHgQ8sS8RFWWT9uNzq+jyRl2SgIQ9OxtggzZpLZpabXPSHW45gmmP+fFRynYGrN Q6ThvUzleBmUttyLj+rTYLoxlAR1pGGpLubStLjFcCNyMVTg7jWOH+O3LBZhoWzqadjAalk/y QLsTWtM12fCig3XLrde8izMibEYjaDOGQXNuiN9cpdsDPDtJhTDNJdex1RZYAPgAqvNRHaC59 qQt6Gi3Me853wjsCB611ZXka3HFQBsY45egaEcKFd+Sga80tJvqBzF/oQpcSGZzE4tp0VkiBH bY27xSltlB4M2IcdmJfxJ9oXBNZXOKjaT7OzQLwHpD0Lf1Sy/gFPJIb0hX19vTJ7Fxngt0FVt 7hQ/cVqyWMA3DC0mDHbRbfwk06YbOixqyLMpWwZ4F6euvFX8pbStT5GltvBO4lzkVHzxdddP/ hpVefCR4cxllDG+p5Id8LwMsLPt8CHFsri5XaILE8DmU0Nv74oOOjnxcF3TIgm/fVPXnbjEeX gw+x0bg Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 20 May 2017 13:48:44 +0200 Replace the specification of four data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/vhost/scsi.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c index fd6c8b66f06f..650533916c19 100644 --- a/drivers/vhost/scsi.c +++ b/drivers/vhost/scsi.c @@ -597,8 +597,7 @@ vhost_scsi_get_tag(struct vhost_virtqueue *vq, struct vhost_scsi_tpg *tpg, sg = cmd->tvc_sgl; prot_sg = cmd->tvc_prot_sgl; pages = cmd->tvc_upages; - memset(cmd, 0, sizeof(struct vhost_scsi_cmd)); - + memset(cmd, 0, sizeof(*cmd)); cmd->tvc_sgl = sg; cmd->tvc_prot_sgl = prot_sg; cmd->tvc_upages = pages; @@ -1757,5 +1756,5 @@ static int vhost_scsi_make_nexus(struct vhost_scsi_tpg *tpg, return -EEXIST; } - tv_nexus = kzalloc(sizeof(struct vhost_scsi_nexus), GFP_KERNEL); + tv_nexus = kzalloc(sizeof(*tv_nexus), GFP_KERNEL); if (!tv_nexus) { @@ -1958,5 +1957,5 @@ vhost_scsi_make_tpg(struct se_wwn *wwn, if (kstrtou16(name + 5, 10, &tpgt) || tpgt >= VHOST_SCSI_MAX_TARGET) return ERR_PTR(-EINVAL); - tpg = kzalloc(sizeof(struct vhost_scsi_tpg), GFP_KERNEL); + tpg = kzalloc(sizeof(*tpg), GFP_KERNEL); if (!tpg) { @@ -2012,5 +2011,5 @@ vhost_scsi_make_tport(struct target_fabric_configfs *tf, /* if (vhost_scsi_parse_wwn(name, &wwpn, 1) < 0) return ERR_PTR(-EINVAL); */ - tport = kzalloc(sizeof(struct vhost_scsi_tport), GFP_KERNEL); + tport = kzalloc(sizeof(*tport), GFP_KERNEL); if (!tport) { -- 2.13.0