[syzbot] [ocfs2?] WARNING in ocfs2_unlink

[syzbot] [ocfs2?] WARNING in ocfs2_unlink

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit:    2144da25584e Merge tag '6.13-rc6-ksmbd-server-fixes' of gi..
git tree:       upstream
console+strace: https://syzkaller.appspot.com/x/log.txt?x=16d91ef8580000
kernel config:  https://syzkaller.appspot.com/x/.config?x=7ac4cd61d548c1ef
dashboard link: https://syzkaller.appspot.com/bug?extid=55c40ae8a0e5f3659f2b
compiler:       Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=13374cb0580000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=11933218580000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/20804efabd09/disk-2144da25.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/40fb8a3e4d97/vmlinux-2144da25.xz
kernel image: https://storage.googleapis.com/syzbot-assets/415035e6e16a/bzImage-2144da25.xz
mounted in repro: https://storage.googleapis.com/syzbot-assets/78980b7ee636/mount_0.gz

Bisection is inconclusive: the issue happens on the oldest tested release.

bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=136ad1df980000
final oops:     https://syzkaller.appspot.com/x/report.txt?x=10ead1df980000
console output: https://syzkaller.appspot.com/x/log.txt?x=176ad1df980000

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+55c40ae8a0e5f3659f2b@syzkaller.appspotmail.com

(syz-executor370,5817,0):ocfs2_delete_inode:1068 ERROR: status = -17
(syz-executor370,5817,1):ocfs2_query_inode_wipe:937 ERROR: Inode 17057 (on-disk 17057) not orphaned! Disk flags  0x1, inode flags 0x0
(syz-executor370,5817,1):ocfs2_delete_inode:1068 ERROR: status = -17
------------[ cut here ]------------
WARNING: CPU: 1 PID: 5817 at fs/inode.c:407 drop_nlink+0xc4/0x110 fs/inode.c:407
Modules linked in:
CPU: 1 UID: 0 PID: 5817 Comm: syz-executor370 Not tainted 6.13.0-rc6-syzkaller-00130-g2144da25584e #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024
RIP: 0010:drop_nlink+0xc4/0x110 fs/inode.c:407
Code: bb 70 07 00 00 be 08 00 00 00 e8 97 37 e7 ff f0 48 ff 83 70 07 00 00 5b 41 5c 41 5e 41 5f 5d c3 cc cc cc cc e8 3d 5c 83 ff 90 <0f> 0b 90 eb 83 44 89 e1 80 e1 07 80 c1 03 38 c1 0f 8c 5c ff ff ff
RSP: 0018:ffffc90003e278f0 EFLAGS: 00010293
RAX: ffffffff821c1793 RBX: 1ffff1100e6a4118 RCX: ffff88802e633c00
RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000
RBP: 0000000000000000 R08: ffffffff821c1713 R09: 1ffff1100e68bfa2
R10: dffffc0000000000 R11: ffffed100e68bfa3 R12: ffff8880735208c0
R13: 1ffff920007c4f34 R14: ffff888073520878 R15: dffffc0000000000
FS:  000055557662e380(0000) GS:ffff8880b8700000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007ffc5bb41ed8 CR3: 0000000079324000 CR4: 00000000003526f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 <TASK>
 ocfs2_unlink+0xf62/0x1c80 fs/ocfs2/namei.c:997
 vfs_unlink+0x365/0x650 fs/namei.c:4523
 do_unlinkat+0x4ae/0x830 fs/namei.c:4587
 __do_sys_unlink fs/namei.c:4635 [inline]
 __se_sys_unlink fs/namei.c:4633 [inline]
 __x64_sys_unlink+0x47/0x50 fs/namei.c:4633
 do_syscall_x64 arch/x86/entry/common.c:52 [inline]
 do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7ff0c24f9cd7
Code: 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 b8 57 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffc5bb42688 EFLAGS: 00000287 ORIG_RAX: 0000000000000057
RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007ff0c24f9cd7
RDX: 00007ffc5bb426b0 RSI: 00007ffc5bb42740 RDI: 00007ffc5bb42740
RBP: 00007ffc5bb42740 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000100 R11: 0000000000000287 R12: 00007ffc5bb43830
R13: 0000555576637700 R14: 431bde82d7b634db R15: 00007ffc5bb448c0
 </TASK>


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
For information about bisection process see: https://goo.gl/tpsmEJ#bisection

If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.

If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup

Re: [syzbot] [ocfs2?] WARNING in ocfs2_unlink

[syzbot]

Hello,

syzbot has tested the proposed patch and the reproducer did not trigger any issue:

Reported-by: syzbot+55c40ae8a0e5f3659f2b@syzkaller.appspotmail.com
Tested-by: syzbot+55c40ae8a0e5f3659f2b@syzkaller.appspotmail.com

Tested on:

commit:         552c5071 Merge tag 'vfio-v6.18-rc3' of https://github...
git tree:       upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=12689b04580000
kernel config:  https://syzkaller.appspot.com/x/.config?x=a1215729170d20fc
dashboard link: https://syzkaller.appspot.com/bug?extid=55c40ae8a0e5f3659f2b
compiler:       Debian clang version 20.1.8 (++20250708063551+0c9f909b7976-1~exp1~20250708183702.136), Debian LLD 20.1.8
patch:          https://syzkaller.appspot.com/x/patch.diff?x=16971b04580000

Note: testing is done by a robot and is best-effort only.

Re: [syzbot] [ocfs2?] WARNING in ocfs2_unlink

[syzbot]

Hello,

syzbot has tested the proposed patch and the reproducer did not trigger any issue:

Reported-by: syzbot+55c40ae8a0e5f3659f2b@syzkaller.appspotmail.com
Tested-by: syzbot+55c40ae8a0e5f3659f2b@syzkaller.appspotmail.com

Tested on:

commit:         43e9ad0c Merge tag 'scsi-fixes' of git://git.kernel.or..
git tree:       upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=14d8c3e2580000
kernel config:  https://syzkaller.appspot.com/x/.config?x=a1215729170d20fc
dashboard link: https://syzkaller.appspot.com/bug?extid=55c40ae8a0e5f3659f2b
compiler:       Debian clang version 20.1.8 (++20250708063551+0c9f909b7976-1~exp1~20250708183702.136), Debian LLD 20.1.8
patch:          https://syzkaller.appspot.com/x/patch.diff?x=16974614580000

Note: testing is done by a robot and is best-effort only.

Re: [syzbot] [ocfs2?] WARNING in ocfs2_unlink

[syzbot]

Hello,

syzbot has tested the proposed patch but the reproducer is still triggering an issue:
possible deadlock in l2cap_conn_del

(syz-executor,6305,1):ocfs2_read_locked_inode:597 ERROR: status = -117
(syz-executor,6305,1):ocfs2_validate_inode_block:1465 ERROR: Invalid dinode #17057: i_mode is zero!
(syz-executor,6305,1):ocfs2_read_locked_inode:597 ERROR: status = -117
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz-executor/6305 is trying to acquire lock:
ffff88802ed7c040 ((work_completion)(&(&conn->info_timer)->work)){+.+.}-{0:0}, at: rcu_lock_acquire include/linux/rcupdate.h:331 [inline]
ffff88802ed7c040 ((work_completion)(&(&conn->info_timer)->work)){+.+.}-{0:0}, at: rcu_read_lock include/linux/rcupdate.h:867 [inline]
ffff88802ed7c040 ((work_completion)(&(&conn->info_timer)->work)){+.+.}-{0:0}, at: start_flush_work kernel/workqueue.c:4179 [inline]
ffff88802ed7c040 ((work_completion)(&(&conn->info_timer)->work)){+.+.}-{0:0}, at: __flush_work+0xd2/0xbc0 kernel/workqueue.c:4237

but task is already holding lock:
ffff88802ed7c338 (&conn->lock#2){+.+.}-{4:4}, at: l2cap_conn_del+0x70/0x680 net/bluetooth/l2cap_core.c:1762

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&conn->lock#2){+.+.}-{4:4}:
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5868
       __mutex_lock_common kernel/locking/mutex.c:598 [inline]
       __mutex_lock+0x17d/0x12e0 kernel/locking/mutex.c:760
       l2cap_info_timeout+0x60/0xa0 net/bluetooth/l2cap_core.c:1668
       process_one_work kernel/workqueue.c:3263 [inline]
       process_scheduled_works+0xa55/0x16b0 kernel/workqueue.c:3346
       worker_thread+0x8a0/0xda0 kernel/workqueue.c:3427
       kthread+0x711/0x8a0 kernel/kthread.c:463
       ret_from_fork+0x4bc/0x870 arch/x86/kernel/process.c:158
       ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:245

-> #0 ((work_completion)(&(&conn->info_timer)->work)){+.+.}-{0:0}:
       check_prev_add kernel/locking/lockdep.c:3165 [inline]
       check_prevs_add kernel/locking/lockdep.c:3284 [inline]
       validate_chain+0xb9b/0x2140 kernel/locking/lockdep.c:3908
       __lock_acquire+0xab9/0xd20 kernel/locking/lockdep.c:5237
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5868
       touch_work_lockdep_map kernel/workqueue.c:3951 [inline]
       start_flush_work kernel/workqueue.c:4205 [inline]
       __flush_work+0x6b8/0xbc0 kernel/workqueue.c:4237
       __cancel_work_sync+0xbe/0x110 kernel/workqueue.c:4393
       l2cap_conn_del+0x4f0/0x680 net/bluetooth/l2cap_core.c:1796
       hci_disconn_cfm include/net/bluetooth/hci_core.h:2121 [inline]
       hci_conn_hash_flush+0x10d/0x230 net/bluetooth/hci_conn.c:2602
       hci_dev_close_sync+0xa0a/0x11b0 net/bluetooth/hci_sync.c:5303
       hci_dev_do_close net/bluetooth/hci_core.c:501 [inline]
       hci_unregister_dev+0x21a/0x510 net/bluetooth/hci_core.c:2715
       vhci_release+0x152/0x1a0 drivers/bluetooth/hci_vhci.c:690
       __fput+0x44c/0xa70 fs/file_table.c:468
       task_work_run+0x1d4/0x260 kernel/task_work.c:227
       exit_task_work include/linux/task_work.h:40 [inline]
       do_exit+0x6b5/0x2300 kernel/exit.c:966
       do_group_exit+0x21c/0x2d0 kernel/exit.c:1107
       __do_sys_exit_group kernel/exit.c:1118 [inline]
       __se_sys_exit_group kernel/exit.c:1116 [inline]
       __x64_sys_exit_group+0x3f/0x40 kernel/exit.c:1116
       x64_sys_call+0x21f7/0x2200 arch/x86/include/generated/asm/syscalls_64.h:232
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xfa/0xfa0 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&conn->lock#2);
                               lock((work_completion)(&(&conn->info_timer)->work));
                               lock(&conn->lock#2);
  lock((work_completion)(&(&conn->info_timer)->work));

 *** DEADLOCK ***

5 locks held by syz-executor/6305:
 #0: ffff888026654dc8 (&hdev->req_lock){+.+.}-{4:4}, at: hci_dev_do_close net/bluetooth/hci_core.c:499 [inline]
 #0: ffff888026654dc8 (&hdev->req_lock){+.+.}-{4:4}, at: hci_unregister_dev+0x212/0x510 net/bluetooth/hci_core.c:2715
 #1: ffff8880266540b8 (&hdev->lock){+.+.}-{4:4}, at: hci_dev_close_sync+0x5b3/0x11b0 net/bluetooth/hci_sync.c:5291
 #2: ffffffff8f1f8ca8 (hci_cb_list_lock){+.+.}-{4:4}, at: hci_disconn_cfm include/net/bluetooth/hci_core.h:2118 [inline]
 #2: ffffffff8f1f8ca8 (hci_cb_list_lock){+.+.}-{4:4}, at: hci_conn_hash_flush+0xa1/0x230 net/bluetooth/hci_conn.c:2602
 #3: ffff88802ed7c338 (&conn->lock#2){+.+.}-{4:4}, at: l2cap_conn_del+0x70/0x680 net/bluetooth/l2cap_core.c:1762
 #4: ffffffff8dd3cc20 (rcu_read_lock){....}-{1:3}, at: rcu_lock_acquire include/linux/rcupdate.h:331 [inline]
 #4: ffffffff8dd3cc20 (rcu_read_lock){....}-{1:3}, at: rcu_read_lock include/linux/rcupdate.h:867 [inline]
 #4: ffffffff8dd3cc20 (rcu_read_lock){....}-{1:3}, at: start_flush_work kernel/workqueue.c:4179 [inline]
 #4: ffffffff8dd3cc20 (rcu_read_lock){....}-{1:3}, at: __flush_work+0xd2/0xbc0 kernel/workqueue.c:4237

stack backtrace:
CPU: 0 UID: 0 PID: 6305 Comm: syz-executor Not tainted syzkaller #0 PREEMPT(full) 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/02/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x189/0x250 lib/dump_stack.c:120
 print_circular_bug+0x2ee/0x310 kernel/locking/lockdep.c:2043
 check_noncircular+0x134/0x160 kernel/locking/lockdep.c:2175
 check_prev_add kernel/locking/lockdep.c:3165 [inline]
 check_prevs_add kernel/locking/lockdep.c:3284 [inline]
 validate_chain+0xb9b/0x2140 kernel/locking/lockdep.c:3908
 __lock_acquire+0xab9/0xd20 kernel/locking/lockdep.c:5237
 lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5868
 touch_work_lockdep_map kernel/workqueue.c:3951 [inline]
 start_flush_work kernel/workqueue.c:4205 [inline]
 __flush_work+0x6b8/0xbc0 kernel/workqueue.c:4237
 __cancel_work_sync+0xbe/0x110 kernel/workqueue.c:4393
 l2cap_conn_del+0x4f0/0x680 net/bluetooth/l2cap_core.c:1796
 hci_disconn_cfm include/net/bluetooth/hci_core.h:2121 [inline]
 hci_conn_hash_flush+0x10d/0x230 net/bluetooth/hci_conn.c:2602
 hci_dev_close_sync+0xa0a/0x11b0 net/bluetooth/hci_sync.c:5303
 hci_dev_do_close net/bluetooth/hci_core.c:501 [inline]
 hci_unregister_dev+0x21a/0x510 net/bluetooth/hci_core.c:2715
 vhci_release+0x152/0x1a0 drivers/bluetooth/hci_vhci.c:690
 __fput+0x44c/0xa70 fs/file_table.c:468
 task_work_run+0x1d4/0x260 kernel/task_work.c:227
 exit_task_work include/linux/task_work.h:40 [inline]
 do_exit+0x6b5/0x2300 kernel/exit.c:966
 do_group_exit+0x21c/0x2d0 kernel/exit.c:1107
 __do_sys_exit_group kernel/exit.c:1118 [inline]
 __se_sys_exit_group kernel/exit.c:1116 [inline]
 __x64_sys_exit_group+0x3f/0x40 kernel/exit.c:1116
 x64_sys_call+0x21f7/0x2200 arch/x86/include/generated/asm/syscalls_64.h:232
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0xfa/0xfa0 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f7814385d29
Code: Unable to access opcode bytes at 0x7f7814385cff.
RSP: 002b:00007ffc212d6318 EFLAGS: 00000246 ORIG_RAX: 00000000000000e7
RAX: ffffffffffffffda RBX: 00007f7814401919 RCX: 00007f7814385d29
RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000001
RBP: 000000000000000d R08: 00007ffc212d40b6 R09: 00007ffc212d75d0
R10: 0000000000000000 R11: 0000000000000246 R12: 00007ffc212d75d0
R13: 00007f78144018f4 R14: 00007ffc212d8690 R15: 0000000000000001
 </TASK>


Tested on:

commit:         6fab32bb MAINTAINERS: add Mark Brown as a linux-next m..
git tree:       upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=178fb734580000
kernel config:  https://syzkaller.appspot.com/x/.config?x=a1215729170d20fc
dashboard link: https://syzkaller.appspot.com/bug?extid=55c40ae8a0e5f3659f2b
compiler:       Debian clang version 20.1.8 (++20250708063551+0c9f909b7976-1~exp1~20250708183702.136), Debian LLD 20.1.8
patch:          https://syzkaller.appspot.com/x/patch.diff?x=1361c614580000

Re: [syzbot] [ocfs2?] WARNING in ocfs2_unlink

[syzbot]

Hello,

syzbot has tested the proposed patch and the reproducer did not trigger any issue:

Reported-by: syzbot+55c40ae8a0e5f3659f2b@syzkaller.appspotmail.com
Tested-by: syzbot+55c40ae8a0e5f3659f2b@syzkaller.appspotmail.com

Tested on:

commit:         6fab32bb MAINTAINERS: add Mark Brown as a linux-next m..
git tree:       upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=12b4ae7c580000
kernel config:  https://syzkaller.appspot.com/x/.config?x=a1215729170d20fc
dashboard link: https://syzkaller.appspot.com/bug?extid=55c40ae8a0e5f3659f2b
compiler:       Debian clang version 20.1.8 (++20250708063551+0c9f909b7976-1~exp1~20250708183702.136), Debian LLD 20.1.8
patch:          https://syzkaller.appspot.com/x/patch.diff?x=16d1c614580000

Note: testing is done by a robot and is best-effort only.

Re: [syzbot] [ocfs2?] WARNING in ocfs2_unlink

[syzbot]

Hello,

syzbot has tested the proposed patch and the reproducer did not trigger any issue:

Reported-by: syzbot+55c40ae8a0e5f3659f2b@syzkaller.appspotmail.com
Tested-by: syzbot+55c40ae8a0e5f3659f2b@syzkaller.appspotmail.com

Tested on:

commit:         566771af Merge tag 'v6.18-rc2-smb-server-fixes' of git..
git tree:       upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=12c65d2f980000
kernel config:  https://syzkaller.appspot.com/x/.config?x=bc5bbbfae7909024
dashboard link: https://syzkaller.appspot.com/bug?extid=55c40ae8a0e5f3659f2b
compiler:       Debian clang version 20.1.8 (++20250708063551+0c9f909b7976-1~exp1~20250708183702.136), Debian LLD 20.1.8
patch:          https://syzkaller.appspot.com/x/patch.diff?x=114d6e7c580000

Note: testing is done by a robot and is best-effort only.

Re: [syzbot] [ocfs2?] WARNING in ocfs2_unlink

[syzbot]

Hello,

syzbot has tested the proposed patch and the reproducer did not trigger any issue:

Reported-by: syzbot+55c40ae8a0e5f3659f2b@syzkaller.appspotmail.com
Tested-by: syzbot+55c40ae8a0e5f3659f2b@syzkaller.appspotmail.com

Tested on:

commit:         e7c375b1 Merge tag 'vfs-6.18-rc7.fixes' of gitolite.ke..
git tree:       upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=12feb884580000
kernel config:  https://syzkaller.appspot.com/x/.config?x=523f33f87ae01010
dashboard link: https://syzkaller.appspot.com/bug?extid=55c40ae8a0e5f3659f2b
compiler:       Debian clang version 20.1.8 (++20250708063551+0c9f909b7976-1~exp1~20250708183702.136), Debian LLD 20.1.8
patch:          https://syzkaller.appspot.com/x/patch.diff?x=114f6212580000

Note: testing is done by a robot and is best-effort only.