From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 089E9350A06 for ; Tue, 11 Nov 2025 11:06:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762859201; cv=none; b=FZYf/FDHMrUzIgDpbbDHPI8g/i1OQrT3tgfPBaa7Hm27j4smU0FkfyACRJT/GHPKavklnmgy4eNTAMwFWxloNL5l9hmFQM7dUmPxq5gngLqFo542TcDzmUKcMUYzYlz5xUBUKygY0/xvba+kzG/zylu5cD+SXWh5lQ9Ni/jzCPo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762859201; c=relaxed/simple; bh=wjKmAWI7i3OKj2wAozsu3qUnx7HDyiUxDn1DPfUHvzk=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZbL/Ra7uNDkwiDEjIPDMBqhucgc8q+SUY5KGw9IXmlXfzWuyJ+tHuvYgjvvC6Zj8gWxV/PwGZy3vpVvKIHIizCWqzODCsLB6bjbmFTPu5iO6P0Xcio7kb72RR0hj55RulEDU2rxcxG5j0SDEDXCh3kQqUunlif8vSqMvdM2nECI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZxwgTHmc; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZxwgTHmc" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4775ae5684fso20719095e9.1 for ; Tue, 11 Nov 2025 03:06:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1762859198; x=1763463998; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:subject:cc:to:from:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=GqeaPnqItnFtRKGsXgxFGwXrKkh4CIZ1QtjFn5LjAOA=; b=ZxwgTHmciUuwxls2DCH5W5AN9wmbMX7MGvOWyOX/c/n1+TSf1Cia+uBicCNxPtF4ju lEbeZcOdExtSV21ae2RHQUpgEno6go1rm6j5DeYWZF8S1NLMKeN+5FUR8u0pXHX2va15 658RzEX14yA/ItojnlTIe74hxRJndrBtXzlT5hbQnceekn9vTR0WMLm803Rm+e2c2p/k bE0vxJa87pFe81zn2s57NH6RZXfyyt38y4YN9IV9B7iSJszEeDFNDZlWjzrfXU4Sa3Ei o6ZjvLbXkBOZKehIJNZ125yFOpgOvWhHJGCKfSriE1ElfsiHclElIlNrG425NAhDDO1P RLiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762859198; x=1763463998; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:subject:cc:to:from:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GqeaPnqItnFtRKGsXgxFGwXrKkh4CIZ1QtjFn5LjAOA=; b=LszkTqlZFGw4UcVBqC9JjOaUz39zTFSh5TPiTpAs2fENUeqttkPJoBRjBHCEqYGE4F ZYymWg7Vfz8tpXcM3KWBWeVgEcvuoLR+I02RDsWY/HR/J2dMXiCEIuqK/6CpwXx9PlZJ VdGAXVxt980+M2Gm/FKQY9XZdK+4I+qMw5POw/79DbwRHOcY+A6edTf2BZVdnZugQLe4 NLEiUA9Pkz+5I9Lx6rGKK64WhrOmkLm9hyYSj7LbnGzKfD5BRRN2XoGwGts4Vwkssx7T ZTLA0B8HFFHYV6+8FJbni8kBN3xhrl7SG2sf0yTILL/x+drO9/ZhkSMIsAt0Mp5kDSVf 6+qw== X-Forwarded-Encrypted: i=1; AJvYcCVK6mcOITP0qJV7uK7++g7FaEMb3H8XRwrEcd942pImVKXL50zrMFwN0HhL7IZGTLRUo0+4xomIgMYGTd0=@vger.kernel.org X-Gm-Message-State: AOJu0YyT256iE/POO2+jlednrasbbCoalO8v5nVAN1k/xP381u/nyoN2 qcYvWfzK1NKAMjB1MY2rxQjdXifJN48+VqbLpIM6TE8XkbsyvvT2rUu6 X-Gm-Gg: ASbGncvyQI3g/lcGki4QUpX/DewNd79mYm71Ha1U4Hh/nAM/oHqBuh0nAA8Xv2MPEBz Wn/GOsGSCkydSaPktjw7hfuZW0NxIxktKXnElCjqIZXDRiSaJkItk+FmYH/E1xzyWQG5z889TyL YgUGJbA88gRHgaE3pouBNlilcJyylfgEWmw+jzCiLMjonj6owpJjhipwaIpze3ZWrAGY7QukXwK Lo0ouBBKwW8ha5IFluzPrOlbtM7mVJWx8SmEzvVACpBheFxcs2cbFDlKbZRiyfPbJFT5UH+f5av DTVxI2C6z+lizF/OPhWEOCrySGf2kS4xVVP+bbr+JtuKGquAFE5KcMTbw32Vk+aEOq75AP94dOp IqWgHlEMJEaa+xzRstESvzqYdnU724FSGHmZy1/LlcHxFnBbM+cIYEGfKVswF7gQw3191kWf3no JT6Ni41AxV6w7WvnpMTifZnh4ab6gs X-Google-Smtp-Source: AGHT+IHo0/ZJIgGnENwBn854yp6ABmQngtssmchs4xiNiUy0O6fPJmQpRDhvemlWrdEyLklYh4J5vg== X-Received: by 2002:a05:600c:6a81:b0:477:429b:3b93 with SMTP id 5b1f17b1804b1-47773263384mr69643045e9.18.1762859198228; Tue, 11 Nov 2025 03:06:38 -0800 (PST) Received: from Ansuel-XPS. (93-34-90-37.ip49.fastwebnet.it. [93.34.90.37]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4776bcfd021sm306780595e9.11.2025.11.11.03.06.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Nov 2025 03:06:37 -0800 (PST) Message-ID: <691318bd.050a0220.855f2.f45f@mx.google.com> X-Google-Original-Message-ID: Date: Tue, 11 Nov 2025 12:06:35 +0100 From: Christian Marangi To: Linus Walleij Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lorenzo Bianconi , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 0/5] pinctrl: airoha: add Airoha AN7583 support References: <20251106235713.1794668-1-ansuelsmth@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Nov 11, 2025 at 12:46:48AM +0100, Linus Walleij wrote: > On Fri, Nov 7, 2025 at 12:57 AM Christian Marangi wrote: > > > This small series introduce support for Airoha AN7583 pinctrl > > support. > > > > Most of the changes are generalization and cleanup of the Airoha > > pinctrl driver. These are needed as all the array in the inner > > function were hardcoded to EN7581 and didn't reference stuff > > from the priv groups. > > > > Everything is changed to match_data and priv struct so > > adding AN7583 is just a matter of adding the structs. > > > > Also the schema is generalized where needed to address > > for the small difference between AN7583 and EN7581. > > All looks good and bindings ACK:ed so patches applied! > > Suggestion: since this driver has: > > 1. Exactly one group per pin > 2. Use some accelerated GPIO operation, .gpio_set_direction > in struct pinmux_ops > > Have you considered implementing the new .function_is_gpio() > callback in struct pinmux_ops to tighten up the GPIO strictness? > Thanks for checking this. No, wasn't aware of the new OP, will check it and send followup hoping it's not too hard to implement. -- Ansuel