From: Stephan Mueller <smueller@chronox.de>
To: "Łukasz Stelmach" <l.stelmach@samsung.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
robh+dt@kernel.org, Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Kukjin Kim <kgene@kernel.org>,
linux-crypto@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-kernel@vger.kernel.org, m.szyprowski@samsung.com,
b.zolnierkie@samsung.com
Subject: Re: [PATCH 3/3] crypto: exynos - Reseed PRNG after generating 2^16 random bytes
Date: Tue, 05 Dec 2017 14:52:31 +0100 [thread overview]
Message-ID: <6915204.SlqusmoAzB@tauon.chronox.de> (raw)
In-Reply-To: <20171205123558.31087-4-l.stelmach@samsung.com>
Am Dienstag, 5. Dezember 2017, 13:35:58 CET schrieb Łukasz Stelmach:
Hi Łukasz,
> Reseed PRNG after reading 65 kB of randomness. Although this may reduce
> performance, in most casese the loss is not noticable.
Please add to the log that you also increase the timer-based reseed to 1
second?!
Another suggestion: maybe you want to add a comment to the reseed function to
indicate it is for enhanced backtracking resistance. Otherwise a lot of folks
would scratch their head why such code exists in the first place. :-)
Other than that:
Reviewed-by: Stephan Mueller <smueller@chronox.de>
Ciao
Stephan
next prev parent reply other threads:[~2017-12-05 13:52 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20171205123601eucas1p2ef1a2fdce84dce8dc4b54c419ce566a7@eucas1p2.samsung.com>
2017-12-05 12:35 ` [PATCH 0/3] Assorted changes for Exynos PRNG driver Łukasz Stelmach
2017-12-05 12:35 ` [PATCH 1/3] crypto: exynos - Support Exynos5250+ SoCs Łukasz Stelmach
2017-12-05 13:34 ` Krzysztof Kozlowski
2017-12-06 13:42 ` Łukasz Stelmach
2017-12-06 14:05 ` Krzysztof Kozlowski
2017-12-06 14:53 ` Łukasz Stelmach
2017-12-06 15:28 ` Krzysztof Kozlowski
2017-12-07 9:20 ` Łukasz Stelmach
2017-12-06 17:56 ` Joe Perches
2017-12-05 12:35 ` [PATCH 2/3] crypto: exynos - Improve performance of PRNG Łukasz Stelmach
2017-12-05 13:49 ` Krzysztof Kozlowski
2017-12-05 13:54 ` Stephan Mueller
2017-12-05 16:43 ` Łukasz Stelmach
2017-12-05 17:53 ` Krzysztof Kozlowski
2017-12-05 18:06 ` Krzysztof Kozlowski
2017-12-06 11:32 ` Łukasz Stelmach
2017-12-06 11:37 ` Krzysztof Kozlowski
2017-12-06 13:06 ` Łukasz Stelmach
2017-12-05 12:35 ` [PATCH 3/3] crypto: exynos - Reseed PRNG after generating 2^16 random bytes Łukasz Stelmach
2017-12-05 13:52 ` Stephan Mueller [this message]
2017-12-05 13:55 ` Krzysztof Kozlowski
2017-12-11 14:06 ` [PATCH v2 0/4] Assorted changes for Exynos PRNG driver Łukasz Stelmach
2017-12-12 16:36 ` [PATCH v3 " Łukasz Stelmach
2017-12-22 9:09 ` Herbert Xu
2017-12-12 16:36 ` [PATCH v3 1/4] crypto: exynos - Support Exynos5250+ SoCs Łukasz Stelmach
2017-12-13 8:06 ` Krzysztof Kozlowski
2017-12-12 16:36 ` [PATCH v3 2/4] crypto: exynos - Improve performance of PRNG Łukasz Stelmach
2017-12-13 8:07 ` Krzysztof Kozlowski
2017-12-12 16:36 ` [PATCH v3 3/4] crypto: exynos - Reseed PRNG after generating 2^16 random bytes Łukasz Stelmach
2017-12-13 8:12 ` Krzysztof Kozlowski
2017-12-12 16:36 ` [PATCH v3 4/4] crypto: exynos - Introduce mutex to prevent concurrent access to hardware Łukasz Stelmach
2017-12-11 14:06 ` [PATCH v2 1/4] crypto: exynos - Support Exynos5250+ SoCs Łukasz Stelmach
2017-12-11 14:36 ` Krzysztof Kozlowski
2017-12-11 14:06 ` [PATCH v2 2/4] crypto: exynos - Improve performance of PRNG Łukasz Stelmach
2017-12-11 14:54 ` Krzysztof Kozlowski
2017-12-12 14:49 ` Łukasz Stelmach
2017-12-11 14:06 ` [PATCH v2 3/4] crypto: exynos - Reseed PRNG after generating 2^16 random bytes Łukasz Stelmach
2017-12-11 14:57 ` Krzysztof Kozlowski
2017-12-11 14:06 ` [PATCH v2 4/4] crypto: exynos - Introduce mutex to prevent concurrent access to hardware Łukasz Stelmach
2017-12-11 15:03 ` Krzysztof Kozlowski
2017-12-12 10:30 ` Łukasz Stelmach
2017-12-12 11:09 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6915204.SlqusmoAzB@tauon.chronox.de \
--to=smueller@chronox.de \
--cc=b.zolnierkie@samsung.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=l.stelmach@samsung.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox