From: Michael Walle <michael@walle.cc>
To: Horatiu Vultur <horatiu.vultur@microchip.com>
Cc: andriy.shevchenko@linux.intel.com, colin.foster@in-advantage.com,
linus.walleij@linaro.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] pinctrl: ocelot: Fix the pincfg resource.
Date: Tue, 08 Mar 2022 09:31:58 +0100 [thread overview]
Message-ID: <691cc39a667d6284fa25bc47f6855152@walle.cc> (raw)
In-Reply-To: <20220308083023.frr7qz2xga2tas5r@soft-dev3-1.localhost>
Am 2022-03-08 09:30, schrieb Horatiu Vultur:
> The 03/07/2022 13:45, Michael Walle wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know
>> the content is safe
>>
>> > The pincfg resources are in the second memory resource. But the driver
>> > still tries to access the first memory resource to get the pincfg. This
>> > is wrong therefore fix to access the second memory resource.
>> >
>> > Reviewed-by: Colin Foster <colin.foster@in-advantage.com>
>> > Fixes: ad96111e658a95 ("pinctrl: ocelot: combine get resource and ioremap into single call")
>> > Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
>>
>> There is already this patch pending, which does exactly
>> the same:
>> https://lore.kernel.org/linux-gpio/20220216082020.981797-1-michael@walle.cc/
>
> Sorry, I have missed your patch.
> Should I resend this series where I will drop this patch? What is the
> correct approach?
Actually, I don't know. Maybe you don't need to do anything, Linus?
-michael
next prev parent reply other threads:[~2022-03-08 8:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 14:44 [PATCH v2 0/2] pinctrl: ocelot: Add fixes for ocelot driver Horatiu Vultur
2022-03-04 14:44 ` [PATCH v2 1/2] pinctrl: ocelot: Fix the pincfg resource Horatiu Vultur
2022-03-07 12:45 ` Michael Walle
2022-03-08 8:30 ` Horatiu Vultur
2022-03-08 8:31 ` Michael Walle [this message]
2022-03-15 0:51 ` Linus Walleij
2022-03-04 14:44 ` [PATCH v2 2/2] pinctrl: ocelot: Fix interrupt parsing Horatiu Vultur
2022-03-15 0:52 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=691cc39a667d6284fa25bc47f6855152@walle.cc \
--to=michael@walle.cc \
--cc=andriy.shevchenko@linux.intel.com \
--cc=colin.foster@in-advantage.com \
--cc=horatiu.vultur@microchip.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox