From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD36EC433F5 for ; Tue, 8 Mar 2022 08:32:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344979AbiCHIdC (ORCPT ); Tue, 8 Mar 2022 03:33:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241954AbiCHIc7 (ORCPT ); Tue, 8 Mar 2022 03:32:59 -0500 Received: from ssl.serverraum.org (ssl.serverraum.org [IPv6:2a01:4f8:151:8464::1:2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0F0D3F89E; Tue, 8 Mar 2022 00:32:02 -0800 (PST) Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 63ED422236; Tue, 8 Mar 2022 09:31:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1646728319; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rfR7qXhkac8MSMxxEBCzNKSqcYpP/Fvc4ZBkig2QdMY=; b=XbZPeUjeqMbsMTn+pgnhV1fh+dPTvBgBu+XJez+SynmGrdQ6DJSdoUQHzh1lxpGWMvrxSw 6VpHQIhMqWcMFhXiNntw/3roMadgW4RUwbjWfxOGd0kQqDeYXclRPLDTKFMm9Y5rlPrh7W JAvgk7mO1860qg25FWheWoPIZooft5Y= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 08 Mar 2022 09:31:58 +0100 From: Michael Walle To: Horatiu Vultur Cc: andriy.shevchenko@linux.intel.com, colin.foster@in-advantage.com, linus.walleij@linaro.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] pinctrl: ocelot: Fix the pincfg resource. In-Reply-To: <20220308083023.frr7qz2xga2tas5r@soft-dev3-1.localhost> References: <20220304144432.3397621-2-horatiu.vultur@microchip.com> <20220307124501.3487932-1-michael@walle.cc> <20220308083023.frr7qz2xga2tas5r@soft-dev3-1.localhost> User-Agent: Roundcube Webmail/1.4.12 Message-ID: <691cc39a667d6284fa25bc47f6855152@walle.cc> X-Sender: michael@walle.cc Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 2022-03-08 09:30, schrieb Horatiu Vultur: > The 03/07/2022 13:45, Michael Walle wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know >> the content is safe >> >> > The pincfg resources are in the second memory resource. But the driver >> > still tries to access the first memory resource to get the pincfg. This >> > is wrong therefore fix to access the second memory resource. >> > >> > Reviewed-by: Colin Foster >> > Fixes: ad96111e658a95 ("pinctrl: ocelot: combine get resource and ioremap into single call") >> > Signed-off-by: Horatiu Vultur >> >> There is already this patch pending, which does exactly >> the same: >> https://lore.kernel.org/linux-gpio/20220216082020.981797-1-michael@walle.cc/ > > Sorry, I have missed your patch. > Should I resend this series where I will drop this patch? What is the > correct approach? Actually, I don't know. Maybe you don't need to do anything, Linus? -michael