From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 060AF309DAF for ; Tue, 18 Nov 2025 21:46:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763502365; cv=none; b=F+LCnu0zo2BcrvQNnO0zHBoc2z6+Ulfr/QgYBOUYVx4AwYFK6p8WDVxWUIBo/k/9Tuix0kurX2pWb9jMEFpVRpcM5BFzH10tSmOwKGGb2kz5Em1s1iGEAiJIpYEIwSQ+dPDUwRubdY8V0jNfFzgADEZCJjP0pBdpSSPyezVdoqw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763502365; c=relaxed/simple; bh=Wo8abE6ZwL+tRt6K99TsN3lhFcsxaPkTDTphM2Uknig=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=i5Hr5EAUjltYfqLR5ZtZCmCz//HHHyJysRPYaNg4Ume01EBMpv/xwLWIYYyMI7P5MAIkfRMnll33vPVNxenVrawNbJeJ3qrRpVNn0h6YOw3lhVxmm67vKlcISA1Eh4CaQglHtqEyMVe+eNoOEJvqIlzfIuuTd7Vn1P7EN4svfKQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iN/JSCS/; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iN/JSCS/" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-42b3720e58eso5513662f8f.3 for ; Tue, 18 Nov 2025 13:46:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763502362; x=1764107162; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=+PmSkorrHjrkaGRDS83/mqkWmQ5DIqrE7u3ttoJGMyo=; b=iN/JSCS/PK107cYr+S4Re4SmFn0GTrejlNWrePoXgvAqdJ5A3oBDqV89gxZWF335sC 1UWFBqe78gys9f+z3b4030dTKgmA4Sej/iYT4xbagtUPZ2y/SoI1uwqXETXzqmT81TSL 2/1nqD9XuTLxqMEvh/8eiTnBq26PZJfxfsGApLKGDCwjFwMD2+9nCKaPlIHYIqhdIri9 4zVFH3iEwUZn7S5TJevKlmcTfg5C7SSC/P4mGCSydSUR710UBMbUNqKHof7+rGEszGik G6hQUP7PTNA30m7M+486ff4X4Nc9WKWp5+wsw0DWZnbxEMyCTNgbXcAa+Z4bj8eju3RV jByg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763502362; x=1764107162; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+PmSkorrHjrkaGRDS83/mqkWmQ5DIqrE7u3ttoJGMyo=; b=FdXCRkNcq7Gs7RGq31znyCDMAhxJ/W+pFFQB/25twU4ubQ6F/T73s9d8c2EArq1Gv3 QhtsSey1hPGvaKYGo2WF5kycmRWLEQgMxPRHQzK2jNlV/B1Ih41O+MgTn+E0ZPmnB7RH nFa88uRc5NxhSCcZ877Ga5FzVtZBs5iQDQvs50AwZrAyM91kyS7Z0jmse3TSizQ2uQIG l8TbZwQSN1Tr7xxXiZTdtEJCEWEi5swwMqnW1rPIgdHiaVr2tXFAT80AxWWIrCsV0G3f gTb+09x+PshCP0GTBnrUsXEsA2N1T3nac+SlnknXysDObsYYADf3EkMgboIEKWyVgRSF oR5g== X-Forwarded-Encrypted: i=1; AJvYcCX5scmwxkPRaHc9NfwODdPwJuPqXZIfSwNA/RiS2/omSjTIoMxEe7U5KPUr63K4xdLM4/Fh6uv97JB1q/I=@vger.kernel.org X-Gm-Message-State: AOJu0YxNbXc3s/A+F1ApAcVdx/jI8fz62hmnV+wKmt0Z+bsUfUXexzdk 7tOHNOSqaac0rkmeTdKTY5ZyCCnRf3F3XseMMd1SsatxPiXxI0cLEsc2 X-Gm-Gg: ASbGnctAUFTsEy8URbhTBadrR/7rwiL7aRNyDFTlsUl4bJR92gcoUCwCet5525YC2tI s6r1EhzDPx5QEXjic9tR9PipDOiDnMbkc190ctrlekDvpeUtiyyhwlyKHkwA84gV4hB6PSjRKvt 7jUhkJUdCc88b68jOImMeyYvOd+BdZ6j1qdIRjqNVucmzPkwQ/1jjaS9yFPHBRXPvwvirXbT9hG QqZNDStq0URxQYLG4XQTrVU06MzSRLp4zDdOVsu56ibeFOEunYha0+GaboWaQyG45LOV8DlFA8T R0eXwLneKFvnd8FqQztiR15oQFImN+cnFC0uU6BSzrvtqf4+VMVfWmQwrPat44NjOnP/5pPH9ek k0bRiXXIz5Sro/WhhC6Dgw0G8WdlgP37ew6U4/qKygNIfgqp8vaWC00lYb2zo1tvvpHRmEJuOk7 knRA++WR3yLVUaswe072TnSd+E5FjocDSqtrlc5woYXekP2kOoMw== X-Google-Smtp-Source: AGHT+IF6uCuhtwJUtOmpyrnNZmNwcuvn6wN8ul9YQfSdxaLj265T7WGRIxVE7tN5RTMZ9/AF3aUO/Q== X-Received: by 2002:a05:6000:1788:b0:42b:4139:577b with SMTP id ffacd0b85a97d-42b5938fe6dmr17006240f8f.45.1763502362082; Tue, 18 Nov 2025 13:46:02 -0800 (PST) Received: from Ansuel-XPS. (93-34-90-37.ip49.fastwebnet.it. [93.34.90.37]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42b53f203afsm34944300f8f.39.2025.11.18.13.46.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Nov 2025 13:46:01 -0800 (PST) Message-ID: <691ce919.5d0a0220.811e.f1c0@mx.google.com> X-Google-Original-Message-ID: Date: Tue, 18 Nov 2025 22:45:59 +0100 From: Christian Marangi To: Rob Herring Cc: Ilia Lin , "Rafael J. Wysocki" , Viresh Kumar , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov , Konrad Dybcio Subject: Re: [PATCH v4 1/1] cpufreq: qcom-nvmem: add compatible fallback for ipq806x for no SMEM References: <20251105112136.371376-1-ansuelsmth@gmail.com> <20251105112136.371376-2-ansuelsmth@gmail.com> <20251118191018.GA3997357-robh@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251118191018.GA3997357-robh@kernel.org> On Tue, Nov 18, 2025 at 01:10:18PM -0600, Rob Herring wrote: > On Wed, Nov 05, 2025 at 12:21:34PM +0100, Christian Marangi wrote: > > On some IPQ806x SoC SMEM might be not initialized by SBL. This is the > > case for some Google devices (the OnHub family) that can't make use of > > SMEM to detect the SoC ID (and socinfo can't be used either as it does > > depends on SMEM presence). > > > > To handle these specific case, check if the SMEM is not initialized (by > > checking if the qcom_smem_get_soc_id returns -ENODEV) and fallback to > > OF machine compatible checking to identify the SoC variant. > > > > Suggested-by: Dmitry Baryshkov > > Reviewed-by: Konrad Dybcio > > Signed-off-by: Christian Marangi > > --- > > drivers/cpufreq/qcom-cpufreq-nvmem.c | 35 ++++++++++++++++++++++++++-- > > 1 file changed, 33 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/cpufreq/qcom-cpufreq-nvmem.c b/drivers/cpufreq/qcom-cpufreq-nvmem.c > > index 3a8ed723a23e..be44a8965e3a 100644 > > --- a/drivers/cpufreq/qcom-cpufreq-nvmem.c > > +++ b/drivers/cpufreq/qcom-cpufreq-nvmem.c > > @@ -252,13 +252,22 @@ static int qcom_cpufreq_krait_name_version(struct device *cpu_dev, > > return ret; > > } > > > > +static const struct of_device_id qcom_cpufreq_ipq806x_match_list[] = { > > + { .compatible = "qcom,ipq8062", .data = (const void *)QCOM_ID_IPQ8062 }, > > + { .compatible = "qcom,ipq8064", .data = (const void *)QCOM_ID_IPQ8064 }, > > + { .compatible = "qcom,ipq8065", .data = (const void *)QCOM_ID_IPQ8065 }, > > + { .compatible = "qcom,ipq8066", .data = (const void *)QCOM_ID_IPQ8066 }, > > + { .compatible = "qcom,ipq8068", .data = (const void *)QCOM_ID_IPQ8068 }, > > + { .compatible = "qcom,ipq8069", .data = (const void *)QCOM_ID_IPQ8069 }, > > These are all undocumented: > > qcom,ipq8062 > qcom,ipq8066 > qcom,ipq8068 > qcom,ipq8069 > Hi Rob, you are right, I never add these as there weren't any dts for it. I will send a Documentation patch ASAP. -- Ansuel