Re: [PATCH 2/4] soc: qcom: llcc-qcom: Add support for LLCC V6

[Melody Olvera <quic_molvera@quicinc.com>]

On 1/14/2025 2:58 AM, Dmitry Baryshkov wrote:
> On Mon, Jan 13, 2025 at 01:26:41PM -0800, Melody Olvera wrote:
>> Add support for LLCC V6. V6 adds several additional usecase IDs,
>> rearrages several registers and offsets, and supports slice IDs
>> over 31, so add a new function for programming LLCC V6.
>>
>> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
>> ---
>>   drivers/soc/qcom/llcc-qcom.c       | 212 ++++++++++++++++++++++++++++++++++++-
>>   include/linux/soc/qcom/llcc-qcom.h |   8 ++
>>   2 files changed, 216 insertions(+), 4 deletions(-)
>>
>> diff --git a/include/linux/soc/qcom/llcc-qcom.h b/include/linux/soc/qcom/llcc-qcom.h
>> index 8e5d78fb4847a232ab17a66c2775552dcb287752..7a69210a250c4646b7fd6cf400995e35d3f00493 100644
>> --- a/include/linux/soc/qcom/llcc-qcom.h
>> +++ b/include/linux/soc/qcom/llcc-qcom.h
> These are not relevant to v6 support, move them to the platform-support
> patch.

Will do.

Melody
>
> LGTM otherwise.
>
>> @@ -24,6 +24,7 @@
>>   #define LLCC_CMPTDMA     15
>>   #define LLCC_DISP        16
>>   #define LLCC_VIDFW       17
>> +#define LLCC_CAMFW       18
>>   #define LLCC_MDMHPFX     20
>>   #define LLCC_MDMPNG      21
>>   #define LLCC_AUDHW       22
>> @@ -67,6 +68,13 @@
>>   #define LLCC_EVCS_LEFT	 67
>>   #define LLCC_EVCS_RIGHT	 68
>>   #define LLCC_SPAD	 69
>> +#define LLCC_VIDDEC	 70
>> +#define LLCC_CAMOFE	 71
>> +#define LLCC_CAMRTIP	 72
>> +#define LLCC_CAMSRTIP	 73
>> +#define LLCC_CAMRTRF	 74
>> +#define LLCC_CAMSRTRF	 75
>> +#define LLCC_CPUSSMPAM	 89
>>   
>>   /**
>>    * struct llcc_slice_desc - Cache slice descriptor
>>
>> -- 
>> 2.46.1
>>