From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from MW6PR02CU001.outbound.protection.outlook.com (mail-westus2azon11012011.outbound.protection.outlook.com [52.101.48.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 263763921F2 for ; Thu, 22 Jan 2026 02:50:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.48.11 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769050212; cv=fail; b=hgTv/PCF2vzUGbuNZ1PTxyb3x6AKJponLrux2wFytSuzIPFZKvSbr/CCOwsOHRop40hIm+SO9GKo5Jx+Tdwpew9ZYpXvWUj6QkHvO3SNtljiyti8iXtDkXDOAN1o4+vM5oTPFZJZK+ldSEZ3nN9viEP5MXBuLZTbMKaCGWB3mlo= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769050212; c=relaxed/simple; bh=32gbhn3LA/vnBaKFGYuPUdBK6abZcapkFGWShwTosp8=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=FN91PqBAwBMCDDApVmpZju7u1lAK3O4M1JI1/noFy9KqCZF+qyRNw0M3KHDsKg/1Y3tBuvblOOC3UWNvX+HguG3ErEtlVYE0J9njwrT5bWnnB8OpZAoJwiMT6R0oIytIAXAqta4E8yEcKg29L2r6jXRGSIJ4cPfJ2kMD+1l3/mk= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=mTtNfLlV; arc=fail smtp.client-ip=52.101.48.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="mTtNfLlV" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=W8s80PjhrI2y0wo8JBYn7cwMU+JDTPdKX1UkNSwU0Q2TrdLCRkN2TDPMBARcvIB8Qx3w22pR0pWfbCfnR5LXLWlcvVZUdtkcMI2zxO74zv2WUo3sV47vqFMRzy3OWwm9vmsgZbmPEJQv1k7RuqKtggUv3lBLcydrtbiAciMLVSvs4zbpU+yy/L0WKFLdJ1YLq7XIOVuIsmANHnQnMLREefYHsN1Lpe7A2+5F0keWOQxJMyBC3FalNXZFOQZqb/FBPoPh5cyuJb/O8nndWIs1qsf+qM2MzbXCmX2FKJCHJXqMpweB2NIVbtibqZcK2qhr+H1A3/5PXw7EKyzCGksRpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0xrKBuFofJcjupqGOi0UUUXVRDf5rMlgn+iE8uu8tVM=; b=DqcOFIiLYYe8NAMmwsqFfiZvok7gw5xsWZiUPrf9yuCWGqWLql1EF4KbBrPslp9ogR3+z2Ss0pA3O2ZpOfhbVuTFkOY43RSqqVpz9vkO+LF6VhUpVdmvc+uLnQvkZBgJ/M5vwfOGftKkAoyBB/SOgDOM2RaxSxQDYnuxkI+J5xdNl3BA6IUPV6uNuVUH6u8S+iqrqWhCWjLHw51E0bcZitFy2QIqQsYpAli4oOorbtCnD3mepnA9eJC7N59CmmKhvbhN/vbzJ+4fiKQzjfGXWzLQLkQOVJD837GXsp7rqmckrn9c1qppPUkozjClrqX6uVRnKDfCeLZdtIJN6L+ymw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0xrKBuFofJcjupqGOi0UUUXVRDf5rMlgn+iE8uu8tVM=; b=mTtNfLlV79af/AQt1LhTaewFxwjB2GUNxgvXfIoKK16UORnRfMjImlDIT1W2h4Q+Pqxs6IXFNb3BD1tmFUUVqsIJnDzom4dPvgs4qL6gRlMCYEp0rDl+KxXoP0fh9DfjDNXUMci/Eu3ln8kw/Rjtg0kpx+Be2yMXugHnBSWNivA= Received: from BL1P222CA0024.NAMP222.PROD.OUTLOOK.COM (2603:10b6:208:2c7::29) by MN2PR12MB4238.namprd12.prod.outlook.com (2603:10b6:208:199::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9542.11; Thu, 22 Jan 2026 02:50:03 +0000 Received: from BL6PEPF00020E63.namprd04.prod.outlook.com (2603:10b6:208:2c7:cafe::e0) by BL1P222CA0024.outlook.office365.com (2603:10b6:208:2c7::29) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9499.5 via Frontend Transport; Thu, 22 Jan 2026 02:50:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C Received: from satlexmb08.amd.com (165.204.84.17) by BL6PEPF00020E63.mail.protection.outlook.com (10.167.249.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9542.4 via Frontend Transport; Thu, 22 Jan 2026 02:50:03 +0000 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Wed, 21 Jan 2026 20:50:01 -0600 Received: from [10.136.37.139] (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.17 via Frontend Transport; Wed, 21 Jan 2026 20:49:58 -0600 Message-ID: <692260d8-d021-4aac-b1ca-28318cbc66d2@amd.com> Date: Thu, 22 Jan 2026 08:19:57 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/8] sched/topology: Switch to assigning "sd->shared" from s_data To: "Chen, Yu C" CC: Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Shrikanth Hegde , "Gautham R. Shenoy" , "Tim Chen" , , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot References: <20260120113246.27987-1-kprateek.nayak@amd.com> <20260120113246.27987-4-kprateek.nayak@amd.com> Content-Language: en-US From: K Prateek Nayak In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF00020E63:EE_|MN2PR12MB4238:EE_ X-MS-Office365-Filtering-Correlation-Id: 3f485a43-fd07-43fc-dacc-08de5960f14f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|1800799024|376014|7416014|82310400026; X-Microsoft-Antispam-Message-Info: =?utf-8?B?NCs0UlREb25rQng4NG15M1RpYVo3eEMwbFowTTEydnZiRFJoS0NpbmROVTlE?= =?utf-8?B?WG9BTGs1VWVzcWxXZDY0bitzM0pHeWdTdUNmVTc1c1pTVFdtVjVtMGJMV1cw?= =?utf-8?B?UXhKRWQ4WHJheUZGd3VpT2tlK2hBeUpEMHYvMkxvNkVtdFlxVGdDcWo3MlJR?= =?utf-8?B?bG9DemFTM2ZIUm9NeVBjcXRzNlQ3MmVVVVdYLzFOcDI5VStlZzlaTHdxRytK?= =?utf-8?B?R2hkRXBKclpSa3AxQnNQc0UvcG9kZmRabG9pb242Z1JKWkJLckVOVVNwODM5?= =?utf-8?B?ZGFjNXROMmEvU2VXc0xUWlJkRkwrQXlCYVJNUDd0UkF2ZndXZkhnZmdYcDRj?= =?utf-8?B?RjArVXhDdUdxekR3T3pSNm1oUmludWo5czNnaUJ4RTU1ZnhuMTJIU0dyVVhI?= =?utf-8?B?QlhDWE5oMnJOeEppdm1RT3NPNFR6NXV3MWh4YW9Eek12QjVJZGZLT2Q0RU5G?= =?utf-8?B?cnM5TFkvU3l1VFNSaHZpMllUUVM2QkdBRUFsM2tMQ1RocmRuNzJsS0lxUHZX?= =?utf-8?B?TWZ0bkVjNGNJN0hWeHhrdWhreEJtY0ljNGNTRE1KWjdyZjVQSnFycWFCK0FY?= =?utf-8?B?UUFWNnVsMXNNWHFVZzBVRkNxcTlkQTIyVzIvb3pIUnh2VEh1RzRZUU5rOVcx?= =?utf-8?B?VVdmZW1KckFSTUV3YVBpMjJkRXRKakJ2RkVlYUJOZzF2N0NjVzEzSW5qZERX?= =?utf-8?B?c0dOam91MXUvdmNPQktBVmprTUU4Wms3Z0Q2eURrc2lhUXN0MzBsRk1VL285?= =?utf-8?B?ZTMyVUs3ZzdXMUticzBPWDJzL3QzTW9mZm8zL1BXRzdMTkZZc1AwZ3oyVHc5?= =?utf-8?B?TmtFSmUyT0FIdTFSUzJaM2MvS0c5NmRBQjB2dWxvYWIzYmhBVlg5SS92Tkla?= =?utf-8?B?OW1GOU5Cdi9kZGVFSmQvWFd0OGV3WThIeW9ocnJEdlhUSy84WXNBWU5oWmlC?= =?utf-8?B?SjFDbG0zcjJNMlJOekVwRi9DNGYyUThnaksxNUhDN1dDdGJvK0FFQnllVndR?= =?utf-8?B?dVdwTFF2Z3Avbm9iVFp3aDhWV2VaS2tHa3JCbXJnYW04dk1mSzVGeUJRQ3Z5?= =?utf-8?B?cEFheEJEbnl2aHR3QzBLU202SmY5cE5oanBoT2pYVXlLMTk2anc4OGpDWEpP?= =?utf-8?B?cDZEZDhUejliTE1QS1dYTFpCUzNBZ0NrTUJacjllWGZIR00wUkFYb2lXZUVi?= =?utf-8?B?ZjNGMGhVbTJHSVBXTVN6RHBaN0Q5NjhCbjhRMVN2MGxLOFBOcE4wOExLcVBR?= =?utf-8?B?QUg1V0o4VXBLSE5JZjAvanlOYkN5bFZKUDRQOVJvL0t1TmFXdVlWM0pXMGMw?= =?utf-8?B?N0kyUFRwRE9taitkYkR1empWWUlaS0NwL1c3bDFGY3M4YmJXcVQ3MHpOMnda?= =?utf-8?B?QmV5WlMxL2J5eTFEY2w0VU5PU0ZSbllFdk5nS3Q4SlIzcmFYcWV1MnY5bDdW?= =?utf-8?B?SjhLNzF4cjhiOW5GY29WYWN0QWFudGhXUXhXakdtT0lPditVNXZaQkllbm9F?= =?utf-8?B?bCtPV3ZFVzIwZWpGd1Bua1FodVo2M2dWNlkvMmJyVjRsNEYrZE1NL0Y5S2d1?= =?utf-8?B?SDFTYzFwZDBaNVkvODBoWndtdktGY3Y4bXpzWHl2Y3dsOGVmb3JZZ0ZxdFdW?= =?utf-8?B?UlFMTmJ4REFnQ2h5UGYxWjArNlJlY3NiSnZaVzF1NEEzbG5oejlPZ0doalhG?= =?utf-8?B?MDIzbGhOZGowMHJYaE8xTUxSWG9NQ2E1VjRHM0p0cUd5MkMyRlpETklaVEtt?= =?utf-8?B?YWx6Y0xpQnQ5c2ZHWHJYSmtnc0locnB5WDZTRndZT0lvR3VqekdxWWRJdktn?= =?utf-8?B?anpOUTdqbzdhbCs4WDNFQkVFQ1lhY1FzajRpa0ExV1BCNkgzRHVwUEczY2RF?= =?utf-8?B?SjJJVlNLUEVSeHJtcHFWMG9PQ0FjUTFadmtBdy9xbWswOVB1aFZRM3VzNUpp?= =?utf-8?B?RUZLcnMrMmk1SXVLREVGb3BzbXAveVFoMENTVzRwNi8raW5zdmdKVEZmY2V3?= =?utf-8?B?MnJxZXV2Y2t2Sk91MHdpK3dyQUd1YmlQL3cyazhNUFBnNDlEcHMyUHc0TzBL?= =?utf-8?B?ekRhTFRnWWx3V0lGSXlVQ1dtTlBLT1B3N2QyK2lRalNVQW9LeU5PL29MYW5C?= =?utf-8?B?TDZzZHEvZmNLU0tFOUN5MGxhWURZSUF6WHMxTlQvRkViUkRNU3ZybkVaWHBN?= =?utf-8?B?Qm5WWEI5NFE3bXN4V21ucVN3Q3A0MEQzbTF5ZFYvYlVMN295WVB0cVpSMXlw?= =?utf-8?B?cmxGM2NpUHM0Y1VFL2h1UmRVOGlRPT0=?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(1800799024)(376014)(7416014)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jan 2026 02:50:03.2998 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3f485a43-fd07-43fc-dacc-08de5960f14f X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF00020E63.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4238 Hello Chenyu, On 1/21/2026 8:56 PM, Chen, Yu C wrote: >> @@ -2655,8 +2655,19 @@ build_sched_domains(const struct cpumask *cpu_map, struct sched_domain_attr *att >>           unsigned int imb_span = 1; >>             for (sd = *per_cpu_ptr(d.sd, i); sd; sd = sd->parent) { >> +            struct sched_domain *parent = sd->parent; >>               struct sched_domain *child = sd->child; >>   +            /* Attach sd->shared to the topmost SD_SHARE_LLC domain. */ >> +            if ((sd->flags & SD_SHARE_LLC) && >> +                (!parent || !(parent->flags & SD_SHARE_LLC))) { >> +                int llc_id = cpumask_first(sched_domain_span(sd)); >> + >> +                sd->shared = *per_cpu_ptr(d.sds, llc_id); > > I agree that in the current implementation, we use the llc_id="first CPU" to > index into d.sds, and this value actually represents the LLC ID. In the > cache-aware scheduling, we plan to convert the llc_id to a logical ID that > is no longer tied to the CPU number. Just 2 cents, to avoid confusion, maybe > rename the  aforementioned llc_id to sd_id? Ack! Will modify in the next version! > > Anyway I will run some tests on the entire patch set and provide feedback > afterward. Thanks a ton for taking a look at the series! Much appreciated. -- Thanks and Regards, Prateek