Re: [PATCH v5 3/5] dt-bindings: pinctrl: add binding for MT7988 SoC

["Frank Wunderlich (linux)" <linux@fw-web.de>]

Am 2024-12-05 08:35, schrieb Krzysztof Kozlowski:
> On 04/12/2024 08:41, Frank Wunderlich wrote:
>> Am 4. Dezember 2024 08:35:37 MEZ schrieb Krzysztof Kozlowski 
>> <krzk@kernel.org>:
>>> On Mon, Dec 02, 2024 at 12:00:37PM +0100, Frank Wunderlich wrote:
>>>> From: Frank Wunderlich <frank-w@public-files.de>
>>>> 
>>>> This adds bindings for MT7988 pinctrl driver.
>>>> 
>>>> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
>>>> ---
>>>> changes in v5 (so not adding RB from Rob given in v4):
>>>> - do not use MTK_DRIVE_8mA in example
>>>> - add _0 functions for pwm
>>>> 
>>> 
>>> <form letter>
>>> This is a friendly reminder during the review process.
>>> 
>>> It looks like you received a tag and forgot to add it.
>>> 
>>> If you do not know the process, here is a short explanation: Please 
>>> add
>>> Acked-by/Reviewed-by/Tested-by tags when posting new versions, under
>>> or above your Signed-off-by tag. Tag is "received", when provided
>>> in a message replied to you on the mailing list. Tools like b4 can 
>>> help
>>> here. However, there's no need to repost patches *only* to add the 
>>> tags.
>>> The upstream maintainer will do that for tags received on the version
>>> they apply.
>>> 
>>> https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577
>>> 
>>> If a tag was not added on purpose, please state why and what changed.
>>> </form letter>
>> 
>> Is this an automatic message? I guess yes...
>> 
>> I have not added it (robs reviewed-by) from v4 due to changes and 
>> explained why in changelog. If i'm wrong please let me know.
> 
> Where did you explain the reason of dropping review tag? This has to be
> *EXPLICIT* but I only see:
> 
> - rebased to 6.13-rc1
> - moved dt nodes with mutliple options to BPI-R4 board
> - changes suggested by angelo in v4
> - changed example in binding and dt node to not using const 
> MTK_DRIVE_8mA
> 
> 
> Nothing here suggests even remotely that review tag was dropped. 
> Nothing
> suggests that it should be dropped!

here:
>>>> changes in v5 (so not adding RB from Rob given in v4):


> Best regards,
> Krzysztof