From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f175.google.com (mail-dy1-f175.google.com [74.125.82.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6A193E63B5 for ; Fri, 8 May 2026 14:30:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778250639; cv=none; b=iupS0mMo9mzBJeWjTi26+zav7NhrmTnebsijt1wRsyKky8nyFqxOpF3kkJLkJK1DiwPnZvFoY6UYCJnU7JTdnNGcLYABOaPcjwW9lucoevOsPJx7VgNAgDJEgncg3BsdLuzqPduuzSWwk4kha7vPeVy8NqrPFLZtUMHRBJKC+wQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778250639; c=relaxed/simple; bh=dA3ssTeMPL2h0yAgyQCV/GL+K8IFVy37Jn+FniNYOcE=; h=Date:From:To:CC:Subject:In-Reply-To:References:Message-ID: MIME-Version:Content-Type; b=TodQtVxbv7Ppuzaz8WbZaEbyyGVYTFFITGJ87jheqtOdPhGKgc6T37lWmxPaMP6U5EYhtO0XFRZulgKwY+SG6snUjQM+t//L3VAxcnkQUryWholdxAAoSl8MLkB8K9PRbIl9Ok5+FPKEV7L+LcO/7ahPGGNNZPaka/B/Es84+Bg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DHP7CqVi; arc=none smtp.client-ip=74.125.82.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DHP7CqVi" Received: by mail-dy1-f175.google.com with SMTP id 5a478bee46e88-2ee990e8597so3603568eec.1 for ; Fri, 08 May 2026 07:30:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778250637; x=1778855437; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=dA3ssTeMPL2h0yAgyQCV/GL+K8IFVy37Jn+FniNYOcE=; b=DHP7CqVip+ty72wN1zgLyhdOeh9HyW7nG0h60pQ3LCGBWzZ5a+p2IvqN8ytgx2HRxu VzT9eRRzjAmYF2EtpH0C737+CUlKxLUuxxEqY5fCx34M2/EwHKGo/fUvPJ3a/1USkDFd d2kJWSdgdzXsG1TSz6HOIO94+VuCYIOUGdObI53pQzde5eMvpKq11NX491YMY9EA3ezH PbPEsIsGhPmUY5SG3MNZWTPDG++kIh5JC18XO3k19LK4hDIpWAnd99ZKO+et47uy7Adc Ro1+03S4lofZxa1pELPstjKSfTkXt6I3Btd+mrDwUnhZXTehGv2IJGMnXKi5qxx3tRSz h8vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778250637; x=1778855437; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dA3ssTeMPL2h0yAgyQCV/GL+K8IFVy37Jn+FniNYOcE=; b=QOdvxyI6vr0ww6qXhYuKGZ3SghM4bGwQJfsQ+ZgNYggvvYtqiONrGBPP85FIT9Jkuo WAcMYVAglSmCuwBiC3HPUHxy5TyRJ3YWcIPdU1IfFswPvNi3JEQ+M2tdYH6xuIJAlvwv gfReFx6Va2vw3ioFItUdeQMEatgwnDsVCA0zE/iVIvzVWgQZ4vn/H1E+V6ADjkEh/nhy 072JmB67ZHJ2sy7Xer0gQB2u4qKuQpr4PpBo3m1owK72Fjri4Zts8xoxDIhFgFLTydaP CAhBxI92CDs4qx2hPGACkSId0dKHF+rvBXqUEdNOeb0csjuWyLrcIyiAJCCNL2z7l6Wk owOg== X-Forwarded-Encrypted: i=1; AFNElJ9DBf/rbjCDr1s9Vfgne+uq+/plHCyz26YWAbU4DummdjPNfzd1riZbjvXWEVQWP31JUjRS1rLZLpPk51Y=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5A3A3XWXsdIoAyR0OQrSoj+WvASRwOp7DOFrkVDN1NurVA+B6 k9XpbZDdWsFS08BMSrNfZUz7danc4iM79mXTSzLlQC+3guJACw9GfJUI X-Gm-Gg: Acq92OGJueKq2IZ+H+gRsP4jmp4NhLNTy474B0bWuQ1bq7X/2rNwbegK7vwgRp15bp2 KYsgV1+b+KC7df/JpgJ75/THdSSF0xvPN8yks3z03tlfu+/0PSeb4l4opuIb4+A79iWzR4gNzdr 5dKuUG0kCznwz6HNZyg90UkVGTHomgE0W1TTxlI16dsKu2sdc2eiYHLJCt1Vzi7XAniTbcMnaxM R1yS88/WKGxHA3gLmzJLwalx4NeEOK0CUQu2ijSIOO0r8UIZ1AhDJVdFMTM2YDQcU1ARSapcqtM mn0PLie/8iecVfTtpNElgubWPqSFfM3nxixxoviIYIya41hKGGUpWrUtIEPfEM4l66lULKEw3ET HELalmJf5SUBJSCJ66Ph8PRWqCzdMCbgJcONA00j4BZ8PnXSfDMXRP19TUhbynSlWUxmHAicor8 YK5R9vornescnOrOtl4Av9GVnAGMBF11Lhtex5J797F6a5 X-Received: by 2002:a05:693c:2c01:b0:2c5:b23e:48a9 with SMTP id 5a478bee46e88-2f54b266964mr6364127eec.25.1778250636710; Fri, 08 May 2026 07:30:36 -0700 (PDT) Received: from ehlo.thunderbird.net ([2607:fb91:1bc2:493c:ac39:c332:9a80:788a]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2f8862d3047sm2749565eec.10.2026.05.08.07.30.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 May 2026 07:30:36 -0700 (PDT) Date: Fri, 08 May 2026 07:30:34 -0700 From: "Derek J. Clark" To: =?ISO-8859-1?Q?Ilpo_J=E4rvinen?= CC: Hans de Goede , Mark Pearson , Armin Wolf , Jonathan Corbet , Rong Zhang , Kurt Borja , "Pierre-Loup A . Griffais" , =?ISO-8859-1?Q?N=EDcolas_F_=2E_R_=2E_A_=2E_Prado?= , marshall@shzj.cc, hyacinth@shzj.cc, platform-driver-x86@vger.kernel.org, LKML , stable@vger.kernel.org Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_v11_07/15=5D_platform/x86=3A_lenovo-wm?= =?US-ASCII?Q?i-helpers=3A_Move_gamezone_enums_to_wmi-helpers?= User-Agent: Thunderbird for Android In-Reply-To: <0d4c9865-de40-39b3-20fb-398f8480530b@linux.intel.com> References: <20260507180507.912966-1-derekjohn.clark@gmail.com> <20260507180507.912966-8-derekjohn.clark@gmail.com> <0d4c9865-de40-39b3-20fb-398f8480530b@linux.intel.com> Message-ID: <69290AC0-839A-4F8E-B272-4128A617A503@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On May 8, 2026 7:21:22 AM PDT, "Ilpo J=C3=A4rvinen" wrote: >On Thu, 7 May 2026, Derek J=2E Clark wrote: > >It seems there are a few nits still to address (they were too many so I'd= =20 >want to try to do inline editing)=2E > No problem=2E I'll try to get v12 done today after you're done with the re= view=2E >> In a later patch in the series the thermal mode enum will be accessed >> across three separate drivers (wmi-capdata, wmi-gamezonem and wmi-other= )=2E >> An additional patch in the series will also add a function protoype tha= t > >prototype > >> needs to reference this enum in wmi-helpers=2Eh=2E To avoid having all = these >> drivers begin to import each others headers, and to avoid declaring an >> opaque enum to hande the second case, move the thermal mode enum to >> helpers where it can be safely accessed by everything that needs it fro= m >> a single import=2E >>=20 >> While at it, since the gamezone_events_type enum is the only remaining >> item in the header, move that as well and remove the gamezone header >> entirely=2E >>=20 >> Fixes: 22024ac5366f ("platform/x86: Add Lenovo Gamezone WMI Driver") > >This change doesn't seem to exactly fix anything so it shouldn't have=20 >Fixes tag=2E > >We want to only have Cc: stable in the prerequisites for some other fix= =20 >that comes after=2E > Makes sense=2E I wasn't sure, checkpatch flagged it as missing a fixes tag= and I figured it was easier to drop than to have you try and find the orig= inal commit=2E I'll drop that for the formatting only patches=2E=20 Thanks, Derek >My plan is to take patches 1-9 through fixes branch and then merge fixes= =20 >to for-next and take the rest through for-next=2E >