From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f71.google.com (mail-ot1-f71.google.com [209.85.210.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AE6E253932 for ; Wed, 3 Dec 2025 07:31:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.71 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764747065; cv=none; b=amWZTLBra7ogRANcRwLNrYs/IfQZQIRrvBaGIjrb/Ohcl1sybsv6NBK2qb65eeU8QYG6bP8oWUKXxnJ0hycxDxPrcV9WO5u34J0V+oyfD3aENbZxLz8H7H9jkWyuC5OwCoUQuImac5SN+AtXO84qtcHn90e0/+YzM6fZg6vkqaM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764747065; c=relaxed/simple; bh=3jWuqEqg97U8SDzjtqzW9DoCVrYFqRry96yVfUMA/I0=; h=MIME-Version:Date:In-Reply-To:Message-ID:Subject:From:To:Cc: Content-Type; b=j1ItUNStv+5uxSIeGX6B7PBJ9dvB771sdliKLgzltXsaR1SrwkpPZINAn7WBoLKjRhMU5a8CMU26hQfFPS0pDuhvsOlPihJLaUsZyj/fBY5rjjklK7d5t2FRo1LVvo8m8jFYQLmCIjzgv7Ja7bA9ybm5/l3LEwBkoBcf32V3u6Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com; arc=none smtp.client-ip=209.85.210.71 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com Received: by mail-ot1-f71.google.com with SMTP id 46e09a7af769-7c7595cde21so8504265a34.2 for ; Tue, 02 Dec 2025 23:31:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764747063; x=1765351863; h=content-transfer-encoding:cc:to:from:subject:message-id:in-reply-to :date:mime-version:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yhumxxBgUe12khz7lM61+ZqwoWknmXpRVAOIGUvqEp8=; b=vAhNTqFkanDwN7od9uV/SXgAgZ01zZQ3W45ipPJ23tu4gP0mNK1vmmUn6huVF8eLSd EBETKAZ1wiW7O1kD2JJXvYm9/CTIpFy04ZK6KqoKrZxbqyXM2WH3eVBJU4It7/JqDOv3 4Nc6zTdLSUo79M8V06JFB6lYOnXiFyiQ5W1jVfI6i3IBfoJzEON0qPg1+ijHhoO9xuOR wsO4ThwhjVcqXhF7hUxyFLIUKRlJ9trvf8cKGvG7JjylEgoDOhi1wgvv9Hx3KqCXhTMI 7x43dKKxNaLD6VCcFQKxAYaWnGB5jfkXSSXvrWePpcn2mlMyXcZEeYQxf5t5PBF7R2kJ FW2A== X-Forwarded-Encrypted: i=1; AJvYcCWzRhE0NQwrnkCdn0Fztxg5wccLqZ6A0mIv/6/KMo1A20Gcw8X6ZAIekp7hJdoDVvBi6Bpl9Liyv++rdX8=@vger.kernel.org X-Gm-Message-State: AOJu0Yxt/NxzRyly1aWAWBfbCOLR/Az1P0wgJfQt0ZYXbPQNKx+evdOc RKziB5OlJyhjl7iDnC5al4FaGYYudk7fBqznlGCv0uVS5VpdhMDAfrz3EY+qhF+GVKhXtf5+Kl8 BJRHZwpsjGzc/Glmu0UmUCG1f9kaqe8ocQ4NSYQqdwo14zYnAAvw4iOOgjgg= X-Google-Smtp-Source: AGHT+IFXV3Ew4JJXnBsijQe2URNnrAPDj1HMY5ooVl9Z5EphiLiEquujW+fJyAUulg3s7awa1ik8cNxvnwpwr3oIo2rJ4oU3FJbQ Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Received: by 2002:a05:6808:1404:b0:43f:7940:69bf with SMTP id 5614622812f47-4536e3ee821mr686786b6e.26.1764747063226; Tue, 02 Dec 2025 23:31:03 -0800 (PST) Date: Tue, 02 Dec 2025 23:31:03 -0800 In-Reply-To: X-Google-Appengine-App-Id: s~syzkaller X-Google-Appengine-App-Id-Alias: syzkaller Message-ID: <692fe737.a70a0220.2ea503.00cd.GAE@google.com> Subject: Re: [PATCH 6.1.y] HID: core: Harden s32ton() against conversion to 0 bits From: syzbot To: lanbincn@hotmail.com Cc: lanbincn@hotmail.com, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > #syz test:=20 This bug is already marked as fixed. No point in testing. > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git linux-6.1.= y > > drivers/hid/hid-core.c | 7 ++++++- > =C2=A01 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c > index ed65523d77c2..c8cca0c7ec67 100644 > --- a/drivers/hid/hid-core.c > +++ b/drivers/hid/hid-core.c > @@ -1354,7 +1354,12 @@ EXPORT_SYMBOL_GPL(hid_snto32); > > =C2=A0static u32 s32ton(__s32 value, unsigned n) > =C2=A0{ > -=C2=A0 =C2=A0 s32 a =3D value >> (n - 1); > +=C2=A0 =C2=A0 s32 a; > +=C2=A0 =C2=A0 if (!value || !n) > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 return 0; > + > +=C2=A0 =C2=A0 a =3D value >> (n - 1); > + > =C2=A0 =C2=A0 =C2=A0if (a && a !=3D -1) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return value < 0 ? 1 << (n - 1) : (1 <= < (n - 1)) - 1; > =C2=A0 =C2=A0 =C2=A0return value & ((1 << n) - 1); > --=20 > 2.43.0 > >