* [PATCH] ata_piix: Add MODULE_PARM_DESC to prefer_ms_hyperv
[not found] <1619122110.7061314.1361463977742.JavaMail.root@redhat.com>
@ 2013-02-21 17:43 ` Rado Vrbovsky
2013-02-21 18:50 ` Sergei Shtylyov
0 siblings, 1 reply; 6+ messages in thread
From: Rado Vrbovsky @ 2013-02-21 17:43 UTC (permalink / raw)
To: linux-ide, linux-kernel, Jeff
From: Andrew Brownfield <abrownfi@redhat.com>
In reference to the commit cd006086fa5d91414d8ff9ff2b78fbb593878e3c
this trivial patch adds a description to prefer_ms_hyperv.
[rvrbovsk@redhat.com: MODULE_PARM_DESC() string formatting modified]
Signed-off-by: Radomir Vrbovsky <rvrbovsk@redhat.com>
---
drivers/ata/ata_piix.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c
index 174eca6..b9bf99a 100644
--- a/drivers/ata/ata_piix.c
+++ b/drivers/ata/ata_piix.c
@@ -1530,6 +1530,10 @@ static bool piix_broken_system_poweroff(struct pci_dev *pdev)
static int prefer_ms_hyperv = 1;
module_param(prefer_ms_hyperv, int, 0);
+MODULE_PARM_DESC(prefer_ms_hyperv,
+ "Prefer Hyper-V paravirtualization drivers instead of ATA, "
+ "0 - Use ATA drivers, "
+ "1 (Default) - Use the paravirtualization drivers.");
static void piix_ignore_devices_quirk(struct ata_host *host)
{
--
1.7.11.7
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ata_piix: Add MODULE_PARM_DESC to prefer_ms_hyperv
2013-02-21 17:43 ` [PATCH] ata_piix: Add MODULE_PARM_DESC to prefer_ms_hyperv Rado Vrbovsky
@ 2013-02-21 18:50 ` Sergei Shtylyov
2013-02-21 19:01 ` Rado Vrbovsky
0 siblings, 1 reply; 6+ messages in thread
From: Sergei Shtylyov @ 2013-02-21 18:50 UTC (permalink / raw)
To: Rado Vrbovsky; +Cc: linux-ide, linux-kernel, Jeff
Hello.
On 02/21/2013 08:43 PM, Rado Vrbovsky wrote:
> From: Andrew Brownfield<abrownfi@redhat.com>
>
Hm, I don't see his signoff...
> In reference to the commit cd006086fa5d91414d8ff9ff2b78fbb593878e3c
>
Please also specify that commit's summary in parens (or however you
like).
> this trivial patch adds a description to prefer_ms_hyperv.
>
> [rvrbovsk@redhat.com: MODULE_PARM_DESC() string formatting modified]
>
> Signed-off-by: Radomir Vrbovsky<rvrbovsk@redhat.com>
>
MBR, Sergei
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ata_piix: Add MODULE_PARM_DESC to prefer_ms_hyperv
2013-02-21 18:50 ` Sergei Shtylyov
@ 2013-02-21 19:01 ` Rado Vrbovsky
2013-02-22 14:43 ` Sergei Shtylyov
2013-03-04 22:15 ` Jeff Garzik
0 siblings, 2 replies; 6+ messages in thread
From: Rado Vrbovsky @ 2013-02-21 19:01 UTC (permalink / raw)
To: Sergei Shtylyov, linux-ide, linux-kernel, Jeff
From: Andrew Brownfield <abrownfi@redhat.com>
In reference to the commit cd006086fa5d91414d8ff9ff2b78fbb593878e3c
"ata_piix: defer disks to the Hyper-V drivers by default",
this trivial patch adds a description to prefer_ms_hyperv.
[rvrbovsk@redhat.com: MODULE_PARM_DESC() string formatting modified]
Signed-off-by: Andrew Brownfield <abrownfi@redhat.com>
Signed-off-by: Radomir Vrbovsky <rvrbovsk@redhat.com>
---
drivers/ata/ata_piix.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c
index 174eca6..b9bf99a 100644
--- a/drivers/ata/ata_piix.c
+++ b/drivers/ata/ata_piix.c
@@ -1530,6 +1530,10 @@ static bool piix_broken_system_poweroff(struct pci_dev *pdev)
static int prefer_ms_hyperv = 1;
module_param(prefer_ms_hyperv, int, 0);
+MODULE_PARM_DESC(prefer_ms_hyperv,
+ "Prefer Hyper-V paravirtualization drivers instead of ATA, "
+ "0 - Use ATA drivers, "
+ "1 (Default) - Use the paravirtualization drivers.");
static void piix_ignore_devices_quirk(struct ata_host *host)
{
--
1.7.11.7
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ata_piix: Add MODULE_PARM_DESC to prefer_ms_hyperv
2013-02-21 19:01 ` Rado Vrbovsky
@ 2013-02-22 14:43 ` Sergei Shtylyov
2013-02-22 15:41 ` Rado Vrbovsky
2013-03-04 22:15 ` Jeff Garzik
1 sibling, 1 reply; 6+ messages in thread
From: Sergei Shtylyov @ 2013-02-22 14:43 UTC (permalink / raw)
To: Rado Vrbovsky; +Cc: linux-ide, linux-kernel, Jeff
Hello.
On 21-02-2013 23:01, Rado Vrbovsky wrote:
> From: Andrew Brownfield <abrownfi@redhat.com>
> In reference to the commit cd006086fa5d91414d8ff9ff2b78fbb593878e3c
> "ata_piix: defer disks to the Hyper-V drivers by default",
> this trivial patch adds a description to prefer_ms_hyperv.
> [rvrbovsk@redhat.com: MODULE_PARM_DESC() string formatting modified]
> Signed-off-by: Andrew Brownfield <abrownfi@redhat.com>
Note that you can't jus mechanically add Andrew's signoff to the patch,
you have to ask him to sign it off... I hope you did.
> Signed-off-by: Radomir Vrbovsky <rvrbovsk@redhat.com>
MBR, Sergei
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ata_piix: Add MODULE_PARM_DESC to prefer_ms_hyperv
2013-02-22 14:43 ` Sergei Shtylyov
@ 2013-02-22 15:41 ` Rado Vrbovsky
0 siblings, 0 replies; 6+ messages in thread
From: Rado Vrbovsky @ 2013-02-22 15:41 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: linux-ide, linux-kernel, Jeff
> Hello.
Hi Sergei,
> On 21-02-2013 23:01, Rado Vrbovsky wrote:
>
> > From: Andrew Brownfield <abrownfi@redhat.com>
>
> > In reference to the commit cd006086fa5d91414d8ff9ff2b78fbb593878e3c
> > "ata_piix: defer disks to the Hyper-V drivers by default",
> > this trivial patch adds a description to prefer_ms_hyperv.
>
> > [rvrbovsk@redhat.com: MODULE_PARM_DESC() string formatting
> > modified]
>
> > Signed-off-by: Andrew Brownfield <abrownfi@redhat.com>
>
> Note that you can't jus mechanically add Andrew's signoff to the
> patch,
> you have to ask him to sign it off... I hope you did.
It was in the original patch and I erased by mistake.
> > Signed-off-by: Radomir Vrbovsky <rvrbovsk@redhat.com>
>
> MBR, Sergei
>
Brg,
Rado
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ata_piix: Add MODULE_PARM_DESC to prefer_ms_hyperv
2013-02-21 19:01 ` Rado Vrbovsky
2013-02-22 14:43 ` Sergei Shtylyov
@ 2013-03-04 22:15 ` Jeff Garzik
1 sibling, 0 replies; 6+ messages in thread
From: Jeff Garzik @ 2013-03-04 22:15 UTC (permalink / raw)
To: Rado Vrbovsky; +Cc: Sergei Shtylyov, linux-ide, linux-kernel, Jeff
On 02/21/2013 02:01 PM, Rado Vrbovsky wrote:
> From: Andrew Brownfield <abrownfi@redhat.com>
>
> In reference to the commit cd006086fa5d91414d8ff9ff2b78fbb593878e3c
> "ata_piix: defer disks to the Hyper-V drivers by default",
> this trivial patch adds a description to prefer_ms_hyperv.
>
> [rvrbovsk@redhat.com: MODULE_PARM_DESC() string formatting modified]
>
> Signed-off-by: Andrew Brownfield <abrownfi@redhat.com>
> Signed-off-by: Radomir Vrbovsky <rvrbovsk@redhat.com>
>
> ---
> drivers/ata/ata_piix.c | 4 ++++
> 1 file changed, 4 insertions(+)
applied [manually]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-03-04 22:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1619122110.7061314.1361463977742.JavaMail.root@redhat.com>
2013-02-21 17:43 ` [PATCH] ata_piix: Add MODULE_PARM_DESC to prefer_ms_hyperv Rado Vrbovsky
2013-02-21 18:50 ` Sergei Shtylyov
2013-02-21 19:01 ` Rado Vrbovsky
2013-02-22 14:43 ` Sergei Shtylyov
2013-02-22 15:41 ` Rado Vrbovsky
2013-03-04 22:15 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox