From: Rodolfo Giometti <giometti@enneenne.com>
To: Raag Jadav <raag.jadav@intel.com>,
gregkh@linuxfoundation.org, andriy.shevchenko@linux.intel.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] pps: generators: tio: fix platform_set_drvdata()
Date: Sun, 16 Mar 2025 16:24:13 +0100 [thread overview]
Message-ID: <6939b245-3ff9-431e-8acb-68fed13d276d@enneenne.com> (raw)
In-Reply-To: <20250315133140.1707949-1-raag.jadav@intel.com>
On 15/03/25 14:31, Raag Jadav wrote:
> Set driver_data correctly and fix illegal memory access on driver reload.
>
> Fixes: c89755d1111f ("pps: generators: Add PPS Generator TIO Driver")
> Signed-off-by: Raag Jadav <raag.jadav@intel.com>
Acked-by: Rodolfo Giometti <giometti@enneenne.com>
> ---
> drivers/pps/generators/pps_gen_tio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pps/generators/pps_gen_tio.c b/drivers/pps/generators/pps_gen_tio.c
> index 6c46b46c66cd..6e4a383957d9 100644
> --- a/drivers/pps/generators/pps_gen_tio.c
> +++ b/drivers/pps/generators/pps_gen_tio.c
> @@ -230,7 +230,7 @@ static int pps_gen_tio_probe(struct platform_device *pdev)
> hrtimer_init(&tio->timer, CLOCK_REALTIME, HRTIMER_MODE_ABS);
> tio->timer.function = hrtimer_callback;
> spin_lock_init(&tio->lock);
> - platform_set_drvdata(pdev, &tio);
> + platform_set_drvdata(pdev, tio);
>
> return 0;
> }
>
> base-commit: 6f119e3da79ce5e586340059403ab77201c1bb45
--
GNU/Linux Solutions e-mail: giometti@enneenne.com
Linux Device Driver giometti@linux.it
Embedded Systems phone: +39 349 2432127
UNIX programming
next prev parent reply other threads:[~2025-03-16 15:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-15 13:31 [PATCH v1] pps: generators: tio: fix platform_set_drvdata() Raag Jadav
2025-03-16 15:24 ` Rodolfo Giometti [this message]
2025-03-17 7:26 ` Andy Shevchenko
2025-03-17 7:40 ` Raag Jadav
2025-03-17 7:47 ` Andy Shevchenko
2025-03-17 7:32 ` Greg KH
2025-03-17 7:43 ` Raag Jadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6939b245-3ff9-431e-8acb-68fed13d276d@enneenne.com \
--to=giometti@enneenne.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=raag.jadav@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox