From: Reinette Chatre <reinette.chatre@intel.com>
To: Bhaskar Chowdhury <unixbhaskar@gmail.com>,
fenghua.yu@intel.com, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, x86@kernel.org, hpa@zytor.com,
linux-kernel@vger.kernel.org, gustavo@embeddedor.com
Cc: rdunlap@infradead.org
Subject: Re: [PATCH V3] arch: x86: kernel: cpu: Takes a letter away and append a colon to match below stuc member
Date: Tue, 12 Jan 2021 08:42:40 -0800 [thread overview]
Message-ID: <6964dc91-f87d-22c8-002d-164cf9da52b5@intel.com> (raw)
In-Reply-To: <20210112110131.23378-1-unixbhaskar@gmail.com>
Hi Bhaskar,
Thank you for fixing this.
Could you please fix the subject line to:
1) have correct prefix of "x86/resctrl:". You can see the custom by
running "git log arch/x86/kernel/cpu/resctrl".
2) fix the typo: stuc -> struct
On 1/12/2021 3:01 AM, Bhaskar Chowdhury wrote:
> s/kernlfs/kernfs/
> s/@mon_data_kn/@mon_data_kn:/
>
> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
> ---
> Changes from V2: Modified the subject line to match exact change description
>
> arch/x86/kernel/cpu/resctrl/internal.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kernel/cpu/resctrl/internal.h b/arch/x86/kernel/cpu/resctrl/internal.h
> index ee71c47844cb..ef9e2c0809b8 100644
> --- a/arch/x86/kernel/cpu/resctrl/internal.h
> +++ b/arch/x86/kernel/cpu/resctrl/internal.h
> @@ -142,7 +142,7 @@ enum rdtgrp_mode {
>
> /**
> * struct mongroup - store mon group's data in resctrl fs.
> - * @mon_data_kn kernlfs node for the mon_data directory
> + * @mon_data_kn: kernfs node for the mon_data directory
> * @parent: parent rdtgrp
> * @crdtgrp_list: child rdtgroup node list
> * @rmid: rmid for this rdtgroup
> --
> 2.26.2
>
Thank you
Reinette
prev parent reply other threads:[~2021-01-12 16:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 11:01 [PATCH V3] arch: x86: kernel: cpu: Takes a letter away and append a colon to match below stuc member Bhaskar Chowdhury
2021-01-12 16:42 ` Reinette Chatre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6964dc91-f87d-22c8-002d-164cf9da52b5@intel.com \
--to=reinette.chatre@intel.com \
--cc=bp@alien8.de \
--cc=fenghua.yu@intel.com \
--cc=gustavo@embeddedor.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rdunlap@infradead.org \
--cc=tglx@linutronix.de \
--cc=unixbhaskar@gmail.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox