From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S965193AbcIXRVD (ORCPT <rfc822;w@1wt.eu>);
        Sat, 24 Sep 2016 13:21:03 -0400
Received: from mout.web.de ([217.72.192.78]:49923 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1755556AbcIXRU7 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 24 Sep 2016 13:20:59 -0400
Subject: Re: Input-gameport: Replace some printk() calls by pr_info() in
 joydump_connect()
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
References: <d8da8333-d83a-ca61-b887-7fd7528c63a4@users.sourceforge.net>
 <f486d64d-0759-9cd6-1e4e-df723acb6fea@users.sourceforge.net>
 <1474733610.23838.2.camel@perches.com>
 <8164eb48-e3fa-fa9d-6351-f14b595a6dc3@users.sourceforge.net>
 <20160924163912.GA40187@dtor-ws>
Cc: Joe Perches <joe@perches.com>, linux-input@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org,
        Julia Lawall <julia.lawall@lip6.fr>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <69699b11-88fb-93ea-24a2-9ff697b5f439@users.sourceforge.net>
Date: Sat, 24 Sep 2016 19:20:48 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.3.0
MIME-Version: 1.0
In-Reply-To: <20160924163912.GA40187@dtor-ws>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:VwiP9rrgh+pRrYjA3XHvyeie+pMxYK7sZcZb+85NYNXbcQVG+I3
 lO4mqf5V98bcmkYqC4TYb76AcMMZ6pilRKrfGN/Fa7ogy8dx079IZF7uCXp5zvFyM8ncdxt
 xEixuTMy6zpyUKsMRry7H+GHoGy8Ta54Obp1OUGmm6h5hM35dREPRJta9or+knxAI+JID7a
 PUBcl9PX1AY4o95AUWrPA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:LQHEK3DnPgk=:UswSy85ZOyreu0tHeyKOsZ
 fzHw17NI3slnOgEOFiF2z/zAAfKnszW0m9nbmHrl5odIkt4FCQMkYCHe2GvaHJoMRl9CcKWPZ
 5Y1lnTQfDkAjxz8Hz36/xEbdpf95U/DmuXtkjWo9o/Gkz8c4M5jORB8upMGsW071SYoYiEpsn
 H3WrGauyPRW8HwJT1giVAU9fB+iRy9JkFa1v2StDGoosi+rDh4uBUaGZRLKryz7fL4fIWTIuc
 UqoNcLAgJi1WR11/bAiaNzoWrWit28plf2X7dGcLZi7lqSbp84WeDlU5a1S4qqkyNUEJ0FP6U
 qPyBWHXFeihq3onTb9Vvcz6MTB/GcR1g3Fn86p4/mN4qTAcDU753jMrBPByZpJFgr71vkUKMJ
 nEN1GHeh7obB1Np2Gxa6uoDwi5/fpTcOXssGvCfb1tGbyIUGj4kqH1psXWYZlpndD/+3pORHl
 P2eLWjXwscNlPNiXYyEP6De1OJKMOt2kRofTrqDsQi7MYxbLRGH+KewaDQpx8HNGF1QUedrvj
 ynLCLJDY7ZfUxgAh2DziV8ZKdannMcQXIikLlormIZlZqBknyavYhjoUkMDlXxOQvw/FRFiwe
 Wk7yzf2EWU6MgjdsosQmxxD+rwQpUbPL8AGjf+uhXDGIOmT1B0PkXRRepXx7V8pEnn2Ba9OsC
 dTXxdb95aIiYAEVc3apzdi2v07kpG1Bw1Y64D2eF9i2R8LygMrylpNbTJgyXVt2G2W2qkpXrJ
 +lPstw75AqtZ5zyXsxhHNAslQcOvoGWWTu/F78EXaFK7JMRsbEN1BhJchB10Gf/KA6GuEdiIB
 BYm9GvJ
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> The desired output should not be broken in conversion, which you did.

I dared to change another source code place a bit too much perhaps.


> Do you know how syslog works and why the transformation is not correct.

I imagine that there are chances to improve the software situation a bit more,
aren't there?


> I am also curious as to why you are patching joydump?

The discussed function implementation contains update candidates.

One of them was detected by the execution of a script for the semantic patch
language (Coccinelle software).
I identified further update possibilities after the opportunity for using
the function "kmalloc_array" also in this software module.


> Are you working on extending it?

I attempted just another software refactoring.

Regards,
Markus